Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020268Openbravo ERP07. Sales managementpublic2012-04-15 04:452012-06-02 17:18
Reporterfleroux 
Assigned Tonaiaramartinez 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version3.0MP9 
Target VersionFixed in Version3.0MP12 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020268: Create new invoices
DescriptionWhen creatig new invoices i see the attached errors (which I think is reventing the totals to be populated correctly)
Steps To Reproducecrete an invoice an invice lines + add some taxes
Proposed Solution
Additional Information
TagsMIR-Reviewed
Relationships
Attached Filesrtf SMSelecterror.rtf (11,346) 2012-04-15 04:45
https://issues.openbravo.com/file_download.php?file_id=5132&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-04-15 04:45flerouxNew Issue
2012-04-15 04:45flerouxAssigned To => vmromanos
2012-04-15 04:45flerouxFile Added: SMSelecterror.rtf
2012-04-15 04:45flerouxWeb browser => Google Chrome
2012-04-15 04:45flerouxModules => Core
2012-04-19 17:09miruritaTag Attached: MIR-Reviewed
2012-04-20 10:38naiaramartinezAssigned Tovmromanos => naiaramartinez
2012-04-20 10:41naiaramartinezNote Added: 0047775
2012-04-20 10:41naiaramartinezStatusnew => feedback
2012-05-12 01:30flerouxNote Added: 0048589
2012-05-18 08:46naiaramartinezNote Added: 0048753
2012-05-18 08:56naiaramartinezStatusfeedback => scheduled
2012-05-18 08:56naiaramartinezfix_in_branch => pi
2012-05-31 17:01hgbotCheckin
2012-05-31 17:01hgbotNote Added: 0049547
2012-05-31 17:01hgbotStatusscheduled => resolved
2012-05-31 17:01hgbotResolutionopen => fixed
2012-05-31 17:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/55e2c985a8bfc93bdf21f8395cdcf6825ba709e9 [^]
2012-05-31 17:06miruritaNote Added: 0049548
2012-05-31 17:06miruritaStatusresolved => closed
2012-05-31 17:06miruritaFixed in Version => 3.0MP12
2012-06-02 17:18hudsonbotCheckin
2012-06-02 17:18hudsonbotNote Added: 0049586

Notes
(0047775)
naiaramartinez   
2012-04-20 10:41   
Can you tell us exactly how you reproduce it? We create an invoice, add lines and add taxes and we can't reproduce it.
(0048589)
fleroux   
2012-05-12 01:30   
apologies for the delay in getting back to you; this happens when i create invoice lines. and it consistently happens
(0048753)
naiaramartinez   
2012-05-18 08:46   
The error happened when there wasn't any warehouse defined on the session.

Test Plan:
  Login with 'QA Testing Admin' role.
  Go to Warehouse and Storage Bins window. Deactivate all the warehouses that are defined.
  Logout and login again with 'QA Testing Admin' role.

  Go to Sales Invoice window. Add a new header and save it.
  Go to lines tab. Create new line. Press magnifying glass near Product field. Notice that there is no error messages.
(0049547)
hgbot   
2012-05-31 17:01   
Repository: erp/devel/pi
Changeset: 55e2c985a8bfc93bdf21f8395cdcf6825ba709e9
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Fri May 18 08:39:14 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/55e2c985a8bfc93bdf21f8395cdcf6825ba709e9 [^]

fixed issue 20268 Change filter expression.Add a validation for null warehouse

---
M src-db/database/sourcedata/OBUISEL_SELECTOR_FIELD.xml
---
(0049548)
mirurita   
2012-05-31 17:06   
code review + testing OK

prevent NPE on Product selector when there is no active warehouse on the client:

javax.script.ScriptException: sun.org.mozilla.javascript.EcmaError: TypeError: Cannot read property "id" from null (<Unknown source>#1) in <Unknown source> at line number 1
    at com.sun.script.javascript.RhinoScriptEngine.eval(RhinoScriptEngine.java:179)
    at com.sun.script.javascript.RhinoScriptEngine.eval(RhinoScriptEngine.java:195)
(0049586)
hudsonbot   
2012-06-02 17:18   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/d1995ebc438c [^]

Maturity status: Test