Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020266Openbravo ERPA. Platformpublic2012-04-13 15:112012-05-02 17:28
Reportershuehner 
Assigned Tomigueldejuana 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP11 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020266: ant install.source does not clean src-core/build, src-trl/build and src-wad/build
Descriptionant install.source does indirectly delete + recreate the main build folder
but does not do the same for the three sub-projects' build folders.

src-core/build
src-trl/build
src-wad/build

So old .class files present there will not be removed one a new install.source run.

Noticed in try as stale old .class files are still lying around after new compiles which does affect the api-check in some special situations.

Note: eclipse.install.source most like has the same problem.
Steps To Reproducechange one src-core java file to create a new inner class (as that produces a second .class file in addition to the normal one)
run ant core.lib to recompile core
now undo the java code-change
run ant install.source
noticed that the second .class file is still present and was not removed by ant install.source
Proposed SolutionManual fix is to run i.e.

ant -f src-core/build.xml clean
ant -f src-trlbuild.xml clean
ant -f src-wad/build.xml clean


Some equivalent of that in the correct place of install.source + eclipse.install.source should probably be sufficient.

note, probably a new small target should be added to call those three + that new target added to the depends line of 'install.source' & 'eclipse.install.source' after init before calling 'create.database'
Additional Information
TagsNo tags attached.
Relationships
related to defect 0010943 closed shankarb ant clean target should really clean 
related to defect 0041924 new Triage Platform Base ant clean unification 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-04-13 15:11shuehnerNew Issue
2012-04-13 15:11shuehnerAssigned To => alostale
2012-04-13 15:11shuehnerModules => Core
2012-04-13 15:11shuehnerOBNetwork customer => No
2012-04-16 14:29alostaleAssigned Toalostale => migueldejuana
2012-04-17 13:36hgbotCheckin
2012-04-17 13:36hgbotNote Added: 0047669
2012-04-17 13:36hgbotStatusnew => resolved
2012-04-17 13:36hgbotResolutionopen => fixed
2012-04-17 13:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/bc914387cb253e0d74aea3547d8d1575c0fd69ee [^]
2012-04-17 13:38migueldejuanaNote Added: 0047670
2012-04-17 18:02hgbotCheckin
2012-04-17 18:02hgbotNote Added: 0047676
2012-04-17 18:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/bc914387cb253e0d74aea3547d8d1575c0fd69ee [^] => http://code.openbravo.com/erp/devel/pi/rev/9f69a26123c3817e57782d580531c13d39e754e9 [^]
2012-04-18 18:01migueldejuanaNote Added: 0047718
2012-04-21 14:24hudsonbotCheckin
2012-04-21 14:24hudsonbotNote Added: 0047821
2012-04-21 14:24hudsonbotCheckin
2012-04-21 14:24hudsonbotNote Added: 0047823
2012-04-23 11:22AugustoMauchNote Added: 0047869
2012-04-23 11:22AugustoMauchStatusresolved => closed
2012-04-23 11:22AugustoMauchFixed in Version => 3.0MP11
2012-05-02 17:22migueldejuanaAssigned Tomigueldejuana => rgoris
2012-05-02 17:22migueldejuanaStatusclosed => new
2012-05-02 17:22migueldejuanaResolutionfixed => open
2012-05-02 17:22migueldejuanaFixed in Version3.0MP11 =>
2012-05-02 17:27migueldejuanaStatusnew => scheduled
2012-05-02 17:27migueldejuanaAssigned Torgoris => migueldejuana
2012-05-02 17:27migueldejuanafix_in_branch => pi
2012-05-02 17:28migueldejuanaStatusscheduled => resolved
2012-05-02 17:28migueldejuanaFixed in Version => 3.0MP11
2012-05-02 17:28migueldejuanaResolutionopen => fixed
2012-05-02 17:28migueldejuanaNote Added: 0048241
2012-05-02 17:28migueldejuanaStatusresolved => closed
2012-05-11 10:45shuehnerRelationship addedrelated to 0010943
2019-10-03 10:35gorka_gilRelationship addedrelated to 0041924

Notes
(0047669)
hgbot   
2012-04-17 13:36   
Repository: erp/devel/pi
Changeset: bc914387cb253e0d74aea3547d8d1575c0fd69ee
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Apr 17 13:34:24 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/bc914387cb253e0d74aea3547d8d1575c0fd69ee [^]

Fixed issue 20266: install.source clean src-core,src-trl & src-wad build folder
New small target have been added to call src-core,src-trl and src-wad clean target. This new target have been added to the depends line of 'install.source' & 'eclipse.install.source' after init before calling 'create.database'.

---
M build.xml
---
(0047670)
migueldejuana   
2012-04-17 13:38   
Test Plan:

-See Steps To Reproduce and Proposed Solution.


Should be no risky.
(0047676)
hgbot   
2012-04-17 18:02   
Repository: erp/devel/pi
Changeset: 9f69a26123c3817e57782d580531c13d39e754e9
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Apr 17 18:00:02 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/9f69a26123c3817e57782d580531c13d39e754e9 [^]

Fixed issue 20266: install.source clean src-core,src-trl & src-wad build folder
New small target have been added to call src-core,src-trl and src-wad clean target. This new target have been added to the depends line of 'install.source' & 'eclipse.install.source' after init before calling 'create.database'.

---
M build.xml
---
(0047718)
migueldejuana   
2012-04-18 18:01   
changeset: 16111:8f43187f575a
user: Miguel de Juana <miguel.dejuana@openbravo.com>
date: Tue Apr 17 14:40:31 2012 +0200
summary: related to 20266: Backout, error install.source
(0047821)
hudsonbot   
2012-04-21 14:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2eb57286c1fc [^]

Maturity status: Test
(0047823)
hudsonbot   
2012-04-21 14:24   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2eb57286c1fc [^]

Maturity status: Test
(0047869)
AugustoMauch   
2012-04-23 11:22   
Clode reviewed and verified in pi@4c5f3e0c2556.
(0048241)
migueldejuana   
2012-05-02 17:28   
It has been reopened by accident.