Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020251Openbravo ERP07. Sales managementpublic2012-04-12 12:202012-04-17 05:31
Reporterjonalegriaesarte 
Assigned Toguilleaer 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP9 
Target Version3.0MP11Fixed in Version3.0MP11 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020251: Under special conditions the business partner callout in orders windows, fails
DescriptionUnder special conditions the business partner callout in orders windows, fails.
Steps To Reproduce- All the business partners should be checked as Sales representative = N
- Create a new sales order
- Select a business partner
- The invoice rule combo is not loaded. So the order can not be saved
Proposed SolutionThe problem comes from this changeset: https://code.openbravo.com/erp/devel/pi/rev/cac07d43bece [^]
In org.openbravo.erpCommon.ad_callouts.SE_Order_BPartner, in invoice rule section, the change:
- resultado.append("new Array(\"inpinvoicerule\", ");
- if (l != null && l.length > 0) {
- resultado.append("new Array(");
+ if (tld != null && tld.length > 0) {
+ info.addSelect("inpinvoicerule");

is generating the inconsistency, because it is using the tld variable, which is not correct
Additional Information
TagsRegression
Relationships
related to design defect 00196753.0MP9 closed guilleaer Some callouts should be re-factorized 
blocks defect 0020213 closed thirumalaik Invoicerule issue in Purchase order 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-04-12 12:20jonalegriaesarteNew Issue
2012-04-12 12:20jonalegriaesarteAssigned To => guilleaer
2012-04-12 12:20jonalegriaesarteModules => Core
2012-04-12 12:20jonalegriaesarteTag Attached: Regression
2012-04-12 12:21jonalegriaesarteRelationship addedrelated to 0019675
2012-04-12 12:44hgbotCheckin
2012-04-12 12:44hgbotNote Added: 0047517
2012-04-12 12:44hgbotStatusnew => resolved
2012-04-12 12:44hgbotResolutionopen => fixed
2012-04-12 12:44hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/83facabed792547fd4f549cf40ab5c79f9c9ef14 [^]
2012-04-12 12:53guilleaerNote Added: 0047522
2012-04-12 18:02AugustoMauchNote Added: 0047543
2012-04-12 18:02AugustoMauchStatusresolved => closed
2012-04-12 18:02AugustoMauchFixed in Version => 3.0MP11
2012-04-17 05:31hudsonbotCheckin
2012-04-17 05:31hudsonbotNote Added: 0047638
2012-04-30 09:54jonalegriaesarteRelationship addedblocks 0020213

Notes
(0047517)
hgbot   
2012-04-12 12:44   
Repository: erp/devel/pi
Changeset: 83facabed792547fd4f549cf40ab5c79f9c9ef14
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Apr 12 12:43:25 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/83facabed792547fd4f549cf40ab5c79f9c9ef14 [^]

Fixed issue 20251: business partner callout problems have been solved

This problem was produced in the refactoring process of the callout. This has been fixed by changing the wrong variable tld to the correct one l

---
M src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java
---
(0047522)
guilleaer   
2012-04-12 12:53   
Test plan:
Follow the defined steps to reproduce ir and check that all is working correctly

This fix is not risky.
(0047543)
AugustoMauch   
2012-04-12 18:02   
Code reviewed and verified in pi@67c0f9be4dff
(0047638)
hudsonbot   
2012-04-17 05:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cedf57621434 [^]

Maturity status: Test