Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020190Openbravo ERP09. Financial managementpublic2012-04-02 20:352012-04-17 05:31
Reporterpsarobe 
Assigned Tomarvintm 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionpiFixed in Version3.0MP11 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020190: Add details (Payment OUT/IN) button does not work if the role doesn't have access to Currency window
DescriptionAdd details (Payment OUT/IN) button does not work if the role doesn't have access to Currency window
Steps To Reproduce1. Select/create a role that has no access to Currency window
2. Go to payment in window
3. Create the header and save
4. Click Add details

An error appears

Expected result: The button opens
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-04-02 20:35psarobeNew Issue
2012-04-02 20:35psarobeAssigned To => marvintm
2012-04-02 20:35psarobeModules => Core
2012-04-03 12:52hgbotCheckin
2012-04-03 12:52hgbotNote Added: 0047335
2012-04-03 12:52hgbotStatusnew => resolved
2012-04-03 12:52hgbotResolutionopen => fixed
2012-04-03 12:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6f3b6b6a996c3ff9a3ac2a97fa37b534667f4f48 [^]
2012-04-03 12:54marvintmNote Added: 0047336
2012-04-03 16:54AugustoMauchNote Added: 0047355
2012-04-03 16:54AugustoMauchStatusresolved => closed
2012-04-03 16:54AugustoMauchFixed in Version => 3.0MP11
2012-04-17 05:31hudsonbotCheckin
2012-04-17 05:31hudsonbotNote Added: 0047602

Notes
(0047335)
hgbot   
2012-04-03 12:52   
Repository: erp/devel/pi
Changeset: 6f3b6b6a996c3ff9a3ac2a97fa37b534667f4f48
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Tue Apr 03 12:32:32 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6f3b6b6a996c3ff9a3ac2a97fa37b534667f4f48 [^]

Fixed issue 20190. Added admin mode so that the process doesn't fail if the role doesn't have access to the currency window

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.java
---
(0047336)
marvintm   
2012-04-03 12:54   
Test plan:
- Verify that in our common roles the process still works correctly
- Verify that in a customized role without access to the Currency window the process now works correctly.

The fix is not risky. Now, admin mode is used to retrieve the currency standard precision, so that this can be done in roles without access to the Currency window.
(0047355)
AugustoMauch   
2012-04-03 16:54   
Code reviewed and verified in pi@a7a033bc1534.
(0047602)
hudsonbot   
2012-04-17 05:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cedf57621434 [^]

Maturity status: Test