Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0020187Openbravo ERP09. Financial managementpublic2012-04-02 16:562012-04-13 13:44
mirurita 
AugustoMauch 
normalmajorhave not tried
closedfixed 
5
 
3.0MP103.0MP10 
Core
No
0020187: Adding a GL Item to the payment: remove icon is not displayed (only the HTML code)
When adding a GL Item to a payment the remove icon is not displayed.
Each GL Item record should have a delete icon in the right side.
Instead of the icon the HTML code is displayed. The user is not able to remove a GL Item.
See attached screenshot.

Tested in Firefox and Chrome.
1) Go to Payment In window
2) Create a new Payment In
3) Click on Add Details button
4) Select 'GL Items' in transaction type combobox
5) Enter 2 in Amount field
6) Select a GL Item
7) Enter 2 in Received In field
8) Click on Add button
9) Realize that the remove button is not displayed.
   See attached screenshot.
No tags attached.
related to defect 0020035 closed AugustoMauch Payment In > Add details pop up: Cancel button does not work using Internet Explorer 
png Payment GLItem error.png (137,513) 2012-04-02 16:56
https://issues.openbravo.com/file_download.php?file_id=5118&type=bug
png
Issue History
2012-04-02 16:56miruritaNew Issue
2012-04-02 16:56miruritaAssigned To => vmromanos
2012-04-02 16:56miruritaFile Added: Payment GLItem error.png
2012-04-02 16:56miruritaModules => Core
2012-04-02 18:05miruritaAssigned Tovmromanos => AugustoMauch
2012-04-02 18:05miruritaRelationship addedrelated to 0020035
2012-04-02 18:22AugustoMauchStatusnew => scheduled
2012-04-02 18:22AugustoMauchfix_in_branch => pi
2012-04-02 18:22AugustoMauchStatusscheduled => resolved
2012-04-02 18:22AugustoMauchFixed in Version => 3.0MP10
2012-04-02 18:22AugustoMauchFixed in SCM revision => 4a2897439433
2012-04-02 18:22AugustoMauchResolutionopen => fixed
2012-04-02 18:23AugustoMauchNote Added: 0047324
2012-04-03 11:49miruritaNote Added: 0047331
2012-04-03 11:49miruritaStatusresolved => closed
2012-04-13 13:44hudsonbotCheckin
2012-04-13 13:44hudsonbotNote Added: 0047566

Notes
(0047324)
AugustoMauch   
2012-04-02 18:23   
Repository: erp/devel/pi
Changeset: 4a2897439433908ce9e0feebed875e8b35f87e8e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Apr 02 18:19:33 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4a2897439433908ce9e0feebed875e8b35f87e8e [^] [^]

Fixes issue: 20187: Remove button is displayed correctly in Payment In

In the fix of issue 20035, the AddOrderOrInvoice.html file was modified in order to make it compatible with Internet Explorer. That change broke the creation of the remove buttons in the window that is opened when the Add Details button is pushed in the Payment In window. Now, instead of using appendChild(document.createTextNode(text)) to modify the innerHTML property of DOM elementes, a div element is created and appended.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.html
(0047331)
mirurita   
2012-04-03 11:49   
Testing Plan

Tested browsers:
- Firefox 11
- Chrome 18.0.1025.113 beta
- Internet Explorer 9

1) Create a new Payment In
2) Click on Add Details button
3) Select 'GL Items' in transaction type combobox
4) Enter 4 in Amount field
5) Select a Gl Item
6) Enter 2 in Received In field
7) Click on Add button
8) Click again on Add button
9) Realize that you have two GL Item lines in the grid and the remove (cross) icon is displayed in the right side.
10) Remove both lines clicking the red cross icon.
(0047566)
hudsonbot   
2012-04-13 13:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5093a7ea6dbb [^]

Maturity status: Test