Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0020160 | Openbravo ERP | A. Platform | public | 2012-03-29 20:03 | 2012-05-10 16:30 |
|
| Reporter | guilleaer | |
| Assigned To | alostale | |
| Priority | immediate | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 20 | OS Version | Community Appliance |
| Product Version | 3.0MP8.1 | |
| Target Version | | Fixed in Version | pi | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | Google Chrome |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0020160: Read only windows are opened in edit mode when they are opened for the second time |
| Description | Read only windows are opened in edit mode when they are opened for the second time
|
| Steps To Reproduce | Steps to reproduce:
1. All of your modules must be no in-development
2. As "Group Admin" go to a read only window (i.e. "Matched invoice")
3. When the window is opened the toolbar buttons for adding and deleting rows will be disabled.
4. Close the tab and open it again. This time, the buttons for adding and deleting rows are enabled and they shouldn't. |
| Proposed Solution | |
| Additional Information | |
| Tags | Regression |
| Relationships | | related to | defect | 0020145 | 3.0MP11 | closed | alostale | Should not be possible to delete Matched Invoices records |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-03-29 20:03 | guilleaer | New Issue | |
| 2012-03-29 20:03 | guilleaer | Assigned To | => alostale |
| 2012-03-29 20:03 | guilleaer | Web browser | => Google Chrome |
| 2012-03-29 20:03 | guilleaer | Modules | => Core |
| 2012-03-29 20:06 | guilleaer | Relationship added | related to 0020145 |
| 2012-03-29 20:08 | shuehner | Issue Monitored: shuehner | |
| 2012-03-30 10:56 | alostale | Note Added: 0046960 | |
| 2012-03-30 10:59 | hgbot | Checkin | |
| 2012-03-30 10:59 | hgbot | Note Added: 0046961 | |
| 2012-03-30 10:59 | hgbot | Status | new => resolved |
| 2012-03-30 10:59 | hgbot | Resolution | open => fixed |
| 2012-03-30 10:59 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/c7a40d5e4b41c7b8cb1d6da8484adf367c6dea09 [^] |
| 2012-03-30 13:11 | guilleaer | Note Added: 0046979 | |
| 2012-03-30 13:11 | guilleaer | Status | resolved => closed |
| 2012-03-30 13:11 | guilleaer | Fixed in Version | => pi |
| 2012-04-02 06:13 | hudsonbot | Checkin | |
| 2012-04-02 06:13 | hudsonbot | Note Added: 0047282 | |
| 2012-05-10 16:30 | plujan | Tag Attached: Regression | |
|
Notes |
|
|
|
ReadOnly + other settings are not directly defined within tab but are got from WindowSettingsActionHandler. The problem is this is invoked and set just once per window/session if modules are not in development. It is correct not to invoke it multiple times as it can be cached, but it must be set each time window is opened again.
The fix caches the result of WindowSettingsActionHandler first time the window is opened in session and reuses it to set these settings again in future openings.
This fix is not risky.
Test plan, working always with all modules not in dev:
-Follow steps to reproduce and verify it doesn't happen again
-Recheck test plan for 0020145
-Check personalization still works. Within a professional instance:
-Open any window in grid mode and resize and reposition grid columns
-Close the window and open it again, previous settings should still be present
-Relogin and check settings are still present
-Create a personalization for form view, save it and apply
-Check it is still present when reopening the window and in new login |
|
|
|
(0046961)
|
|
hgbot
|
|
2012-03-30 10:59
|
|
Repository: erp/devel/pi
Changeset: c7a40d5e4b41c7b8cb1d6da8484adf367c6dea09
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 30 10:58:20 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c7a40d5e4b41c7b8cb1d6da8484adf367c6dea09 [^]
fixed bug 20160, fixed bug 20145: RO tab is set when reopening
Caching WindowSettingsActionHandler response on first window open and reusing
it in future openings.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
|
|
|
|
|
|
Code reviewed and tested in pi@028ac347cc43 |
|
|
|
|
|