Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020145Openbravo ERPA. Platformpublic2012-03-29 09:312012-05-10 16:33
Reportermaite 
Assigned Toalostale 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP11Fixed in Versionpi 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020145: Should not be possible to delete Matched Invoices records
DescriptionShould not be possible to delete Matched Invoices records
Steps To ReproduceThe first thing is to put all modules not "in development":
1- As "Group Admin" go to window "Matched invoice" and verify that all is in "Read Only" mode.
2- Close the window.
3- Go to window "Purchase Invoice"
4- Select purchase invoice "FC/70002" and go to tab Lines and open the line in form view.
5- Open the space "Linked Items" and navigate to related "matched invoice".
6- See that you are able to edit and delete the "Matched Invoice" record.
7- Also if you go to grid view, you will see that you can delete all matched invoices
Proposed Solution
Additional Information
TagsRegression QA
Relationships
related to defect 0017440 closed guilleaer Recent list shows '*' to create new for Tabs which have UIpattern 'read only' or 'single record' 
related to defect 0020160 closed alostale Read only windows are opened in edit mode when they are opened for the second time 
related to defect 0020153 closed alostale Incorrect linked items to inaccessible windows 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-29 09:31maiteNew Issue
2012-03-29 09:31maiteAssigned To => vmromanos
2012-03-29 09:31maiteModules => Core
2012-03-29 09:33maiteIssue Monitored: networkb
2012-03-29 09:35jonalegriaesarteAssigned Tovmromanos => jonalegriaesarte
2012-03-29 09:37jonalegriaesarteAssigned Tojonalegriaesarte => jecharri
2012-03-29 10:24jecharriAssigned Tojecharri => alostale
2012-03-29 10:24jecharriCategory03. Procurement management => A. Platform
2012-03-29 10:24jecharriSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3316#r3316
2012-03-29 14:03alostaleRelationship addedrelated to 0017440
2012-03-29 14:08hgbotCheckin
2012-03-29 14:08hgbotNote Added: 0046884
2012-03-29 14:08hgbotStatusnew => resolved
2012-03-29 14:08hgbotResolutionopen => fixed
2012-03-29 14:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b42654f43606c25cad0e0842f699ba505743889d [^]
2012-03-29 14:09alostaleNote Added: 0046885
2012-03-29 14:34alostaleNote Added: 0046887
2012-03-29 15:12alostaleRelationship addedrelated to 0020153
2012-03-29 19:07guilleaerNote Added: 0046947
2012-03-29 20:06guilleaerNote Added: 0046948
2012-03-29 20:06guilleaerStatusresolved => new
2012-03-29 20:06guilleaerResolutionfixed => open
2012-03-29 20:06guilleaerRelationship addedrelated to 0020160
2012-03-30 10:59hgbotCheckin
2012-03-30 10:59hgbotNote Added: 0046962
2012-03-30 10:59hgbotStatusnew => resolved
2012-03-30 10:59hgbotResolutionopen => fixed
2012-03-30 10:59hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/b42654f43606c25cad0e0842f699ba505743889d [^] => http://code.openbravo.com/erp/devel/pi/rev/c7a40d5e4b41c7b8cb1d6da8484adf367c6dea09 [^]
2012-03-30 12:46guilleaerNote Added: 0046971
2012-03-30 12:46guilleaerStatusresolved => closed
2012-03-30 12:46guilleaerFixed in Version => pi
2012-04-02 06:13hudsonbotCheckin
2012-04-02 06:13hudsonbotNote Added: 0047267
2012-04-02 06:13hudsonbotCheckin
2012-04-02 06:13hudsonbotNote Added: 0047283
2012-05-10 16:33plujanTag Attached: Regression QA

Notes
(0046884)
hgbot   
2012-03-29 14:08   
Repository: erp/devel/pi
Changeset: b42654f43606c25cad0e0842f699ba505743889d
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 29 14:06:07 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b42654f43606c25cad0e0842f699ba505743889d [^]

fixed bug 20145: Linked items to RO tabs allow to add/delete records

  Added readOnly and singleRecod information to linked items open action
  in order to properly display toolbar.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-linked-items.js
M src/org/openbravo/erpCommon/utility/UsedByLink.java
M src/org/openbravo/erpCommon/utility/UsedByLink_data.xsql
---
(0046885)
alostale   
2012-03-29 14:09   
No regression risk added.

Test plan: described in steps to reproduce
(0046887)
alostale   
2012-03-29 14:34   
Also check windows that are have readonly access per role (not in UI) are shown as readonly when accessing through linked items.
(0046947)
guilleaer   
2012-03-29 19:07   
This bug is reported correctly but the reason of this behavior is not the way to open a Read Only window from linked items table.

There is an easier way to reproduce this problem:

With no in-development modules and just after been logged, open a read-only window (i.e. Matched Invoices) the toolbar buttons for adding and deleting rows will be enabled. Close the tab and open it again. This time, the buttons for adding and deleting rows will be enabled.

The fix that Asier has done does not prevent this problem to happen in this general scenario but is necessary and correct.
(0046948)
guilleaer   
2012-03-29 20:06   
New issue has been created https://issues.openbravo.com/view.php?id=20160 [^]
(0046962)
hgbot   
2012-03-30 10:59   
Repository: erp/devel/pi
Changeset: c7a40d5e4b41c7b8cb1d6da8484adf367c6dea09
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri Mar 30 10:58:20 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c7a40d5e4b41c7b8cb1d6da8484adf367c6dea09 [^]

fixed bug 20160, fixed bug 20145: RO tab is set when reopening

  Caching WindowSettingsActionHandler response on first window open and reusing
  it in future openings.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0046971)
guilleaer   
2012-03-30 12:46   
Code reviewed and tested in pi@028ac347cc43
(0047267)
hudsonbot   
2012-04-02 06:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047283)
hudsonbot   
2012-04-02 06:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test