0020129: OBContext class getters returning a reference to the class instance attributes (not a new instance of the attribute)

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0020129

Openbravo ERP

A. Platform

public

2012-03-27 17:44

2012-05-25 12:10

Reporter

mirurita

Assigned To

AugustoMauch

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

3.0MP12

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0020129: OBContext class getters returning a reference to the class instance attributes (not a new instance of the attribute)

Description

OrganizationStructureProvider
OBContext class stores for all accessible clients the corresponding OrganizationStructureProvider.

Using the public API if you get the OrganizationStructureProvider of your client and then you query (i.e.) for the children organization the object you get is a reference of the attribute of OrganizationStructureProvider (not a new instance).

Set<String> orgIds = OBContext.getOBContext().getOrganizationStructureProvider() .getChildOrg(legalEntity.getId());

// When you add a new element to the list you are modifying the "global" list
orgIds.add(legalEntity.getId());

In OBContext class there are more examples:
private String[] readableOrganizations;
public String[] getReadableOrganizations()

private String[] readableClients;
public String[] getReadableClients()

...

Review all the attributes of OBContext class.

Steps To Reproduce

1) Check the value of the following attribute of OrganizationStructureProvider class:
private Map<String, Set<String>> childByOrganizationID = new HashMap<String, Set<String>>();

2) Execute this code
Set<String> orgIds = OBContext.getOBContext().getOrganizationStructureProvider() .getChildOrg(legalEntity.getId());
orgIds.add("MY CODE");

3) Check again the value of:
private Map<String, Set<String>> childByOrganizationID = new HashMap<String, Set<String>>();

Realize that "MY CODE" is a new element of the Map.

Proposed Solution

Return a new instance of the attribute, for example:

// BEFORE
  public Set<String> getNaturalTree(String orgId) {
    initialize();
    Set<String> result = naturalTreesByOrgID.get(orgId);
    if (result == null) {
      result = new HashSet<String>();
      result.add(orgId);
    }
    return result;
  }

// AFTER
  public Set<String> getNaturalTree(String orgId) {
    initialize();
    Set<String> result;
    if (naturalTreesByOrgID.get(orgId) == null) {
      result = new HashSet<String>();
      result.add(orgId);
    } else {
      result = new HashSet<String>(naturalTreesByOrgID.get(orgId));
    }
    return result;
  }

Additional Information

Tags

No tags attached.

Relationships

blocks

defect

0020424

closed

AugustoMauch

Change role takes 10 secons since you press "Apply" button

Attached Files