Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020114Openbravo ERP02. Master data managementpublic2012-03-26 15:462012-04-02 06:13
Reportervmromanos 
Assigned Tonaiaramartinez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionDebian 5.0
Product Version 
Target VersionFixed in Version3.0MP10 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020114: Bill of materials display logic
DescriptionProduct window, Bill of materials display logic is:
@IsSummary@='N' & @ProductType@='I' | @ProductType@='S'

When you enter Product window, the following error is written into the log:
>>>>>>> Issues found in javascript <<<<<<<<<
Core.View:186:301: The '&&' subexpression should be wrapped in parens. >> offending code: name: 'billOfMaterials', title: 'Bill of Materials', sessionProperty: true, hasDefaultValue: true,columnName: 'IsBOM', inpColumnName: 'inpisbom', redrawOnChange: true, showIf: function(item, value, form, currentValues, context) { return (OB.Utilities.getValue(currentValues,'summaryLevel') === false && OB.Utilities.getValue(currentValues,'productType') === 'I' || OB.Utilities.getValue(currentValues,'productType') === 'S'); }, "width":1,"overflow":"visible",
>>>>>>> Issues (6029ms) <<<<<<<<<

It looks like the display logic should be changed to:
(@IsSummary@='N' & @ProductType@='I') | @ProductType@='S'
Steps To ReproduceGo to Product Window
Create a new record
Check and uncheck Bill of materials checkbox
Read the server log
Proposed SolutionIt looks like the display logic should be changed to:
(@IsSummary@='N' & @ProductType@='I') | @ProductType@='S'
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-26 15:46vmromanosNew Issue
2012-03-26 15:46vmromanosAssigned To => alostale
2012-03-26 15:46vmromanosModules => Core
2012-03-26 15:46vmromanosAssigned Toalostale => vmromanos
2012-03-29 10:51naiaramartinezAssigned Tovmromanos => naiaramartinez
2012-03-29 10:52naiaramartinezStatusnew => scheduled
2012-03-29 10:52naiaramartinezfix_in_branch => pi
2012-03-29 11:25naiaramartinezNote Added: 0046868
2012-03-30 14:00hgbotCheckin
2012-03-30 14:00hgbotNote Added: 0046984
2012-03-30 14:00hgbotStatusscheduled => resolved
2012-03-30 14:00hgbotResolutionopen => fixed
2012-03-30 14:00hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6aee986e08a4b5f58f06543689532e8d377fec05 [^]
2012-03-30 14:01vmromanosNote Added: 0046985
2012-03-30 14:01vmromanosStatusresolved => closed
2012-03-30 14:01vmromanosFixed in Version => 3.0MP10
2012-04-02 06:13hudsonbotCheckin
2012-04-02 06:13hudsonbotNote Added: 0047287

Notes
(0046868)
naiaramartinez   
2012-03-29 11:25   
Test Plan:
  Go to Product Window
  Create a new record
  Check and uncheck Bill of materials checkbox
  Read the server log. Now you can see that there is not message related to:
   '>>>>>>> Issues found in javascript <<<<<<<<<'
(0046984)
hgbot   
2012-03-30 14:00   
Repository: erp/devel/pi
Changeset: 6aee986e08a4b5f58f06543689532e8d377fec05
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Thu Mar 29 11:11:36 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6aee986e08a4b5f58f06543689532e8d377fec05 [^]

fixed bug 20114 Bill of materials display logic

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0046985)
vmromanos   
2012-03-30 14:01   
code review + testing OK
(0047287)
hudsonbot   
2012-04-02 06:13   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test