0020078: Accounting engine stops in case of lots of organizations, and document types at organization level

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0020078

Openbravo ERP

09. Financial management

public

2012-03-21 16:20

2013-05-23 01:32

Reporter

dalsasua

Assigned To

eduardo_Argal

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0020078: Accounting engine stops in case of lots of organizations, and document types at organization level

Description

In an instance with 97 different organization, each of them with specific API/ARI/APC/ARC document types, accounting stops after processing couple of organizations.

Steps To Reproduce

Create dozens of organizations, each of them with it's own document types.
Create hundreds of invoices for distinct organizations
Run accounting background process
Realize that stops after a while, leaving unposted invoices

Proposed Solution

diff --git a/src/org/openbravo/erpCommon/ad_forms/AcctServer.java b/src/org/openbravo/erpCommon/ad_forms/AcctServer.java
--- a/src/org/openbravo/erpCommon/ad_forms/AcctServer.java
+++ b/src/org/openbravo/erpCommon/ad_forms/AcctServer.java
@@ -63,6 +63,7 @@
   public String AD_Table_ID = "";
   public String AD_Client_ID = "";
   public String AD_Org_ID = "";
+ public String Caller_AD_Org_ID = "";
   public String Status = "";
   public String C_BPartner_ID = "";
   public String C_BPartner_Location_ID = "";
@@ -281,6 +282,7 @@
   public AcctServer(String m_AD_Client_ID, String m_AD_Org_ID, ConnectionProvider connectionProvider) {
     AD_Client_ID = m_AD_Client_ID;
     AD_Org_ID = m_AD_Org_ID;
+ Caller_AD_Org_ID = m_AD_Org_ID;
     this.connectionProvider = connectionProvider;
     if (log4j.isDebugEnabled())
       log4j.debug("AcctServer - LOADING ARRAY: " + m_AD_Client_ID);
@@ -314,7 +316,7 @@

       log4j.debug("AcctServer.run - AD_Client_ID: " + AD_Client_ID);
       AcctServerData[] data = AcctServerData.select(connectionProvider, tableName, AD_Client_ID,
- AD_Org_ID, strDateColumn, 0, Integer.valueOf(batchSize).intValue());
+ Caller_AD_Org_ID, strDateColumn, 0, Integer.valueOf(batchSize).intValue());

       if (data != null && data.length > 0) {
         if (log4j.isDebugEnabled()) {
@@ -1729,9 +1731,9 @@
     // log4j.debug("AcctServer - AcctSchema length-" + (this.m_as).length);
     for (int i = 0; i < docTypes.length; i++) {
       AcctServerData data = AcctServerData.selectDocuments(connectionProvider, tableName,
- AD_Client_ID, AD_Org_ID, docTypes[i].name, strDateColumn);
+ AD_Client_ID, Caller_AD_Org_ID, docTypes[i].name, strDateColumn);

- if (data != null) {
+ if (data != null && data.id != null) {
         if (data.id != null && !data.id.equals("")) {
           if (log4j.isDebugEnabled()) {
             log4j.debug("AcctServer - not posted - " + docTypes[i].name + " document id: "

Additional Information