Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020040Openbravo ERPA. Platformpublic2012-03-15 17:292012-04-02 12:16
Reportermarvintm 
Assigned Tomarvintm 
PriorityimmediateSeveritycriticalReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP9Fixed in Version3.0MP9 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020040: The alert process creates a non-finishing transaction, thus blocking the Rebuild process
DescriptionThe alert process currently leaves the DAL transaction as non-committed. Several tables are locked because of this. Therefore, any Rebuild attempted after the alert process has run (and issued alerts) is blocked at some point.
Steps To Reproduce- Do ant install.source in current pi.
- Start tomcat. As the alerts process is now automatically scheduled, some alerts will be created (and therefore the process will also attempt to send emails).
- This creates a non-finishing transaction. You can notice this by executing the following command in the database:
select * from pg_stat_activity
- Any rebuild attempted after this will get stuck.
Proposed SolutionThe DAL connection in the AlertProcess needs to be committed before the process ends.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-15 17:29marvintmNew Issue
2012-03-15 17:29marvintmAssigned To => marvintm
2012-03-15 17:29marvintmModules => Core
2012-03-15 17:29marvintmOBNetwork customer => No
2012-03-15 17:37hgbotCheckin
2012-03-15 17:37hgbotNote Added: 0046472
2012-03-15 17:37hgbotStatusnew => resolved
2012-03-15 17:37hgbotResolutionopen => fixed
2012-03-15 17:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/89452d415b9034fe02e161dfb76d53cfc6208046 [^]
2012-03-15 18:28marvintmNote Added: 0046477
2012-03-15 18:35AugustoMauchNote Added: 0046478
2012-03-15 18:35AugustoMauchStatusresolved => closed
2012-03-15 18:35AugustoMauchFixed in Version => 3.0MP9
2012-04-01 20:33hgbotCheckin
2012-04-01 20:33hgbotNote Added: 0047012
2012-04-01 20:33hgbotStatusclosed => resolved
2012-04-01 20:33hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/89452d415b9034fe02e161dfb76d53cfc6208046 [^] => http://code.openbravo.com/erp/devel/pi/rev/e0024666eff862dc643620d9fa7c693d875f1741 [^]
2012-04-02 06:10hudsonbotCheckin
2012-04-02 06:10hudsonbotNote Added: 0047152
2012-04-02 12:16gorka_gilNote Added: 0047300
2012-04-02 12:16gorka_gilStatusresolved => closed

Notes
(0046472)
hgbot   
2012-03-15 17:37   
Repository: erp/devel/pi
Changeset: 89452d415b9034fe02e161dfb76d53cfc6208046
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Mar 15 17:36:41 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/89452d415b9034fe02e161dfb76d53cfc6208046 [^]

Fixed issue 20040. The DAL connection wil be committed so that the execution of the AlertProcess doesn't create a non-finishing transaction

---
M src/org/openbravo/erpCommon/ad_process/AlertProcess.java
---
(0046477)
marvintm   
2012-03-15 18:28   
Test plan:
* Test that exporting views still works in PostgreSQL and Oracle, and that views with LIKE statements are exported correctly.
* Test that update.database correctly creates views with LIKE statements.
(0046478)
AugustoMauch   
2012-03-15 18:35   
Code reviewed and verified.

Test made:
- Install.source in current pi. After it was finished, there were no non-finishing transactions in the database.
- Install a module.
- Execute ant update.database. The task finished without errors.
(0047012)
hgbot   
2012-04-01 20:33   
Repository: erp/devel/pi
Changeset: e0024666eff862dc643620d9fa7c693d875f1741
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Mar 15 17:36:41 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e0024666eff862dc643620d9fa7c693d875f1741 [^]

Fixed issue 20040. The DAL connection wil be committed so that the execution of the AlertProcess doesn't create a non-finishing transaction

---
M src/org/openbravo/erpCommon/ad_process/AlertProcess.java
---
(0047152)
hudsonbot   
2012-04-02 06:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047300)
gorka_gil   
2012-04-02 12:16   
Reopened by merge.