Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020035Openbravo ERPB. User interfacepublic2012-03-15 12:522012-04-13 13:44
Reporterplujan 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version3.0MP10 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserInternet Explorer
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020035: Payment In > Add details pop up: Cancel button does not work using Internet Explorer
DescriptionWhen opening the Add Details pop up in Payment In, clicking the Cancel button does nothing using Internet Explorer. When using Firefox and Chrome the button works as expected
Steps To Reproduce1. Login as QAAdmin
2. Go to Payment in window
3. Create a new record and save
4. Click the Add Details button
5. In the pop up window, click the Cancel button. Using Internet Explorer the button does nothing.
Proposed Solution
Additional Information
TagsRegression QA, RiskyReleaseTestingCycle
Relationships
related to defect 00201873.0MP10 closed AugustoMauch Adding a GL Item to the payment: remove icon is not displayed (only the HTML code) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-15 12:52plujanNew Issue
2012-03-15 12:52plujanAssigned To => AugustoMauch
2012-03-15 12:52plujanWeb browser => Internet Explorer
2012-03-15 12:52plujanModules => Core
2012-03-15 13:03plujanTag Attached: RiskyReleaseTestingCycle
2012-03-29 12:12hgbotCheckin
2012-03-29 12:12hgbotNote Added: 0046872
2012-03-29 12:12hgbotStatusnew => resolved
2012-03-29 12:12hgbotResolutionopen => fixed
2012-03-29 12:12hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a18b8dd9b8c4343ab70661b539f4c8f704adf2d4 [^]
2012-03-29 12:28AugustoMauchNote Added: 0046875
2012-03-29 17:15marvintmStatusresolved => closed
2012-03-29 17:15marvintmFixed in Version => 3.0MP10
2012-04-02 06:12hudsonbotCheckin
2012-04-02 06:12hudsonbotNote Added: 0047265
2012-04-02 18:05miruritaTag Attached: Regression QA
2012-04-02 18:05miruritaRelationship addedrelated to 0020187
2012-04-02 18:20hgbotCheckin
2012-04-02 18:20hgbotNote Added: 0047322
2012-04-13 13:44hudsonbotCheckin
2012-04-13 13:44hudsonbotNote Added: 0047567

Notes
(0046872)
hgbot   
2012-03-29 12:12   
Repository: erp/devel/pi
Changeset: a18b8dd9b8c4343ab70661b539f4c8f704adf2d4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Mar 29 12:12:17 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/a18b8dd9b8c4343ab70661b539f4c8f704adf2d4 [^]

Fixes issue 20035: Close button now works in Internet Explorer.

The file AddOrderOrInvoice.html was using a feature (assign text to the innerHTML property of certain web elements) that is not soported in IE. This asignation has been deleted, and it is now used a function, as proposed in http://stackoverflow.com/questions/1359469/innertext-works-in-ie-but-not-in-firefox/1359834#1359834. [^]

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.html
---
(0046875)
AugustoMauch   
2012-03-29 12:28   
Test plan

Test in IE and in Firefox ->
  The cancel button is now working:
  - Open the Payment In window
  - Create a record, fill in the Received From field and save.
  - Click the Add Details button. When the popup opens, click cancel. The window should close, and no error should be shown.
  The processing of the Add Details windows keeps working as expected.
  - Open the Sales Invoice window
  - Create a new record, select a Business Partner (i.e. Healthy Foods) and save.
  - Move to the lines tab, create a new record, select a product and set an invoiced quantity.
  - Save the line, and complete the invoice.
  - Open the Payment In window.
  - Create a new record.
  - Select in the Received From field the same Business Partner as in the new sales invoice.
  - Set an amount higher than the Net Amount field of the recently created line.
  - Save, and push the Add Details button.
  - When the popup opens, the recently created invoice should be selected. Press the process button, and continue.
  - The processing should end succesfully. Check that the lines have been added in the lines tab of Payment In, and check that in the sales invoice the Payment Complete Field now shows Yes, and that a record has been added in the Payment In Plan tab.
(0047265)
hudsonbot   
2012-04-02 06:12   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047322)
hgbot   
2012-04-02 18:20   
Repository: erp/devel/pi
Changeset: 4a2897439433908ce9e0feebed875e8b35f87e8e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Apr 02 18:19:33 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/4a2897439433908ce9e0feebed875e8b35f87e8e [^]

Fixes issue: 20187: Remove button is displayed correctly in Payment In

In the fix of issue 20035, the AddOrderOrInvoice.html file was modified in order to make it compatible with Internet Explorer. That change broke the creation of the remove buttons in the window that is opened when the Add Details button is pushed in the Payment In window. Now, instead of using appendChild(document.createTextNode(text)) to modify the innerHTML property of DOM elementes, a div element is created and appended.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.html
---
(0047567)
hudsonbot   
2012-04-13 13:44   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5093a7ea6dbb [^]

Maturity status: Test