Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020024Openbravo ERPA. Platformpublic2012-03-14 17:102012-04-26 19:32
Reporterplujan 
Assigned Tomigueldejuana 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionmain 
Target VersionFixed in Version3.0MP11 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020024: Autosave is not working when using tab selector
DescriptionIf I move among the tabs using the drop down list, autosave does not work.
Steps To Reproduce1. Login as QAAdmin
2. Go to Business Partner window
3. Create a new Business Partner and save
4. Go to Discount tab
5. Create a new record. Before saving move to a different tab using the List (see screenshot)
6. Check that autosave was not fired so the Discount is still unsaved.
Proposed Solution
Additional Information
TagsRiskyReleaseTestingCycle
Relationships
Attached Filespng Tab_switching.png (74,300) 2012-03-14 17:10
https://issues.openbravo.com/file_download.php?file_id=5080&type=bug
png

diff issue20024.diff (842) 2012-04-25 10:27
https://issues.openbravo.com/file_download.php?file_id=5169&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-03-14 17:10plujanNew Issue
2012-03-14 17:10plujanAssigned To => alostale
2012-03-14 17:10plujanFile Added: Tab_switching.png
2012-03-14 17:10plujanModules => Core
2012-03-14 17:11plujanTag Attached: RiskyReleaseTestingCycle
2012-03-14 17:32plujanversion => main
2012-04-20 10:41alostaleAssigned Toalostale => migueldejuana
2012-04-24 13:43hgbotCheckin
2012-04-24 13:43hgbotNote Added: 0047914
2012-04-24 13:43hgbotStatusnew => resolved
2012-04-24 13:43hgbotResolutionopen => fixed
2012-04-24 13:43hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ee033a584373ad615cb6237544558f1e63dd44e4 [^]
2012-04-24 16:38migueldejuanaNote Added: 0047924
2012-04-25 10:27iperdomoNote Added: 0047948
2012-04-25 10:27iperdomoStatusresolved => new
2012-04-25 10:27iperdomoResolutionfixed => open
2012-04-25 10:27iperdomoFile Added: issue20024.diff
2012-04-25 10:44migueldejuanaStatusnew => scheduled
2012-04-25 10:45migueldejuanaStatusscheduled => resolved
2012-04-25 10:45migueldejuanaFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ee033a584373ad615cb6237544558f1e63dd44e4 [^] => https://code.openbravo.com/erp/devel/pi/rev/4934b91dff52 [^]
2012-04-25 10:45migueldejuanaResolutionopen => fixed
2012-04-25 10:46migueldejuanaNote Added: 0047951
2012-04-25 10:52iperdomoNote Added: 0047953
2012-04-25 10:52iperdomoStatusresolved => closed
2012-04-25 10:52iperdomoFixed in Version => 3.0MP11
2012-04-26 19:32hudsonbotCheckin
2012-04-26 19:32hudsonbotNote Added: 0048080

Notes
(0047914)
hgbot   
2012-04-24 13:43   
Repository: erp/devel/pi
Changeset: ee033a584373ad615cb6237544558f1e63dd44e4
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Apr 24 13:34:38 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ee033a584373ad615cb6237544558f1e63dd44e4 [^]

Fixed issue 20024: Set focus well when selecting a tab using the picker list.
If there is not enough space to display all the tab-buttons in the tabSet, should a drop-down "picker" be displayed to allow selection of tabs that are clipped. Selecting a tab using this "picker", the chosen tab is selected but not focused. The behaviour focusing a tab using picker is the same as when the main tab is drawn. To solve this, it has been created a validation to know if picker exist or not.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-tab.js
---
(0047924)
migueldejuana   
2012-04-24 16:38   
Test plan:
- Change tabs using the "picker", pay attention to where the focus is.
- Test opening a window and the selecting tabs in different ways.
(0047948)
iperdomo   
2012-04-25 10:27   
The diff doesn't follow the the JS style-guide. Remember to install JSBeautifier plugin in Eclipse, and reformat your changes before pushing.

See the attached diff
(0047951)
migueldejuana   
2012-04-25 10:46   
Because an error, the changeset url is:

https://code.openbravo.com/erp/devel/pi/rev/4934b91dff52 [^]
(0047953)
iperdomo   
2012-04-25 10:52   
Tested on pi @ rev 4934b91dff52
(0048080)
hudsonbot   
2012-04-26 19:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/70a717a9ffa1 [^]

Maturity status: Test