Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0020021 | Openbravo ERP | B. User interface | public | 2012-03-14 13:05 | 2012-05-28 09:36 |
|
| Reporter | dbaz | |
| Assigned To | AugustoMauch | |
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0MP12 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0020021: Text, Number, Date and DateTime inputs should not allow enter more characters than allowed |
| Description | Text, Number, Date and DateTime inputs should not allow enter more characters than allowed, in both grid and form view. |
| Steps To Reproduce | Test in Openbravo each kind of fields, and notice, that, for example, in form view, you can enter as much characters as you want in a text input.
If you enter more characters than defined in ad_column.length, an error message bar is shown telling that the save can not be done. That is wrong (in terms of UX), the input shouln't allow enter more characters
|
| Proposed Solution | Add a length property (taken from ad_column.length) to the mentioned references.
NOTE: Combos, selectors, ... should NOT have this restriction. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | has duplicate | defect | 0018822 | | closed | marvintm | Data is truncated instead of being validated if its size is greater than the field length |
|
| Attached Files |  issue20021.diff (3,379) 2012-04-24 17:43
https://issues.openbravo.com/file_download.php?file_id=5166&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-03-14 13:05 | dbaz | New Issue | |
| 2012-03-14 13:05 | dbaz | Assigned To | => AugustoMauch |
| 2012-03-14 13:05 | dbaz | Modules | => Core |
| 2012-03-14 13:05 | dbaz | OBNetwork customer | => No |
| 2012-04-20 10:06 | AugustoMauch | Relationship added | related to 0018822 |
| 2012-04-23 12:40 | AugustoMauch | Relationship replaced | has duplicate 0018822 |
| 2012-04-24 14:31 | AugustoMauch | Note Added: 0047915 | |
| 2012-04-24 14:34 | dbaz | Note Added: 0047916 | |
| 2012-04-24 17:43 | AugustoMauch | File Added: issue20021.diff | |
| 2012-05-03 13:01 | hgbot | Checkin | |
| 2012-05-03 13:01 | hgbot | Note Added: 0048322 | |
| 2012-05-03 13:01 | hgbot | Status | new => resolved |
| 2012-05-03 13:01 | hgbot | Resolution | open => fixed |
| 2012-05-03 13:01 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/2062dd7f2e7b81350aecf0ff89a64f2f7b287060 [^] |
| 2012-05-03 13:07 | AugustoMauch | Note Added: 0048323 | |
| 2012-05-03 13:09 | AugustoMauch | Note Added: 0048324 | |
| 2012-05-25 12:09 | hudsonbot | Checkin | |
| 2012-05-25 12:09 | hudsonbot | Note Added: 0049001 | |
| 2012-05-28 09:36 | guilleaer | Note Added: 0049334 | |
| 2012-05-28 09:36 | guilleaer | Status | resolved => closed |
| 2012-05-28 09:36 | guilleaer | Fixed in Version | => 3.0MP12 |
|
Notes |
|
|
|
I think this approach should not be applied to number fields.
For example, if a number field has a column length of 5, it should be possible to enter '=1000-200', because the result is '800'. With the new restriction, the user would not be able to enter more text after '=1000'. |
|
|
|
(0047916)
|
|
dbaz
|
|
2012-04-24 14:34
|
|
|
Fully agree. Don't apply it to number fields |
|
|
|
(0048322)
|
|
hgbot
|
|
2012-05-03 13:01
|
|
Repository: erp/devel/pi
Changeset: 2062dd7f2e7b81350aecf0ff89a64f2f7b287060
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu May 03 12:46:32 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/2062dd7f2e7b81350aecf0ff89a64f2f7b287060 [^]
Fixes issue 20021: Text and date field use length property
The length property has been added to the form items of text and date fields. It has not been added to numeric fields, because it would have interfered with the ability to enter expressions.
For date fields, the length propertly is applied to its textField attribute.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/DateUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/StringUIDefinition.java
---
|
|
|
|
|
Test plan: check that text and dates fields are using the length property in the form view (the behaviour in the grid view should not have been modified).
In example:
- Create a new sales order
- Try to enter more than 30 characters in the Document No. field
- Try to enter more than 10 characters (i.e. 01-02-20131) in the Order Date field.
- Create a new unit of measure
- Try to enter more than 2 characters in the EDI Code field. |
|
|
|
|
I think this issue is not risky.
No existing values will be truncated, because it is not possible to enter in a database a value longer than its column length, which is the property being used to set the length property of text and date fields in the form view. |
|
|
|
|
|
|
|
|
|
Code reviewed and tested in pi@af4557ab55b2 |
|