Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0020015Openbravo ERP07. Sales managementpublic2012-03-14 01:482012-04-17 05:31
chelipf 
Sandrahuguet 
normalminoralways
closedfixed 
30
2.50MP33.1 
 
Mozilla Firefox
Core
No
0020015: Create Lines From in Sales invoices doesn't set Excludeforwithholding field properly
Excludeforwithholding column of C_INVOICELINE table is a boolean column and it must only accept Y or N values. When "creating lines from" is processed, Excludeforwithholding is set to null.
- Create a new sales invoice header.
- Push create lines from button.
- Set Excludeforwithholding column as "not null".
- Create a new constraint in order to Excludeforwithholding only accepts Y or N values.
- Fix Create Lines From process in order to set Excludeforwithholding to N instead to null.
No tags attached.
related to defect 0020038 closed naiaramartinez Create Lines From in Sales invoices doesn't set taxamt and taxbaseamt fields properly 
Issue History
2012-03-14 01:48chelipfNew Issue
2012-03-14 01:48chelipfAssigned To => vmromanos
2012-03-14 01:48chelipfWeb browser => Mozilla Firefox
2012-03-14 01:48chelipfModules => Core
2012-03-15 00:35chelipfNote Added: 0046436
2012-03-15 01:12chelipfIssue Monitored: chelipf
2012-04-04 13:17SandrahuguetAssigned Tovmromanos => Sandrahuguet
2012-04-04 13:17SandrahuguetStatusnew => scheduled
2012-04-04 13:17Sandrahuguetfix_in_branch => pi
2012-04-04 15:50chelipfNote Edited: 0046436bug_revision_view_page.php?bugnote_id=0046436#r3342
2012-04-04 15:50chelipfNote Edited: 0046436bug_revision_view_page.php?bugnote_id=0046436#r3343
2012-04-04 15:59SandrahuguetRelationship addedrelated to 0020038
2012-04-04 16:02SandrahuguetRelationship deletedrelated to 0020038
2012-04-04 16:24SandrahuguetNote Added: 0047392
2012-04-12 09:42vmromanosRelationship addedrelated to 0020038
2012-04-12 10:00vmromanosNote Added: 0047496
2012-04-12 10:53hgbotCheckin
2012-04-12 10:53hgbotNote Added: 0047503
2012-04-12 10:53hgbotStatusscheduled => resolved
2012-04-12 10:53hgbotResolutionopen => fixed
2012-04-12 10:53hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b4a79546b9e58541ae8798c6d6b91892aa6cb75c [^]
2012-04-12 10:53vmromanosNote Added: 0047504
2012-04-12 10:53vmromanosStatusresolved => closed
2012-04-17 05:31hudsonbotCheckin
2012-04-17 05:31hudsonbotNote Added: 0047632

Notes
(0046436)
chelipf   
2012-03-15 00:35   
(edited on: 2012-04-04 15:50)
The same thing happens for purchase invoice. It is related to 0020038 issue.

(0047392)
Sandrahuguet   
2012-04-04 16:24   
Test Plan:
Go to Sales Invoice
 - Create a new sales invoice
 - Click in Create Lines From

And you can see Excludeforwithholding is 'N'
(0047496)
vmromanos   
2012-04-12 10:00   
Test Plan:
Go to Sales Invoice
 - Create a new sales invoice
 - Click in Create Lines From
 - Select any order previously created
 - Select any line of this order
 - Press OK button
Query the database and verify Excludeforwithholding is 'N'

The field associated with this column is never shown in the application, so there is no reason for changing the API and creating a module script to fix previous data
(0047503)
hgbot   
2012-04-12 10:53   
Repository: erp/devel/pi
Changeset: b4a79546b9e58541ae8798c6d6b91892aa6cb75c
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Apr 04 15:04:25 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b4a79546b9e58541ae8798c6d6b91892aa6cb75c [^]

Fixed issue 20015 Set Excludeforwithholding to N instead to null
Set Excludeforwithholding to N instead to null in c_invoiceline table

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0047504)
vmromanos   
2012-04-12 10:53   
code review + testing OK
(0047632)
hudsonbot   
2012-04-17 05:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cedf57621434 [^]

Maturity status: Test