Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0020003Openbravo ERPB. User interfacepublic2012-03-12 21:592012-09-16 19:55
Reporterdbaz 
Assigned Todbaz 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP12Fixed in Version 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0020003: [SC Upgrade] Workspace widgets are not visible after upgrade to SmartClient 8.3d 2012-03-12 (or later)
DescriptionWorkspace widgets are not visible after upgrade to SmartClient 8.3d 2012-03-12 (or later)

NOTE: Also "canResizeRows" (inside the Portal widget) is deprecated in this new version. Use "canResizePortlets" instead.
Steps To ReproduceWith an instance upgraded to Smartclient 8.3d 2012-03-12 (or later)
Login into the application.
No widgets are shown inside the workspace.
Proposed SolutionInside new SC Portal.js there are conflicts in these lines of the upgraded SC library:

    reflow : function () {
        this.portalLayout.reflow();
        this.Super("reflow", arguments);
    },

isc.PortalRow.addClassMethods({
    applyStretchResizePolicy : function (sizes, totalSize, minSize, modifyInPlace, propertyTarget) {
        if (propertyTarget.portalLayout.preventRowUnderflow) {
          ....
        }
    }
});

    setMinHeight : function (height) {
        if (this.minHeight == height) return;
        this.minHeight = height;
        this.portalColumn.rowLayout.reflow("PortalRow minHeight changed");
    },


Because the generated row (created in "ob-myopenbravo.js") doesn't have portalLayout nor portalColumn variables defined inside it.

Solution: Inside "ob-myopenbravo.js", use "makePortalRow" instead of "createAutoChild" for the generation of the portalRow.
"makePortalRow" performs too the "createAutoChild", but it adds the needed "portalLayout" and "portalColumn" variables

NOTE: Since "canResizeRows" (inside the Portal widget) is deprecated in this new version, all the definitions inside "ob-myopenbravo.js" should be renamed to "canResizePortlets" too

NOTE2: Also the visual appearence (widths, heights, margin,...) should be similar than before apply the upgrade
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-12 21:59dbazNew Issue
2012-03-12 21:59dbazAssigned To => dbaz
2012-03-12 21:59dbazModules => Core
2012-03-12 22:11dbazSummaryWorkspace widgets are not visible after upgrade to SmartClient 8.3d 2012-03-12 => Workspace widgets are not visible after upgrade to SmartClient 8.3d 2012-03-12 (or later)
2012-03-12 22:11dbazDescription Updatedbug_revision_view_page.php?rev_id=3265#r3265
2012-03-12 22:11dbazSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3267#r3267
2012-03-13 01:14dbazProposed Solution updated
2012-03-13 01:46dbazNote Added: 0046299
2012-03-13 01:47dbazNote Edited: 0046299bug_revision_view_page.php?bugnote_id=0046299#r3269
2012-03-15 16:34dbazTypedefect => design defect
2012-03-15 16:34dbazSummaryWorkspace widgets are not visible after upgrade to SmartClient 8.3d 2012-03-12 (or later) => [SC Upgrade] Workspace widgets are not visible after upgrade to SmartClient 8.3d 2012-03-12 (or later)
2012-05-02 21:59hgbotCheckin
2012-05-02 21:59hgbotNote Added: 0048253
2012-05-02 21:59hgbotStatusnew => resolved
2012-05-02 21:59hgbotResolutionopen => fixed
2012-05-02 21:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/62d41ed80d95c9f6e7269730be97e7489139f418 [^]
2012-05-02 21:59hgbotCheckin
2012-05-02 21:59hgbotNote Added: 0048254
2012-05-06 01:58hgbotCheckin
2012-05-06 01:58hgbotNote Added: 0048394
2012-05-21 16:52guilleaerNote Added: 0048814
2012-05-21 16:52guilleaerStatusresolved => closed
2012-05-21 16:52guilleaerFixed in Version => pi
2012-05-25 12:07hudsonbotCheckin
2012-05-25 12:07hudsonbotNote Added: 0048947
2012-05-25 12:07hudsonbotCheckin
2012-05-25 12:07hudsonbotNote Added: 0048948
2012-05-25 12:10hudsonbotCheckin
2012-05-25 12:10hudsonbotNote Added: 0049031
2012-05-25 17:56guilleaerAssigned Todbaz => guilleaer
2012-05-25 17:56guilleaerNote Added: 0049233
2012-05-25 17:56guilleaerStatusclosed => new
2012-05-25 17:56guilleaerResolutionfixed => open
2012-05-25 17:56guilleaerFixed in Versionpi =>
2012-05-25 17:56guilleaerStatusnew => scheduled
2012-05-25 17:56guilleaerNote Added: 0049234
2012-05-25 17:56guilleaerfix_in_branch => pi
2012-05-25 17:56guilleaerNote Added: 0049235
2012-05-25 17:56guilleaerStatusscheduled => resolved
2012-05-25 17:56guilleaerFixed in Version => 3.0MP12
2012-05-25 17:56guilleaerResolutionopen => fixed
2012-05-25 17:57guilleaerNote Added: 0049236
2012-05-25 17:57guilleaerStatusresolved => closed
2012-09-16 19:54guilleaerAssigned Toguilleaer => dbaz
2012-09-16 19:54guilleaerStatusclosed => new
2012-09-16 19:54guilleaerResolutionfixed => open
2012-09-16 19:54guilleaerFixed in Version3.0MP12 =>
2012-09-16 19:54guilleaerStatusnew => scheduled
2012-09-16 19:54guilleaerStatusscheduled => resolved
2012-09-16 19:54guilleaerResolutionopen => fixed
2012-09-16 19:55guilleaerClosed by => guilleaer
2012-09-16 19:55guilleaerStatusresolved => closed

Notes
(0046299)
dbaz   
2012-03-13 01:46   
(edited on: 2012-03-13 01:47)
Resolved, by the moment, in branch pi-rtl

https://code.openbravo.com/erp/devel/pi-rtl/rev/62d41ed80d95 [^]

The code-review can be already done, but the issue closure once pi-rtl be merged with pi (estimated by MP12)
(0048253)
hgbot   
2012-05-02 21:59   
Repository: erp/devel/pi
Changeset: 62d41ed80d95c9f6e7269730be97e7489139f418
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Mar 13 01:18:07 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/62d41ed80d95c9f6e7269730be97e7489139f418 [^]

Fixed issue 20003: 'Workspace' is rendered again after upgrading to SC 8.3

---
M modules/org.openbravo.client.myob/web/org.openbravo.client.myob/js/ob-myopenbravo.js
M modules/org.openbravo.client.myob/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.myob/ob-myopenbravo-styles.js
M modules/org.openbravo.client.myob/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.myob/ob-widget-styles.css
---
(0048254)
hgbot   
2012-05-02 21:59   
Repository: erp/devel/pi
Changeset: d491228cb100bc7e909f6f65026574b8458a3de1
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Mar 13 01:38:35 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d491228cb100bc7e909f6f65026574b8458a3de1 [^]

Related to issue 20003: Reordered 'Workspace' related skin files contents

---
M modules/org.openbravo.client.myob/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.myob/ob-myopenbravo-styles.css
M modules/org.openbravo.client.myob/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.myob/ob-myopenbravo-styles.js
M modules/org.openbravo.client.myob/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.myob/ob-widget-styles.css
M modules/org.openbravo.client.myob/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.myob/ob-widget-styles.js
---
(0048394)
hgbot   
2012-05-06 01:58   
Repository: erp/devel/pi
Changeset: b6da8704106c779f71ebc513af6720efa466b4d6
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Sun May 06 01:57:58 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/b6da8704106c779f71ebc513af6720efa466b4d6 [^]

Related to issue 20003: Improved widget position inside its container

---
M modules/org.openbravo.client.myob/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.myob/ob-widget-styles.css
M modules/org.openbravo.client.myob/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.myob/ob-widget-styles.js
---
(0048814)
guilleaer   
2012-05-21 16:52   
verified in pi@87340d8f38a3
(0048947)
hudsonbot   
2012-05-25 12:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0048948)
hudsonbot   
2012-05-25 12:07   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049031)
hudsonbot   
2012-05-25 12:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test
(0049233)
guilleaer   
2012-05-25 17:56   
Changing Fixed in Version to 3.0MP12
(0049234)
guilleaer   
2012-05-25 17:56   
Changing Fixed in Version to 3.0MP12
(0049235)
guilleaer   
2012-05-25 17:56   
Changing Fixed in Version to 3.0MP12
(0049236)
guilleaer   
2012-05-25 17:57   
Changing Fixed in Version to 3.0MP12