Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019986Openbravo ERPA. Platformpublic2012-03-08 16:242012-04-28 02:31
Reportershuehner 
Assigned Toguilleaer 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP11 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019986: If two modules add same field to a tab compilation fails (even if field is non-visible)
DescriptionDuring the MP8 development cycle the 'Return Material Project' added several fields to some tabs (but non-visible and not really needed).

The module 'Payment Priorities' also added those fields (and started doing so earlier).

Having both MP6 +that module installed the compilation fails as WAD generates invalid code.

For mp6 the field addition in core was reverted but the underlying wad-problem is still present.
Steps To Reproducen/a
Proposed SolutionEither modify wad to not generate invalid code if reasonably possible or if not add least add wad-validation catching this situation so that rebuild can fail providing a useful error message.
Additional Information
TagsNo tags attached.
Relationships
related to defect 00205283.0MP11 closed shuehner A SQL query is not compatible with 8.3 making the upgrade from 2.50 to fail 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-08 16:24shuehnerNew Issue
2012-03-08 16:24shuehnerAssigned To => alostale
2012-03-08 16:24shuehnerModules => Core
2012-03-08 16:25shuehnerNote Added: 0046203
2012-04-18 11:29alostaleAssigned Toalostale => guilleaer
2012-04-24 15:41hgbotCheckin
2012-04-24 15:41hgbotNote Added: 0047917
2012-04-24 15:41hgbotStatusnew => resolved
2012-04-24 15:41hgbotResolutionopen => fixed
2012-04-24 15:41hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/95aa801f9e0343de3f1779ad99dbd5c549e957b9 [^]
2012-04-24 16:01hgbotCheckin
2012-04-24 16:01hgbotNote Added: 0047919
2012-04-24 16:12guilleaerNote Added: 0047921
2012-04-25 17:26alostaleNote Added: 0047967
2012-04-25 17:26alostaleStatusresolved => new
2012-04-25 17:26alostaleResolutionfixed => open
2012-04-26 19:32hudsonbotCheckin
2012-04-26 19:32hudsonbotNote Added: 0048081
2012-04-26 19:32hudsonbotCheckin
2012-04-26 19:32hudsonbotNote Added: 0048082
2012-04-26 21:19hgbotCheckin
2012-04-26 21:19hgbotNote Added: 0048110
2012-04-26 21:19hgbotStatusnew => resolved
2012-04-26 21:19hgbotResolutionopen => fixed
2012-04-26 21:19hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/95aa801f9e0343de3f1779ad99dbd5c549e957b9 [^] => http://code.openbravo.com/erp/devel/pi/rev/1f536d3d1619453f9c6c49ea9e7047430ca42aef [^]
2012-04-27 08:19alostaleNote Added: 0048112
2012-04-27 08:19alostaleStatusresolved => closed
2012-04-27 08:19alostaleFixed in Version => 3.0MP11
2012-04-28 02:31hudsonbotCheckin
2012-04-28 02:31hudsonbotNote Added: 0048170
2012-05-16 17:33plujanRelationship addedrelated to 0020528

Notes
(0046203)
shuehner   
2012-03-08 16:25   
Related issue about api-change which shows the duplicate fields removed from mp6 to point to an example where this is happening.

https://issues.openbravo.com/view.php?id=19346 [^]
(0047917)
hgbot   
2012-04-24 15:41   
Repository: erp/devel/pi
Changeset: 95aa801f9e0343de3f1779ad99dbd5c549e957b9
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Apr 24 14:47:30 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/95aa801f9e0343de3f1779ad99dbd5c549e957b9 [^]

Fixed issue 19986: WAD informs that 2 fields of 1 tab are pointing to the same column.

WAD validation has been added. It check that there arent two fields (or more) of one tab pointing to the same column. If it happens WAD shows a message in the smartbuild log. If smartbuild has been launched using -DstopOnWadError=true the smartbuild will stop if the validation fails.

---
M src-wad/src/org/openbravo/wad/validation/WADValidator.java
M src-wad/src/org/openbravo/wad/validation/WADValidator_data.xsql
---
(0047919)
hgbot   
2012-04-24 16:01   
Repository: erp/devel/pi
Changeset: d1c95750dfa4d13e67807845391c088529709754
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Apr 24 16:01:16 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d1c95750dfa4d13e67807845391c088529709754 [^]

Related to issue 19986: The spanish alias has been changed for an english one

---
M src-wad/src/org/openbravo/wad/validation/WADValidator_data.xsql
---
(0047921)
guilleaer   
2012-04-24 16:12   
Test plan:
1. Logged as system admin
2. Go to windows, tabs and fields
3. Select the product window
4. Select the product tab
5. Add one field to the tab called "testField" which will point to "Description" column
6. run smartbuild -> In "wadvalidation" section of the log, a warning message should appear and after few task it will fail.
7. run smartbuild using -DstopOnWadError=true -> In "wadvalidation" section of the log a warning message should be shown. After that smartbuild fails.

This change is not risky
(0047967)
alostale   
2012-04-25 17:26   
Reopening this issue due the following topics arose during code review:

-This validation doesn't follow the standard way of the rest of them allowing to validate just for a list of given modules.
-It is not giving information about the problematic column, it just points to the tab
-It is using Model Object validation type, but it should use a new one
-Because of concatenating 2 fields in one to later split them by -, in case of tab name contains - this wouldn't work
-Typo "has *to* fields" should be "has *two* fields", but this is not correct at it could be more than 2. So this should be changed to several or to the actual count.
(0048081)
hudsonbot   
2012-04-26 19:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/70a717a9ffa1 [^]

Maturity status: Test
(0048082)
hudsonbot   
2012-04-26 19:32   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/70a717a9ffa1 [^]

Maturity status: Test
(0048110)
hgbot   
2012-04-26 21:19   
Repository: erp/devel/pi
Changeset: 1f536d3d1619453f9c6c49ea9e7047430ca42aef
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Thu Apr 26 19:52:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/1f536d3d1619453f9c6c49ea9e7047430ca42aef [^]

fixed issue 19986: WAD validation to avoid more than one field pointing to the same column in a tab.

---
M src-wad/src/org/openbravo/wad/validation/WADValidationResult.java
M src-wad/src/org/openbravo/wad/validation/WADValidator.java
M src-wad/src/org/openbravo/wad/validation/WADValidator_data.xsql
---
(0048112)
alostale   
2012-04-27 08:19   
Code reviewed and verified on pi@c37b7ed3ba58
(0048170)
hudsonbot   
2012-04-28 02:31   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/cd923b317af4 [^]

Maturity status: Test