Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019967Openbravo ERP07. Sales managementpublic2012-03-06 17:322012-04-02 06:09
Reporterdmiguelez 
Assigned Todmiguelez 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionpiFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019967: Logo does not print on Draft orders
DescriptionWhen a Sales Order is in draft status, printing it to a PDF does not render the logo regardless of the ShowLogo setting.

This happens because the C_Order table has two columns:
1) c_doctype_id
2_ c_doctypetarget_id

and the first one (c_doctype_id) is only filled in after completing an order and the RptC_Invoice.jrxml joins by the first one:

LEFT JOIN C_POC_DOCTYPE_TEMPLATE ON C_POC_DOCTYPE_TEMPLATE.C_DOCTYPE_ID = C_ORDER.C_DOCTYPE_ID,
Steps To Reproduce- Login as Openbravo/openbravo
- Create a new Sales Order and try print it before competing it.
- Notice that the image is not shown.
Proposed Solutionchange the join so that it joins by c_doctypetarget_id


LEFT JOIN C_POC_DOCTYPE_TEMPLATE ON C_POC_DOCTYPE_TEMPLATE.C_DOCTYPE_ID = C_ORDER.C_DOCTYPETARGET_ID,
Additional Information
TagsNo tags attached.
Relationships
related to defect 0016852 closed dmiguelez Logo does not print on Draft invoices 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-03-06 17:32dmiguelezNew Issue
2012-03-06 17:32dmiguelezAssigned To => dmiguelez
2012-03-06 17:32dmiguelezModules => Core
2012-03-06 17:32dmiguelezOBNetwork customer => No
2012-03-06 17:33dmiguelezStatusnew => scheduled
2012-03-06 17:33dmiguelezfix_in_branch => pi
2012-03-06 17:33dmiguelezRelationship addedrelated to 0016852
2012-03-07 18:17dmiguelezNote Added: 0046149
2012-03-12 18:19hgbotCheckin
2012-03-12 18:19hgbotNote Added: 0046291
2012-03-12 18:19hgbotStatusscheduled => resolved
2012-03-12 18:19hgbotResolutionopen => fixed
2012-03-12 18:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a8628d0d3e0040bc6c9b26d98339c9d055cc11e1 [^]
2012-03-14 13:44vmromanosNote Added: 0046400
2012-03-14 13:44vmromanosStatusresolved => closed
2012-04-02 06:09hudsonbotCheckin
2012-04-02 06:09hudsonbotNote Added: 0047100

Notes
(0046149)
dmiguelez   
2012-03-07 18:17   
Test plan:

- Login as F&B International Group Admin.
- Create a new Sales Order with at least one Line.
- Print it without completing it. Notice that the Company Logo appears.
(0046291)
hgbot   
2012-03-12 18:19   
Repository: erp/devel/pi
Changeset: a8628d0d3e0040bc6c9b26d98339c9d055cc11e1
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Wed Mar 07 18:31:46 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a8628d0d3e0040bc6c9b26d98339c9d055cc11e1 [^]

Fixes issue 0019967: Changed join sentece in query.

---
M src/org/openbravo/erpReports/C_OrderJR.jrxml
M src/org/openbravo/erpReports/RptC_OrderPO.jrxml
---
(0046400)
vmromanos   
2012-03-14 13:44   
code review + testing OK
(0047100)
hudsonbot   
2012-04-02 06:09   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test