Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0019960Openbravo ERPA. Platformpublic2012-03-06 15:462022-02-01 08:08
mtaal 
Triage Platform Base 
normalmajorhave not tried
acknowledgedopen 
5
 
 
Core
No
0019960: Clean up asynchronous behavior in the application
The application has several places where we do asynchronous calls, the usage of asynchronous calls results in more unpredictable behavior of the application.

We should get rid of asynchronous behavior as much as possible, but in some cases it makes sense, see the attached presentation.

Some delays are done to execute an action after a redraw is done, so while redrawing the action should wait, for example in ob-view-form.js there is this:
    if (this.isDirty()) {
      this.delayCall('focusInNextItem', [currentItemName], 100);
      return;
    }
this should be done differently, if the form is dirty then the focusInNextItem should set a variable, which can be used after the redraw to do the focusinnextitem.

The attached presentation talks about this and other cases.

To find all cases search the js source code for:
delaycall
fireonpause
.IDLE

Also search the js code of the smartclient and the selector modules.

Some delays are used to handle selecting of values correctly after changing the focus. To test focus make sure to test the following cases:
- Tax Rate window, form view, change Base Amount to have a value with "+ Tax Amount" the focus should move to a new field
- Test sales order line, change product, pick a value using the mouse, using the tab key, test in firefox on windows also
.
No tags attached.
? async_javascript.odp (15,752) 2012-03-06 15:46
https://issues.openbravo.com/file_download.php?file_id=5058&type=bug
Issue History
2012-03-06 15:46mtaalNew Issue
2012-03-06 15:46mtaalAssigned To => alostale
2012-03-06 15:46mtaalFile Added: async_javascript.odp
2012-03-06 15:46mtaalModules => Core
2012-05-28 14:18alostaleTarget Version3.0MP12 =>
2012-09-24 20:48AugustoMauchNote Added: 0052387
2012-09-24 20:48AugustoMauchStatusnew => scheduled
2017-03-31 14:36alostaleStatusscheduled => acknowledged
2017-04-10 14:33alostaleAssigned Toalostale => platform
2022-02-01 08:08alostaleAssigned Toplatform => Triage Platform Base

Notes
(0052387)
AugustoMauch   
2012-09-24 20:48   
Impact: low
Plan: mid