Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019895Openbravo ERPI. Performancepublic2012-02-28 00:422012-04-01 20:39
Reporterfleroux 
Assigned Toalostale 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS Version
Product Version3.0MP8 
Target VersionFixed in Version3.0MP10 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome, Mozilla Firefox
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019895: CPU spike during invoice header click
DescriptionWhen opening the invoice tab in grid mode I navigate to click a record in the grid which then results in CPU utilization spikes of 10-30%. The result of this in a concurrent scenario would be that multiples of 5-10 users will exhaust the CPU.
Steps To ReproduceSee above
Proposed SolutionLooked at the FIC component and currently focusing on the computevalues area which appears to cause the CPU overhead
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0019896 acknowledged Triage Platform Base CPU spike during logging in process 
related to defect 00201023.0MP10 closed alostale The usage audit can not be disable 
related to defect 0020124 closed alostale Usage audit is not working for fetch actions 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-02-28 00:42flerouxNew Issue
2012-02-28 00:42flerouxAssigned To => shuehner
2012-02-28 00:42flerouxWeb browser => Google Chrome, Mozilla Firefox
2012-02-28 00:42flerouxModules => Core
2012-02-28 08:16iperdomoAssigned Toshuehner => agaldos
2012-02-28 08:32alostaleAssigned Toagaldos => alostale
2012-02-28 08:32alostaleWeb browserGoogle Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2012-02-28 08:32alostaleTypedefect => design defect
2012-02-28 08:32alostaleRelationship addedrelated to 0019896
2012-03-09 16:16hgbotCheckin
2012-03-09 16:16hgbotNote Added: 0046237
2012-03-09 16:16hgbotStatusnew => resolved
2012-03-09 16:16hgbotResolutionopen => fixed
2012-03-09 16:16hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f1158e744da895f9f41179cd70b48ed8152544b5 [^]
2012-03-26 15:13alostaleRelationship addedrelated to 0020102
2012-03-27 13:44alostaleRelationship addedrelated to 0020124
2012-03-28 13:03alostaleNote Added: 0046822
2012-03-28 13:03alostaleStatusresolved => closed
2012-03-28 13:03alostaleFixed in Version => 3.0MP10
2012-04-01 20:39hudsonbotCheckin
2012-04-01 20:39hudsonbotNote Added: 0047079

Notes
(0046237)
hgbot   
2012-03-09 16:16   
Repository: erp/devel/pi
Changeset: f1158e744da895f9f41179cd70b48ed8152544b5
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Mar 09 16:15:21 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f1158e744da895f9f41179cd70b48ed8152544b5 [^]

Fixed issue 19895. Done several changes to improve the performance of the FIC and reduce the server load (specially when the user selects a record in grid):
- Cached the whole Tab instance in the FIC (not only its related objects (fields, auxiliary inputs, ...)) to avoid an additional (and expensive) query
- Removed the OBCriteria for the attachments and notes. They've been replaced by an OBQuery and a HQL Query to reduce computation time.
- Replaced the UsageAudit call in each DataSourceServlet request by the non-dal version (which greatly reduces the computation cost)
- Added a constructor in the DynamicExpressionParser class so that an instance of ApplicationDictionaryCachedStructures can be passed if it is available. This avoids having to do an expensive call to Weld when the FIC uses the DynamicExpressionParser.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/ApplicationDictionaryCachedStructures.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/DataSourceServlet.java
---
(0046822)
alostale   
2012-03-28 13:03   
Executed test:
-Attachments still work and are properly displayed
-Notes still work and are properly displayed
(0047079)
hudsonbot   
2012-04-01 20:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/640de9acc2d5 [^]

Maturity status: Test