Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0019872 | Openbravo ERP | A. Platform | public | 2012-02-24 16:08 | 2012-03-02 15:39 |
|
| Reporter | rgoris | |
| Assigned To | guilleaer | |
| Priority | immediate | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0MP9 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0019872: Strange date value in date picker |
| Description | See screenshot, there are values with a % in them:
%0 days ago
%0 weeks ago
%0 months ago
etc.
THis must be N days ago, etc, right? |
| Steps To Reproduce | Pick a date from the column filter selector in a grid |
| Proposed Solution | |
| Additional Information | |
| Tags | Regression QA |
| Relationships | | related to | defect | 0019586 | 3.0MP10 | closed | guilleaer | Attachment message fails when translation installed. |
|
| Attached Files |  percentage-days.png (45,301) 2012-02-24 16:08
https://issues.openbravo.com/file_download.php?file_id=5025&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-02-24 16:08 | rgoris | New Issue | |
| 2012-02-24 16:08 | rgoris | Assigned To | => alostale |
| 2012-02-24 16:08 | rgoris | File Added: percentage-days.png | |
| 2012-02-24 16:08 | rgoris | Modules | => Core |
| 2012-02-28 10:57 | alostale | Tag Attached: Regression QA | |
| 2012-02-28 10:58 | alostale | Relationship added | related to 0019586 |
| 2012-02-28 10:59 | alostale | Note Added: 0045518 | |
| 2012-02-28 11:00 | alostale | Status | new => scheduled |
| 2012-02-28 11:00 | alostale | Assigned To | alostale => guilleaer |
| 2012-02-28 11:00 | alostale | fix_in_branch | => pi |
| 2012-02-28 11:00 | alostale | Priority | normal => immediate |
| 2012-02-28 11:00 | alostale | fix_in_branch | pi => |
| 2012-02-28 13:29 | hgbot | Checkin | |
| 2012-02-28 13:29 | hgbot | Note Added: 0045533 | |
| 2012-02-28 13:29 | hgbot | Status | scheduled => resolved |
| 2012-02-28 13:29 | hgbot | Resolution | open => fixed |
| 2012-02-28 13:29 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/5e2e3880c5ef80f1a4d4317187c44da8bca6dc2e [^] |
| 2012-02-28 13:45 | guilleaer | Note Added: 0045535 | |
| 2012-02-28 17:45 | hgbot | Checkin | |
| 2012-02-28 17:45 | hgbot | Note Added: 0045557 | |
| 2012-02-29 08:25 | alostale | Note Added: 0045564 | |
| 2012-02-29 08:25 | alostale | Status | resolved => closed |
| 2012-02-29 08:25 | alostale | Fixed in Version | => 3.0MP9 |
| 2012-03-02 15:39 | hudsonbot | Checkin | |
| 2012-03-02 15:39 | hudsonbot | Note Added: 0045971 | |
|
Notes |
|
|
|
Error introduced when fixing issue 0019586.
The messages were correctly changed for what it was reported, but didn't realize they were correct for ranges.
Check usage in ob-formitem-minidaterange.js.
ack OBUIAPP_.*_ago modules/ --js
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
880: return OB.Utilities.formatTimePassedMessage(n, 'OBUIAPP_months_ago');
883: return OB.Utilities.formatTimePassedMessage(n, 'OBUIAPP_weeks_ago');
886: return OB.Utilities.formatTimePassedMessage(n, 'OBUIAPP_days_ago');
893: return OB.Utilities.formatTimePassedMessage(n, 'OBUIAPP_hours_ago');
898: return OB.Utilities.formatTimePassedMessage(n, 'OBUIAPP_minutes_ago');
modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-minidaterange.js
25: millisecondsAgoTitle: OB.I18N.getLabel('OBUIAPP_milliseconds_ago'),
26: secondsAgoTitle: OB.I18N.getLabel('OBUIAPP_seconds_ago'),
27: minutesAgoTitle: OB.I18N.getLabel('OBUIAPP_minutes_ago'),
28: hoursAgoTitle: OB.I18N.getLabel('OBUIAPP_hours_ago'),
29: daysAgoTitle: OB.I18N.getLabel('OBUIAPP_days_ago'),
30: weeksAgoTitle: OB.I18N.getLabel('OBUIAPP_weeks_ago'),
31: monthsAgoTitle: OB.I18N.getLabel('OBUIAPP_months_ago'),
32: quartersAgoTitle: OB.I18N.getLabel('OBUIAPP_quarters_ago'),
33: yearsAgoTitle: OB.I18N.getLabel('OBUIAPP_years_ago'), |
|
|
|
(0045533)
|
|
hgbot
|
|
2012-02-28 13:29
|
|
Repository: erp/devel/pi
Changeset: 5e2e3880c5ef80f1a4d4317187c44da8bca6dc2e
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Feb 28 13:26:38 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5e2e3880c5ef80f1a4d4317187c44da8bca6dc2e [^]
Fixed issue 19872: 'Ago' messages has been changed to be shown correctly in date picker.
New messages has been created to be shown in the attachments forms
---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
---
|
|
|
|
|
Test plan:
messages in the date picker (19872)
1. Go to the Goods Shipments
2. Using the date picker you can see that the messages works fine
messages in attachments form (19586)
1. Add an attachment to the good shipment
2. The message is shown correctly
No risk of regression detected. |
|
|
|
(0045557)
|
|
hgbot
|
|
2012-02-28 17:45
|
|
|
|
|
|
|
Code reviewed and tested on pi@3afb79bd3730 |
|
|
|
|
|