Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019847Openbravo ERPZ. Otherspublic2012-02-23 09:552012-04-02 06:10
ReporterioritzCia 
Assigned Tojecharri 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 10.04
Product Version 
Target Version3.0MP10Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019847: Copy lines from invoice does not mantain the order in the lines of the original invoice.
DescriptionCopy lines from invoice does not mantain the order in the lines of the original invoice.
Steps To Reproduce- Go to Sales Management >> Transactions >> Sales Invoice.
- Create an invoice, preferably with many lines.
- Complete it.
- Create another invoice with 'Copy Lines' process from the previous invoice.
- As there is no order by clause it can reorder the lines in other way from the original or not.
- If another invoice is created in the same way just after the second. The lines will be created in the same order as in the second.
- If another invoice is created in the same way some time after that having changed the database status, the lines will be ordered in other way.
- This is wrong, the copied lines should be created in the same order as in the original invoice. They should be ordered by the seqno.
Proposed SolutionOrder the lines by the seqno. The should be ordered by the seqno, but they should not be assigned the same seqno because you can use copy lines after havving added one or you can execute copy lines from more than one invoice.

Check if the other 'copy from' processes work the same way.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-02-23 09:55ioritzCiaNew Issue
2012-02-23 09:55ioritzCiaAssigned To => vmromanos
2012-02-23 09:55ioritzCiaModules => Core
2012-02-23 10:01ioritzCiaResolution time => 1335909600
2012-02-23 10:01ioritzCiaAssigned Tovmromanos => jonalegriaesarte
2012-02-23 10:01ioritzCiaTarget Version => 3.0MP10
2012-02-23 13:14ioritzCiaIssue Monitored: networkb
2012-03-15 18:40jonalegriaesarteAssigned Tojonalegriaesarte => jecharri
2012-03-16 09:01hgbotCheckin
2012-03-16 09:01hgbotNote Added: 0046486
2012-03-16 09:01hgbotStatusnew => resolved
2012-03-16 09:01hgbotResolutionopen => fixed
2012-03-16 09:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/495a9a24987c3b00a86cd84a00bde5524eb3c1bc [^]
2012-03-16 09:03jecharriNote Added: 0046488
2012-03-28 10:36ioritzCiaNote Added: 0046807
2012-03-28 10:36ioritzCiaStatusresolved => closed
2012-04-02 06:10hudsonbotCheckin
2012-04-02 06:10hudsonbotNote Added: 0047154

Notes
(0046486)
hgbot   
2012-03-16 09:01   
Repository: erp/devel/pi
Changeset: 495a9a24987c3b00a86cd84a00bde5524eb3c1bc
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Fri Mar 16 09:00:45 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/495a9a24987c3b00a86cd84a00bde5524eb3c1bc [^]

Fixes issue 19847: Copy lines from invoice does not mantain the order in the lines of the original invoice.

---
M src/org/openbravo/erpCommon/ad_actionButton/CopyFromInvoice_data.xsql
---
(0046488)
jecharri   
2012-03-16 09:03   
Test cases:
-wtih steps to reproduce is enough

I have tested the copy from in orders and also, I have verified that the "copy lines from" is working like it is expected but it will be great to another review before close the issue
(0046807)
ioritzCia   
2012-03-28 10:36   
Verified
(0047154)
hudsonbot   
2012-04-02 06:10   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test