Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0019839 | Openbravo ERP | A. Platform | public | 2012-02-22 12:29 | 2012-03-02 15:39 |
|
| Reporter | alostale | |
| Assigned To | AugustoMauch | |
| Priority | urgent | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | pi | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0019839: Incorrect alert filter prevents login |
| Description | An incorrect filter in an Alert Rule can cause the system to not allow to log in.
In this situation after entering user/password and error message is shown and loading screen is kept. |
| Steps To Reproduce | -Select an Alert Rule with alert instances
-Change its filter clause to any sensless string
-Log in the application with a role which is part of this alert's assignees -> Error popup appears and loading screen doesn't disappear. |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  Selection_033.png (12,870) 2012-02-22 12:30
https://issues.openbravo.com/file_download.php?file_id=5017&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-02-22 12:29 | alostale | New Issue | |
| 2012-02-22 12:29 | alostale | Assigned To | => alostale |
| 2012-02-22 12:29 | alostale | Modules | => Core |
| 2012-02-22 12:30 | alostale | File Added: Selection_033.png | |
| 2012-02-22 12:30 | alostale | Assigned To | alostale => AugustoMauch |
| 2012-02-22 12:36 | shuehner | Issue Monitored: shuehner | |
| 2012-02-22 19:03 | AugustoMauch | Note Added: 0045387 | |
| 2012-02-22 19:04 | AugustoMauch | Note Added: 0045388 | |
| 2012-02-22 19:14 | hgbot | Checkin | |
| 2012-02-22 19:14 | hgbot | Note Added: 0045389 | |
| 2012-02-22 19:14 | hgbot | Status | new => resolved |
| 2012-02-22 19:14 | hgbot | Resolution | open => fixed |
| 2012-02-22 19:14 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/d6522f4e28aea055ea2bf508f91e2667832a1f89 [^] |
| 2012-02-23 17:53 | hgbot | Checkin | |
| 2012-02-23 17:53 | hgbot | Note Added: 0045420 | |
| 2012-02-23 20:17 | guilleaer | Note Added: 0045426 | |
| 2012-02-23 20:17 | guilleaer | Status | resolved => closed |
| 2012-02-23 20:17 | guilleaer | Fixed in Version | => pi |
| 2012-03-02 15:38 | hudsonbot | Checkin | |
| 2012-03-02 15:38 | hudsonbot | Note Added: 0045930 | |
| 2012-03-02 15:39 | hudsonbot | Checkin | |
| 2012-03-02 15:39 | hudsonbot | Note Added: 0045946 | |
|
Notes |
|
|
|
When an alert rule with an invalid filter was processed, the exception that was thrown was not being caught.
The fix has consisted in adding a try/catch block to capture this exception, adding a message to the login when that happens. |
|
|
|
|
Test plan:
- Follow the steps described in the steps to reproduce section.
- The login process should complete successfully, and and error should be displayed in the log.
This fix is not risky. |
|
|
|
(0045389)
|
|
hgbot
|
|
2012-02-22 19:14
|
|
Repository: erp/devel/pi
Changeset: d6522f4e28aea055ea2bf508f91e2667832a1f89
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Feb 22 19:12:30 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d6522f4e28aea055ea2bf508f91e2667832a1f89 [^]
Fixes issue 19839: The Exception is now being caught
---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertActionHandler.java
---
|
|
|
|
(0045420)
|
|
hgbot
|
|
2012-02-23 17:53
|
|
Repository: erp/devel/pi
Changeset: 4940d1f96b76a27cce4a075ded01099d9e6b3a51
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Thu Feb 23 17:49:31 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4940d1f96b76a27cce4a075ded01099d9e6b3a51 [^]
Related to issue 19839: Adds exception handling in the Alert window
---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertManagementActionHandler.java
---
|
|
|
|
|
|
code review and tested on pi@4940d1f96b76 |
|
|
|
|
|
|
|
|
|