Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0019807 | Openbravo ERP | B. User interface | public | 2012-02-18 01:31 | 2012-03-02 15:38 |
|
| Reporter | dbaz | |
| Assigned To | dbaz | |
| Priority | high | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 3.0MP9 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | No |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0019807: [P&E] Delete Icon has not "hover" styles |
| Description | Delete Icon has not "hover" styles, so when you mouseover/press it you have not visual notification |
| Steps To Reproduce | As "Openbravo Admin"
* Go to "Payment Term"
* Create New
- "Search Key": 30-60-90
- "Name": 30-60-90
* Save
* Go to "Lines"
* Create New
- "Percentage Due": 25
- "Rest": un-checked
* Save
* Create New
- "Percentage Due": 25
- "Rest": un-checked
* Save
* Go to "Sales Invoice"
* Create New
- "Organization": same organization you used in the created "Payment Term"
- "Business Partner": any
- "Payment Term": 30-60-90
* Save
* Go to "Lines"
* Create 2 news with any product and Quantity 100
* "Complete" the "Sales Invoice"
* Click "Modify Payment In Plan"
Check that the delete icon (rubbish bin) has not any visual at all |
| Proposed Solution | There are two solutions:
* Fast one: add changes in the icon and a cursor:pointer to the <img> itself. Cons: since all the cell is clickable, it should be strange, that if you click outside the <img> but still inside the cell, the action is performed. This is because the delete column is made using Smartclient standard way
* Elaborated one: remove Smartclient's delete column code, and include a button using "createRecordComponent" which permorms the deletion action. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  ob-pick-and-execute-view.js (10,508) 2012-02-18 01:36
https://issues.openbravo.com/file_download.php?file_id=5005&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2012-02-18 01:31 | dbaz | New Issue | |
| 2012-02-18 01:31 | dbaz | Assigned To | => dbaz |
| 2012-02-18 01:31 | dbaz | Modules | => Core |
| 2012-02-18 01:31 | dbaz | OBNetwork customer | => No |
| 2012-02-18 01:32 | dbaz | Proposed Solution updated | |
| 2012-02-18 01:35 | dbaz | Note Added: 0045250 | |
| 2012-02-18 01:36 | dbaz | File Added: ob-pick-and-execute-view.js | |
| 2012-02-18 01:38 | hgbot | Checkin | |
| 2012-02-18 01:38 | hgbot | Note Added: 0045251 | |
| 2012-02-18 01:38 | hgbot | Status | new => resolved |
| 2012-02-18 01:38 | hgbot | Resolution | open => fixed |
| 2012-02-18 01:38 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/c5f71c8919355f5610a1464d9b7f2883bc365778 [^] |
| 2012-02-20 11:01 | AugustoMauch | Note Added: 0045261 | |
| 2012-02-20 11:01 | AugustoMauch | Status | resolved => closed |
| 2012-02-20 11:01 | AugustoMauch | Fixed in Version | => 3.0MP9 |
| 2012-03-02 15:38 | hudsonbot | Checkin | |
| 2012-03-02 15:38 | hudsonbot | Note Added: 0045888 | |
|
Notes |
|
|
(0045250)
|
|
dbaz
|
|
2012-02-18 01:35
|
|
Attached a diff for the "Elaborated" solution. But it doesn't work when adding more rows. Since the way to fix it is not trivial and it seems that it would require Smartclient support, and since the issue impact with "Fast" solution is not so big, the "Fast" solution is finally implemented.
If the issue returns, the "Elaborated" solution will be retried. |
|
|
|
(0045251)
|
|
hgbot
|
|
2012-02-18 01:38
|
|
Repository: erp/devel/pi
Changeset: c5f71c8919355f5610a1464d9b7f2883bc365778
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Sat Feb 18 01:37:35 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/c5f71c8919355f5610a1464d9b7f2883bc365778 [^]
Fixed issue 19807: [P&E] added mouse effects to 'Delete' button
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
M modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/process/iconDelete.png
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/process/iconDelete_Down.png
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/process/iconDelete_Over.png
---
|
|
|
|
|
|
Code reviewed and verified on live builds, revision #5e8637a2a10b65ccaa75b357399c0463d025703e |
|
|
|
|
|