Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019789Openbravo ERPZ. Otherspublic2012-02-16 12:392016-02-02 09:41
Reportermaite 
Assigned Tovmromanos 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customerOBPS
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket14330
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019789: It would be nice to have "select/unselect all" check box when running Matching Statement process
DescriptionIt would be nice to have ""select/unselect all" check box when running Matching Statement process
Steps To Reproduce1. Go to Financial Account and press "Match Statement" button
2. Realize that there is no option ""select/unselect all"
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-02-16 12:39maiteNew Issue
2012-02-16 12:39maiteAssigned To => vmromanos
2012-02-16 12:39maiteModules => Advanced Payables and Receivables Mngmt
2012-02-16 12:39maiteOBNetwork customer => Yes
2012-02-16 12:39maiteSupport ticket => 14330
2012-03-02 17:31eduardo_ArgalAssigned Tovmromanos => jonalegriaesarte
2013-04-29 15:52ngarciaIssue Monitored: ngarcia
2015-08-07 13:40VictorVillarTriggers an Emergency Pack => No
2015-08-07 13:40VictorVillarSummaryIt would be nice to have "select all" check box when running Matching Statement process => It would be nice to have "select/unselect all" check box when running Matching Statement process
2015-08-07 13:40VictorVillarDescription Updatedbug_revision_view_page.php?rev_id=9180#r9180
2015-08-07 13:40VictorVillarSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=9182#r9182
2015-11-23 11:00vmromanosStatusnew => scheduled
2015-11-23 11:00vmromanosAssigned Tojonalegriaesarte => vmromanos
2015-11-23 11:10vmromanosNote Added: 0082061
2015-11-23 11:29hgbotCheckin
2015-11-23 11:29hgbotNote Added: 0082062
2015-11-23 11:29hgbotStatusscheduled => resolved
2015-11-23 11:29hgbotResolutionopen => fixed
2015-11-23 11:29hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/28b97db8b67111b43adb3472d4e2fd7894416fb8 [^]
2015-11-23 11:29hgbotCheckin
2015-11-23 11:29hgbotNote Added: 0082063
2015-11-23 11:47vmromanosReview Assigned To => vmromanos
2015-11-23 11:47vmromanosNote Added: 0082066
2015-11-23 11:47vmromanosStatusresolved => closed
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082263
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082264
2015-11-26 11:31vmromanosNote Added: 0082364
2015-11-26 11:35vmromanosNote Added: 0082365
2016-02-02 09:41hgbotCheckin
2016-02-02 09:41hgbotNote Added: 0083828

Notes
(0082061)
vmromanos   
2015-11-23 11:10   
Test plan:

Go to Financial Account Window.
Select Cuenta de banco
Go to Imported Bank Statements tab
Enter a new record. Save it.
Go to Bank Statement lines.
Create 3 records for any amount. Process the document
Press Match Statement button. Do not run automatic process.
Verify no lines are selected.
Verify Unmatch Selected button is not shown.
Select any record (not cleared yet)
Verify Unmatch Selected button is not shown.
Unselect all records.
Verify Unmatch Selected button is not shown.
Press + button of any record, select any gl item and save it.
Verify the record has been cleared (remove the filter to see it again).
Press the unmatch button at record level.
Verify the record is properly unmatched.
Press + button of any record, select any gl item and save it.
Verify the record has been cleared (remove the filter to see it again).
Press + button of any record, select any gl item and save it.
Verify the record has been cleared (remove the filter to see it again).
Right now you have 2 records cleared and another one empty.
Select the record not cleared yet.
Verify Unmatch Selected button is not shown.
Select any record already cleared.
Verify Unmatch Selected button is shown.
Select all the records.
Verify Unmatch Selected button is shown.
Unselect all the records.
Verify Unmatch Selected button is not shown.
Select all the records again.
Press the Unmatch Selected button.
Verify the process finish successfully.
Verify a success message is shown informing 2 records where unmatched.
Press the magnifying button of any record previously matched and select a transaction previously created.
Verify the record is cleared.
Select this record again.
Press the Unmatch selected button.
Verify the record is properly unmatched.
(0082062)
hgbot   
2015-11-23 11:29   
Repository: erp/devel/pi
Changeset: 28b97db8b67111b43adb3472d4e2fd7894416fb8
Author: Nicola Cuomo <nikola.cuomo <at> cleardrop.biz>
Date: Wed Sep 02 10:19:42 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/28b97db8b67111b43adb3472d4e2fd7894416fb8 [^]

Fixed issue 19789: Unmatch several lines in a batch

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_REF_LIST.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/UnMatchSelectedTransactionsActionHandler.java
---
(0082063)
hgbot   
2015-11-23 11:29   
Repository: erp/devel/pi
Changeset: 01b4fb16de7ba23cd560536613c510aae74e8b27
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Mon Nov 23 11:18:00 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/01b4fb16de7ba23cd560536613c510aae74e8b27 [^]

Related to issue 19789: Code review improvements

Unmatch Selected button is only shown when the user has selected at least 1 record already cleared.
The display logic for the Unmatch Selected button is run after manually matching a transaction with the search or add transaction, and when manually unmatching an individual transaction
Improved Unmatch Selected error/warning/sucess messages.
Translated the message title.
ob-aprm-findTransaction.js modified to avoid a regression after manually match a record using the search button.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/UnMatchSelectedTransactionsActionHandler.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-findTransaction.js
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
---
(0082066)
vmromanos   
2015-11-23 11:47   
Contribution: code review + testing OK
(0082263)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082264)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082364)
vmromanos   
2015-11-26 11:31   
https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-9959 [^]
(0082365)
vmromanos   
2015-11-26 11:35   
Automatic test:
https://code.openbravo.com/tools/automation/pi-functional/rev/74423d258cc7 [^]
(0083828)
hgbot   
2016-02-02 09:41   
Repository: tools/automation/int
Changeset: a45f0e27fdfe746c651304dc5ebbccf870942b81
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Nov 26 11:33:58 2015 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/a45f0e27fdfe746c651304dc5ebbccf870942b81 [^]

Related to issue 19789: Added automatic test

https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-9959 [^]

---
M src-test/com/openbravo/test/integration/erp/gui/financial/receivablespayables/transactions/MatchStatementProcess.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_ReconciliationRefactor/ReconciliationSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_ReconciliationRefactor/build.xml
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_ReconciliationRefactor/APRUnmatchSelected001.java
---