Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019779Openbravo ERPB. User interfacepublic2012-02-15 16:552012-03-02 15:38
Reporterdbaz 
Assigned Todbaz 
PriorityhighSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019779: [PNE] Clicking twice fastly the "Pick and Execute" button process can open the window with two grids
DescriptionClicking twice fastly the "Pick and Execute" button process can open the window with two grids
Steps To ReproduceAs "Openbravo Admin":
* Go to "Return from Customer"
* Create new (and save)
* Double-Click (or triple-click) "Pick/Edit Lines".

Sometimes the opened view has two "popup" inside it instead one. In this case a vertical screen is shown and you can scroll down to see it.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027621 closed AugustoMauch If you get a network interruption when clicking on the edit item button , then the button does not work anymore 
Attached Filesdiff 19779.diff (1,249) 2012-02-21 12:37
https://issues.openbravo.com/file_download.php?file_id=5014&type=bug
Issue History
Date ModifiedUsernameFieldChange
2012-02-15 16:55dbazNew Issue
2012-02-15 16:55dbazAssigned To => dbaz
2012-02-15 16:55dbazModules => Core
2012-02-15 16:55dbazOBNetwork customer => No
2012-02-15 16:59hgbotCheckin
2012-02-15 16:59hgbotNote Added: 0045155
2012-02-15 16:59hgbotStatusnew => resolved
2012-02-15 16:59hgbotResolutionopen => fixed
2012-02-15 16:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f2585e9deaf598718190a8b3ad40b23df10d655c [^]
2012-02-21 12:37iperdomoNote Added: 0045302
2012-02-21 12:37iperdomoStatusresolved => new
2012-02-21 12:37iperdomoResolutionfixed => open
2012-02-21 12:37iperdomoFile Added: 19779.diff
2012-02-21 13:14hgbotCheckin
2012-02-21 13:14hgbotNote Added: 0045307
2012-02-21 13:14hgbotStatusnew => resolved
2012-02-21 13:14hgbotResolutionopen => fixed
2012-02-21 13:14hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f2585e9deaf598718190a8b3ad40b23df10d655c [^] => http://code.openbravo.com/erp/devel/pi/rev/74e03242ccdc41c3eb242fb05d7f63969f433e8d [^]
2012-02-21 13:53iperdomoNote Added: 0045308
2012-02-21 13:53iperdomoStatusresolved => closed
2012-03-02 15:37hudsonbotCheckin
2012-03-02 15:37hudsonbotNote Added: 0045858
2012-03-02 15:38hudsonbotCheckin
2012-03-02 15:38hudsonbotNote Added: 0045910
2014-09-19 12:57AugustoMauchRelationship addedrelated to 0027621

Notes
(0045155)
hgbot   
2012-02-15 16:59   
Repository: erp/devel/pi
Changeset: f2585e9deaf598718190a8b3ad40b23df10d655c
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Feb 15 16:58:28 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f2585e9deaf598718190a8b3ad40b23df10d655c [^]

Fixed issue 19779: 'Double-click' is not possible anymore in new process buttons

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
---
(0045302)
iperdomo   
2012-02-21 12:37   
Testing on pi @ rev 8e3bca6e8153

Disabling the button gives a strange feeling since none of the other buttons do that. You can click as many times you want, but you only have 1 modal dialog.

I propose that instead of disabling, just append a flag to the button, opening = true after the first call and reset the flag on the callback function. This produces the same behavior than the other buttons.

Attached a sample diff
(0045307)
hgbot   
2012-02-21 13:14   
Repository: erp/devel/pi
Changeset: 74e03242ccdc41c3eb242fb05d7f63969f433e8d
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Feb 21 13:14:31 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/74e03242ccdc41c3eb242fb05d7f63969f433e8d [^]

Fixed issue 19779: 'Double-click' is not possible anymore in new process buttons

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-action-button.js
---
(0045308)
iperdomo   
2012-02-21 13:53   
Code review, tested on pi @ rev 74e03242ccdc
(0045858)
hudsonbot   
2012-03-02 15:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045910)
hudsonbot   
2012-03-02 15:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test