Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0019768Openbravo ERP01. General setuppublic2012-02-14 18:432012-03-02 15:38
psarobe 
eduardo_Argal 
immediatemajoralways
closedfixed 
5
pi 
pi 
Core
No
0019768: When you apply a module through the Initial Org Setup window it inserts datasets without the checksum value
When you apply a module through the Initial Org Setup window, the system inserts record/s into the AD_ORGMODULE window but without the corresponding checksum

At the same time if the module has three dataset it is inserting three lines in the AD_ORGMODULE window and this is WRONG

It must insert just one line and link together the corresponding checksums

This is the way it does the Enterprise Module management window
1. Go to initial client setup
2. Fill the mandatory fields and do not select the Advance&Payables module
3. Execute the process
4. Login with the new user
5. Go to Initial Org Setup and select the Advance&Payables module
6. Execute the process

Now you must do a query to the database for that newly client. This query must be done on table AD_ORGMODULE for Advance&Payables module

You will notice 2 things:
1. You have three records instead of one
2. The column checksum is null and it should the corresponding checksum
As it happens in Enterprise module management you should have just one records and for the checksum column the system must link together the corresponding values
No tags attached.
Issue History
2012-02-14 18:43psarobeNew Issue
2012-02-14 18:43psarobeAssigned To => eduardo_Argal
2012-02-14 18:43psarobeModules => Core
2012-02-15 20:33eduardo_ArgalStatusnew => scheduled
2012-02-15 20:33eduardo_Argalfix_in_branch => pi
2012-02-16 10:06hgbotCheckin
2012-02-16 10:06hgbotNote Added: 0045171
2012-02-16 10:06hgbotStatusscheduled => resolved
2012-02-16 10:06hgbotResolutionopen => fixed
2012-02-16 10:06hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4561e31e98e32654fe06e4d4684958088b24a7ea [^]
2012-02-17 08:38psarobeNote Added: 0045207
2012-02-17 08:38psarobeStatusresolved => closed
2012-02-17 08:38psarobeFixed in Version => pi
2012-02-17 18:13hgbotCheckin
2012-02-17 18:13hgbotNote Added: 0045246
2012-02-17 19:57dalsasuaNote Added: 0045248
2012-02-17 21:00dalsasuaNote Added: 0045249
2012-03-02 15:37hudsonbotCheckin
2012-03-02 15:37hudsonbotNote Added: 0045864
2012-03-02 15:38hudsonbotCheckin
2012-03-02 15:38hudsonbotNote Added: 0045886

Notes
(0045171)
hgbot   
2012-02-16 10:06   
Repository: erp/devel/pi
Changeset: 4561e31e98e32654fe06e4d4684958088b24a7ea
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Wed Feb 15 20:33:15 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4561e31e98e32654fe06e4d4684958088b24a7ea [^]

Fixes bug 19767, Fixes bug 19768

---
M src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
---
(0045207)
psarobe   
2012-02-17 08:38   
Fixed. Works fine

Test:

1. Go to initial client setup
2. Fill the mandatory fields and do not select the Advance&Payables module
3. Execute the process
4. Login with the new user
5. Go to Initial Org Setup and select the Advance&Payables module
6. Execute the process
7. Do a query in AD_ORGMODULE.
8. Just one record and have linked together the three checksum separate by comma

CORRECT
(0045246)
hgbot   
2012-02-17 18:13   
Repository: erp/devel/pi
Changeset: ff8f49282d8a617d52ba0ba39dfba4d68ae4e96d
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Fri Feb 17 18:12:51 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ff8f49282d8a617d52ba0ba39dfba4d68ae4e96d [^]

Removes unnecesary public method. Related to issue 19768

---
M src/org/openbravo/erpCommon/businessUtility/InitialSetupUtility.java
---
(0045248)
dalsasua   
2012-02-17 19:57   
Test Plan:

1. Go to initial client setup
2. Fill the mandatory fields and do not select the Advance&Payables module
3. Execute the process
4. Login with the new user
5. Go to Initial Org Setup and select the Advance&Payables module
6. Execute the process
7. Do a query in AD_ORGMODULE.
8. Just one record and have linked together the three checksum separate by comma
9. Go to initial client setup
10. Fill the mandatory fields and do not select the Advance&Payables module
11. Execute the process
12. Do a query in AD_CLIENTMODULE.
13. Just one record and have linked together the three checksum separate by comma
(0045249)
dalsasua   
2012-02-17 21:00   
After executing the steps in the plan. I executed the following query for client created applying datasets in initial client setup:


select * from (
select 'cm' as table, c.name as client, m.name as module, cm.version, '' as checksum
from ad_clientmodule cm left join ad_module m on m.ad_module_id=cm.ad_module_id left join ad_client c on c.ad_client_id=cm.ad_client_id
union all
select 'om' as table, c.name, m.name, cm.version, cm.checksum
from ad_orgmodule cm left join ad_module m on m.ad_module_id=cm.ad_module_id left join ad_client c on c.ad_client_id=cm.ad_client_id
) as foo order by client;


Obtaining following result:

· om;Cliente2;Advanced Payables and Receivables Mngmt;3.0.15265;3359875425927173862256776671284900067957,150513565400800394543833512211019964966,199569570667128490006795792717386225677
· cm;Cliente2;Advanced Payables and Receivables Mngmt;3.0.15265;
· cm;Cliente2;Core;3.0.15265;

What means that both entries where created: in ad_clientmodule and ad_orgmodule. I'm not that sure that this is correct. Nevertheless, I verified that the dataset can be updated again, when a new version arrives; and that it's not provided in enterprise module management until a new version with different checksum is installed, so I think it's correct.
(0045864)
hudsonbot   
2012-03-02 15:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045886)
hudsonbot   
2012-03-02 15:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test