Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019729Openbravo ERPY. DBSourceManagerpublic2012-02-10 20:462012-03-02 15:36
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP9Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019729: dbsm: Function- & Trigger-Standardisation should be made faster
DescriptionThat standardisation step i quite slow (i.e. 41s seconds) on a specific laptop.

The change planned in this issue reduces this time to around 26s on that same system (around 40% less) by rewriting one specific standardisation steps which changes end last system-provided 'END' line after the function body to read 'END <functionname/triggername>' for both the function & trigger standardisation.

That change does introduce 2 formal changes when applied to all PL-functions & -trigger present in pi.

Formal change: If the last line of the body does have trailing spaces those trailing spaces will be removed in the standardisation.

That change is deemed reasonable & acceptable compared to the speed-up which is achieved by the change.
Steps To ReproduceRun update.database and check runtime of the standardisation step done during the model-loading.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-02-10 20:46shuehnerNew Issue
2012-02-10 20:46shuehnerAssigned To => shuehner
2012-02-10 20:46shuehnerModules => Core
2012-02-12 14:09hgbotCheckin
2012-02-12 14:09hgbotNote Added: 0045047
2012-02-12 14:09hgbotStatusnew => resolved
2012-02-12 14:09hgbotResolutionopen => fixed
2012-02-12 14:09hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/9ce40055b2c7acd41f87f29ed386e669a0e5c827 [^]
2012-02-12 14:11hgbotCheckin
2012-02-12 14:11hgbotNote Added: 0045048
2012-02-12 14:11hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/dbsm-main/rev/9ce40055b2c7acd41f87f29ed386e669a0e5c827 [^] => http://code.openbravo.com/erp/devel/pi/rev/42ab557adad4f03184fd0eef044034da90cfc763 [^]
2012-03-01 14:08marvintmStatusresolved => closed
2012-03-02 15:36hudsonbotCheckin
2012-03-02 15:36hudsonbotNote Added: 0045831

Notes
(0045047)
hgbot   
2012-02-12 14:09   
Repository: erp/devel/dbsm-main
Changeset: 9ce40055b2c7acd41f87f29ed386e669a0e5c827
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Feb 10 20:48:17 2012 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/9ce40055b2c7acd41f87f29ed386e669a0e5c827 [^]

Fixed 19729: Speedup function- & trigger-standardization by around 40%
Rewrite regex changing 'END' to 'END <function/trigger-name>' which is applied
to the last system-provided line after the function body.
This changes slightly the standardization so does introduce 2 formal changes
when applied to all files in pi.
- Formal change: If last line of function-body does contain trailing spaces,
then those are removed on export.database

---
M src/org/apache/ddlutils/platform/postgresql/PostgrePLSQLFunctionStandarization.java
M src/org/apache/ddlutils/platform/postgresql/PostgrePLSQLTriggerStandarization.java
---
(0045048)
hgbot   
2012-02-12 14:11   
Repository: erp/devel/pi
Changeset: 42ab557adad4f03184fd0eef044034da90cfc763
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Feb 10 20:49:42 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/42ab557adad4f03184fd0eef044034da90cfc763 [^]

Fixed 19729: Speedup function- & trigger-standardization by around 40%
Rewrite regex changing 'END' to 'END <function/trigger-name>' which is applied
to the last system-provided line after the function body.
This changes slightly the standardization so does introduce 2 formal changes
when applied to all files in pi.
- Formal change: If last line of function-body does contain trailing spaces,
then those are removed on export.database
Those formal changes are also directly committed to pi in this cset.

---
M modules/org.openbravo.userinterface.selector/src-db/database/model/functions/OBUISEL_SYNCHRONIZE.xml
M src-db/database/lib/dbsourcemanager.jar
M src-db/database/model/functions/AD_UPDATE_TABLE_IDENTIFIER0.xml
---
(0045831)
hudsonbot   
2012-03-02 15:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test