Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019697Openbravo ERP09. Financial managementpublic2012-02-09 09:302012-04-02 12:13
Reporterpsanjuan 
Assigned Tovmromanos 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 8.04.1
Product Version 
Target VersionFixed in Version3.0MP9 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019697: It is not possible to create a Campaign, see error attached.
DescriptionIt is not possible to create a Campaign, see error attached.
Steps To ReproduceNavigate to F&B US Inc Accounting Schema and add:
Sales Region
Campaign
as new account elements (dimensions).

Navigate to Account Combination window.
Create a new record
Click on "Sales Campaign" field in order to create a new campaign.
Campaig window is open.
Try to create a new campaign.
Below error will be shown.
Proposed Solution
Additional Information
TagsOB3 Documentation, Regression, VMA-Reviewed
Relationships
related to defect 00184073.0MP5 closed jecharri Campaign tree does not work 
Attached Filespng error_campaign.png (66,610) 2012-02-09 09:30
https://issues.openbravo.com/file_download.php?file_id=4968&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-02-09 09:30psanjuanNew Issue
2012-02-09 09:30psanjuanAssigned To => jonalegriaesarte
2012-02-09 09:30psanjuanWeb browser => Google Chrome
2012-02-09 09:30psanjuanModules => Core
2012-02-09 09:30psanjuanFile Added: error_campaign.png
2012-02-09 09:57psanjuanTag Attached: OB3 Documentation
2012-02-15 19:03iciordiaAssigned Tojonalegriaesarte => vmromanos
2012-02-17 08:55vmromanosTag Attached: VMA-Reviewed
2012-03-20 00:04dmitry_mezentsevIssue Monitored: dmitry_mezentsev
2012-03-20 18:30vmromanosRelationship addedrelated to 0018407
2012-03-20 20:09dmitry_mezentsevTag Attached: Regression
2012-03-21 10:30hgbotCheckin
2012-03-21 10:30hgbotNote Added: 0046579
2012-03-21 10:30hgbotStatusnew => resolved
2012-03-21 10:30hgbotResolutionopen => fixed
2012-03-21 10:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/57131b13c97a77f1edc8a9d1e038b995fadcb8a2 [^]
2012-03-21 11:41hgbotCheckin
2012-03-21 11:41hgbotNote Added: 0046582
2012-03-21 11:52vmromanosNote Added: 0046584
2012-03-21 11:55vmromanosNote Added: 0046585
2012-03-21 12:02vmromanosNote Added: 0046588
2012-03-21 12:02vmromanosStatusresolved => closed
2012-04-01 20:34hgbotCheckin
2012-04-01 20:34hgbotNote Added: 0047016
2012-04-01 20:34hgbotStatusclosed => resolved
2012-04-01 20:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/57131b13c97a77f1edc8a9d1e038b995fadcb8a2 [^] => http://code.openbravo.com/erp/devel/pi/rev/e0d914c1efd1635ff518ce027e4072e24b968df6 [^]
2012-04-01 20:34hgbotCheckin
2012-04-01 20:34hgbotNote Added: 0047017
2012-04-02 06:11hudsonbotCheckin
2012-04-02 06:11hudsonbotNote Added: 0047179
2012-04-02 06:11hudsonbotCheckin
2012-04-02 06:11hudsonbotNote Added: 0047182
2012-04-02 12:13gorka_gilNote Added: 0047295
2012-04-02 12:13gorka_gilStatusresolved => closed
2012-04-02 12:13gorka_gilFixed in Version => 3.0MP9

Notes
(0046579)
hgbot   
2012-03-21 10:30   
Repository: erp/devel/pi
Changeset: 57131b13c97a77f1edc8a9d1e038b995fadcb8a2
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Wed Mar 21 10:29:38 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/57131b13c97a77f1edc8a9d1e038b995fadcb8a2 [^]

Fixes issue 19697: It is not possible to create a Campaign, see error attached.
Also complete the issue 18407

---
A src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateADClientInfo.class
A src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateADClientInfoData.class
A src-util/modulescript/src/org/openbravo/modulescript/UpdateADClientInfo.java
A src-util/modulescript/src/org/openbravo/modulescript/UpdateADClientInfo_data.xsql
---
(0046582)
hgbot   
2012-03-21 11:41   
Repository: erp/devel/pi
Changeset: 240bae48f88cfe1e21262242df7034cb9f03a964
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Wed Mar 21 11:40:03 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/240bae48f88cfe1e21262242df7034cb9f03a964 [^]

issue 19697, issue 18407.
Changed the method selectClientsID to have better performance and only update the neccesary clients

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateADClientInfoData.class
M src-util/modulescript/src/org/openbravo/modulescript/UpdateADClientInfo_data.xsql
---
(0046584)
vmromanos   
2012-03-21 11:52   
The root cause of this bug is in the fix of https://issues.openbravo.com/view.php?id=18407 [^] (on Oct 31)

This issue added a trigger to the C_Campaign table and a new column to the AD_ClientInfo, called AD_Tree_Campaing_ID

The C_Campaign_TRG trigger does the following query:
 SELECT c.AD_Tree_Campaign_ID,
      n.Node_ID
    INTO v_xTree_ID,
      v_xParent_ID
    FROM AD_ClientInfo c,
      AD_TreeNode n
    WHERE c.AD_Tree_Campaign_ID=n.AD_Tree_ID
      AND n.Parent_ID IS NULL
      AND c.AD_Client_ID=:new.AD_Client_ID;

In case c.AD_Tree_Campaign_ID is null the bug is reproducible.

For clients created before 0018407 this column is always null so it's necessary to create a module script that fills it for old clients
(0046585)
vmromanos   
2012-03-21 11:55   
No regression risk:
Test plan:
- Ensure AD_ClientInfo.AD_Tree_Campaign_ID is null for the clients in your instance
- Update your working copy to include this fix (MP9)
- Run ant smartbuild -Dlocal=no -Dforce=true
- Check org.openbravo.modulescript.UpdateADClientInfo is executed
- Query the database and check AD_ClientInfo.AD_Tree_Campaign_ID is not null for clients <> '0'
- Run again ant smartbuild -Dlocal=no -Dforce=true and check AD_ClientInfo.AD_Tree_Campaign_ID has the same data
(0046588)
vmromanos   
2012-03-21 12:02   
code review + testing OK
(0047016)
hgbot   
2012-04-01 20:34   
Repository: erp/devel/pi
Changeset: e0d914c1efd1635ff518ce027e4072e24b968df6
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Wed Mar 21 10:29:38 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e0d914c1efd1635ff518ce027e4072e24b968df6 [^]

Fixes issue 19697: It is not possible to create a Campaign, see error attached.
Also complete the issue 18407

---
A src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateADClientInfo.class
A src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateADClientInfoData.class
A src-util/modulescript/src/org/openbravo/modulescript/UpdateADClientInfo.java
A src-util/modulescript/src/org/openbravo/modulescript/UpdateADClientInfo_data.xsql
---
(0047017)
hgbot   
2012-04-01 20:34   
Repository: erp/devel/pi
Changeset: f5fe379ed93a6096bac2caa837ce4bee45a63597
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Wed Mar 21 11:40:03 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f5fe379ed93a6096bac2caa837ce4bee45a63597 [^]

issue 19697, issue 18407.
Changed the method selectClientsID to have better performance and only update the neccesary clients

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateADClientInfoData.class
M src-util/modulescript/src/org/openbravo/modulescript/UpdateADClientInfo_data.xsql
---
(0047179)
hudsonbot   
2012-04-02 06:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047182)
hudsonbot   
2012-04-02 06:11   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7814864461ac [^]

Maturity status: Test
(0047295)
gorka_gil   
2012-04-02 12:13   
Reopened by merge.