Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019675Openbravo ERPA. Platformpublic2012-02-07 11:182012-03-02 15:35
Reporterguilleaer 
Assigned Toguilleaer 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP9Fixed in Version3.0MP9 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019675: Some callouts should be re-factorized
DescriptionSome callouts should be re-factorized to take advantage of this change:
- https://issues.openbravo.com/view.php?id=19674 [^]

The following callouts are affected:
src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java
src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Locator.java
src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Product.java
src/org/openbravo/erpCommon/ad_callouts/SL_Movement_Product.java
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00202513.0MP11 closed guilleaer Under special conditions the business partner callout in orders windows, fails 
related to defect 0036302 closed platform Display logic in fields is not working in callouts using SimpleCallout 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-02-07 11:18guilleaerNew Issue
2012-02-07 11:18guilleaerAssigned To => alostale
2012-02-07 11:18guilleaerModules => Core
2012-02-07 11:18guilleaerAssigned Toalostale => guilleaer
2012-02-07 11:39hgbotCheckin
2012-02-07 11:39hgbotNote Added: 0044902
2012-02-07 11:39hgbotStatusnew => resolved
2012-02-07 11:39hgbotResolutionopen => fixed
2012-02-07 11:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/cac07d43bece9411dbff4ca9603f5a0e3fc100e1 [^]
2012-02-07 12:35guilleaerNote Added: 0044903
2012-03-01 10:02alostaleNote Added: 0045652
2012-03-01 10:07alostaleStatusresolved => closed
2012-03-01 10:07alostaleFixed in Version => 3.0MP9
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045766
2012-04-12 12:21jonalegriaesarteRelationship addedrelated to 0020251
2017-06-21 11:03aferrazRelationship addedrelated to 0036302

Notes
(0044902)
hgbot   
2012-02-07 11:39   
Repository: erp/devel/pi
Changeset: cac07d43bece9411dbff4ca9603f5a0e3fc100e1
Author: Guillermo Álvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Feb 07 11:33:36 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cac07d43bece9411dbff4ca9603f5a0e3fc100e1 [^]

Fixed issue 19675: Affected callouts have been re-factorized

---
M src/org/openbravo/erpCommon/ad_callouts/SE_Order_BPartner.java
M src/org/openbravo/erpCommon/ad_callouts/SL_InOutLine_Product.java
M src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Locator.java
M src/org/openbravo/erpCommon/ad_callouts/SL_Inventory_Product.java
M src/org/openbravo/erpCommon/ad_callouts/SL_Movement_Product.java
---
(0044903)
guilleaer   
2012-02-07 12:35   
Tests:
The responses of the callouts has been tested. They should be equals to the old callouts.

SE_Order_BPartner:
This callout has been tested in the following windows changing the business partner field
 - Header - Purchase order
 - Header - Return from customer
 - Header - Return to vendor
 - Header - Sales order

SL_InOutLine_Product:
This callout has been tested in the following windows changing the product field
 - Lines - Goods Receipt
 - Lines - Goods Shipment
 - Lines - Return Material Receipt
 - Lines - Return to Vendor Shipment
 - Shipment in line - Incoming Shipment
 - Shipment out line - Outgoing Shipment

SL_Inventory_Locator:
This callout has been tested in the following windows changing the storage-bin field
 - Lines - Physical Inventory

SL_Inventory_Product:
This callout has been tested in the following windows changing the product field
 - Lines - Physical Inventory

SL_Movement_Product:
This callout has been tested in the following windows changing the product field
 - Lines - Goods Movements

Regression risk:
This changes are considered risky because they could modify the callout response.
(0045652)
alostale   
2012-03-01 10:02   
Code reviewed and tested on pi@6eca00939cc8
(0045766)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test