Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0019659Openbravo ERPA. Platformpublic2012-02-06 11:412012-03-02 15:35
alostale 
iperdomo 
immediatecriticalalways
closedfixed 
5
 
3.0MP9 
Mozilla Firefox
Core
No
0019659: Application doesn't work with FF
After latest smartclient update application does not work with Firefox.
-Log in the application
-A blank screen is shown, checking the javascript errors, this appears:

Error: attempt to run compile-and-go script on a cleared scope
Source File: http://localhost:8080/openbravo/web/org.openbravo.client.kernel/js/LAB.min.js [^]
Line: 5
Regression QA
has duplicate defect 0019662 closed mtaal Accessing a context via DNS machine does not work while IP does 
has duplicate defect 0019714 closed jonalegriaesarte The Pop Up Add Payment of the window Payment In/Out does not work properly. 
related to defect 0019689 closed mtaal It is not possible to change Role twice in a row 
Issue History
2012-02-06 11:41alostaleNew Issue
2012-02-06 11:41alostaleAssigned To => mtaal
2012-02-06 11:41alostaleWeb browser => Mozilla Firefox
2012-02-06 11:41alostaleModules => Core
2012-02-06 11:41alostaleTag Attached: Regression QA
2012-02-06 12:58mtaalRelationship addedhas duplicate 0019662
2012-02-07 12:59hgbotCheckin
2012-02-07 12:59hgbotNote Added: 0044905
2012-02-07 12:59hgbotStatusnew => resolved
2012-02-07 12:59hgbotResolutionopen => fixed
2012-02-07 12:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ec446df8cfe5eb1cdae0139e438f93b10ea8002b [^]
2012-02-07 16:56iperdomoNote Added: 0044911
2012-02-07 16:57iperdomoNote Added: 0044912
2012-02-07 16:57iperdomoStatusresolved => closed
2012-02-08 13:27iperdomoStatusclosed => new
2012-02-08 13:27iperdomoResolutionfixed => open
2012-02-08 13:27iperdomoAssigned Tomtaal => iperdomo
2012-02-08 13:27iperdomoStatusnew => scheduled
2012-02-08 13:27iperdomofix_in_branch => pi
2012-02-08 13:31hgbotCheckin
2012-02-08 13:31hgbotNote Added: 0044928
2012-02-08 13:31hgbotStatusscheduled => resolved
2012-02-08 13:31hgbotResolutionopen => fixed
2012-02-08 13:31hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/ec446df8cfe5eb1cdae0139e438f93b10ea8002b [^] => http://code.openbravo.com/erp/devel/pi/rev/8e83aab6d0d52940d04ea43d2e4e1a2e9ff048ea [^]
2012-02-08 17:30hgbotCheckin
2012-02-08 17:30hgbotNote Added: 0044937
2012-02-08 17:30hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/8e83aab6d0d52940d04ea43d2e4e1a2e9ff048ea [^] => http://code.openbravo.com/erp/devel/pi/rev/f191318572b31337084439b1dd816d597b3ce705 [^]
2012-02-08 20:07plujanRelationship addedrelated to 0019689
2012-02-09 17:39iperdomoStatusresolved => new
2012-02-09 17:39iperdomoResolutionfixed => open
2012-02-09 18:00dmiguelezRelationship addedhas duplicate 0019714
2012-02-09 18:44iperdomoStatusnew => scheduled
2012-02-09 18:46hgbotCheckin
2012-02-09 18:46hgbotNote Added: 0044980
2012-02-09 18:46hgbotStatusscheduled => resolved
2012-02-09 18:46hgbotResolutionopen => fixed
2012-02-09 18:46hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/f191318572b31337084439b1dd816d597b3ce705 [^] => http://code.openbravo.com/erp/devel/pi/rev/449b6b3525406778a1f62138cd3c8611dbd49b4f [^]
2012-02-09 19:12dmiguelezNote Added: 0044981
2012-02-12 20:30mtaalNote Added: 0045049
2012-02-12 20:30mtaalStatusresolved => closed
2012-02-12 20:30mtaalFixed in Version => 3.0MP9
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045767
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045774
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045777
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045790

Notes
(0044905)
hgbot   
2012-02-07 12:59   
Repository: erp/devel/pi
Changeset: ec446df8cfe5eb1cdae0139e438f93b10ea8002b
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Feb 07 12:57:37 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ec446df8cfe5eb1cdae0139e438f93b10ea8002b [^]

Fixes issue 19659: Application doesn't work with FF
Replace document.write with creating a dom element, move autodraw and screenreader to first lines of generated js

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/StaticResourceComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
M src/index.jsp
---
(0044911)
iperdomo   
2012-02-07 16:56   
- Code review -

* Use the DOM script tag instead of using document.write for adding the static resources file in the page. Using document.write triggered a run/compile error:

http://www.google.com/search?q=firefox+Attempt+to+run+compile-and-go+script+on+a+cleared+scope [^]

* Moved the isc.setAutoDraw(false) at the beginning of the static resources, before starting to load/build SmartClient based components
(0044912)
iperdomo   
2012-02-07 16:57   
Tested using Firefox 10, on pi @ rev ec446df8cfe5
(0044928)
hgbot   
2012-02-08 13:31   
Repository: erp/devel/pi
Changeset: 8e83aab6d0d52940d04ea43d2e4e1a2e9ff048ea
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Feb 08 13:30:00 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8e83aab6d0d52940d04ea43d2e4e1a2e9ff048ea [^]

Fixes issue 19659: Confirm that the isc object exists before using it
- The previous code was using the isc object directly without verifying that exists
- Updated the copyright year

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/StaticResourceComponent.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
M src/index.jsp
---
(0044937)
hgbot   
2012-02-08 17:30   
Repository: erp/devel/pi
Changeset: f191318572b31337084439b1dd816d597b3ce705
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Wed Feb 08 17:26:36 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f191318572b31337084439b1dd816d597b3ce705 [^]

Fixes issue 19659: Use isc as member of the window object
if(window.isc) is not the same of if(isc) if isc is not defined

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/templates/application-js.ftl
---
(0044980)
hgbot   
2012-02-09 18:46   
Repository: erp/devel/pi
Changeset: 449b6b3525406778a1f62138cd3c8611dbd49b4f
Author: Iván Perdomo <ivan.perdomo <at> openbravo.com>
Date: Thu Feb 09 18:46:03 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/449b6b3525406778a1f62138cd3c8611dbd49b4f [^]

Fixes issue 19659: Changed the script tag function to anonymous function
- The OBScriptTag was only available in the main context (index.jsp) leading to JS errors in manual code using new-selectors
- Changed to inline anonymous 'self-executing' function
- Append script to the body tag in the main page, but head in classic mode

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/StaticResourceComponent.java
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
M src/index.jsp
---
(0044981)
dmiguelez   
2012-02-09 19:12   
Now the Pop Ups shown after clicking on Add Details in Payment In and Payment Out windows work properly on Chrome.
(0045049)
mtaal   
2012-02-12 20:30   
Reviewed
(0045767)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045774)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045777)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045790)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test