Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019621Openbravo ERPA. Platformpublic2012-02-02 10:182012-03-02 15:36
ReporterioritzCia 
Assigned Toalostale 
PrioritynormalSeverityminorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 10.04
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserMozilla Firefox
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019621: Advance Filtering is not working correctly in some columns.
DescriptionAdvance Filtering is not working correctly in some columns.
I think it happens in the ones that are an ID but this is a guess.
Steps To Reproduce- Go to 'Matched Purchase Orders' window.
- Try to set "#" filter in 'Invoice Line' to see the rows that have that value to null. It does not work.
- If you try to make a workaround to the previous filter you can set the filter to "!^P and !^F" it does not work neither.
-This column is an ID I have also tested the same filters in the line of an invoice with the product column and it does not work neither.
- I have tested them in the Business Partner Catgory window in the name column an they work fine. This is not an ID window.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0019253 closed alostale filtering numbers using a range fails when there are spaces 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-02-02 10:18ioritzCiaNew Issue
2012-02-02 10:18ioritzCiaAssigned To => alostale
2012-02-02 10:18ioritzCiaWeb browser => Mozilla Firefox
2012-02-02 10:18ioritzCiaModules => Core
2012-02-07 08:41alostaleRelationship addedrelated to 0019253
2012-02-13 15:59alostaleNote Added: 0045070
2012-02-13 16:01hgbotCheckin
2012-02-13 16:01hgbotNote Added: 0045071
2012-02-13 16:01hgbotStatusnew => resolved
2012-02-13 16:01hgbotResolutionopen => fixed
2012-02-13 16:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e4e3a55d6378ec9152cdeeabf570e5a7d096c195 [^]
2012-02-21 17:55marvintmNote Added: 0045327
2012-02-21 17:55marvintmStatusresolved => closed
2012-03-02 15:36hudsonbotCheckin
2012-03-02 15:36hudsonbotNote Added: 0045835

Notes
(0045070)
alostale   
2012-02-13 15:59   
The problem is in FK filters. For "null" and "notNull" operators the generated query composes the identifier and then checks if it is null or not null. Problem is in HQL compound paths are transformed in SQL inner joins, so null entries are just removed.

The solution is not to compose the identifier in this case but to directly check its nullness.

The risk of regression of this fix is low as it only affects filters null and not null on identifier columns.
(0045071)
hgbot   
2012-02-13 16:01   
Repository: erp/devel/pi
Changeset: e4e3a55d6378ec9152cdeeabf570e5a7d096c195
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Feb 13 16:00:40 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e4e3a55d6378ec9152cdeeabf570e5a7d096c195 [^]

fixed bug 19621: fixed null and not null filters on FK fields

---
M modules/org.openbravo.service.json/src/org/openbravo/service/json/AdvancedQueryBuilder.java
---
(0045327)
marvintm   
2012-02-21 17:55   
Tested both id and non-id columns.
(0045835)
hudsonbot   
2012-03-02 15:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test