Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0019620Openbravo ERP05. Production managementpublic2012-02-02 08:522012-03-02 15:39
networkb 
jecharri 
immediatemajoralways
closedfixed 
20
3.0MP7.1 
3.0MP9pi 
Google Chrome
Core
No
0019620: A Commit is done in ma_workeffort_validate() with an Extension Point configured
ONLY FOR ORACLE: ma_workeffort_validate function can be extended using Extension points. If you develop an Extension point that RAISES an exception and needs to execute a ROLLBACK, the rollback has no effect because there is a commit done in ma_workeffort_validate. So, no matter what happens in your extension point because the work effort will always process the work effort if there is no problem in ma_workeffort_validate procedure.

I think the commit is done because ma_workeffort_validate is calling MA_WRPHASE_CLOSE(p_instance_id) and ma_wrphase_close is executing ad_update_pinstance.
1. Create an Extension point for MA_WORKEFFORT_VALIDATE
2. force an exception in the extension point
3. see how an error is shown to the user but the work effort is processed.
No tags attached.
Issue History
2012-02-02 08:52networkbNew Issue
2012-02-02 08:52networkbAssigned To => jonalegriaesarte
2012-02-02 08:52networkbWeb browser => Google Chrome
2012-02-02 08:52networkbModules => Core
2012-02-02 10:11jonalegriaesarteWeb browserGoogle Chrome => Google Chrome
2012-02-02 10:11jonalegriaesarteTarget Version => 3.0MP9
2012-02-02 11:29jonalegriaesarteAssigned Tojonalegriaesarte => jecharri
2012-02-28 13:35hgbotCheckin
2012-02-28 13:35hgbotNote Added: 0045534
2012-02-28 13:35hgbotStatusnew => resolved
2012-02-28 13:35hgbotResolutionopen => fixed
2012-02-28 13:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/93367ec81ec7ac2931c31da8678c7f461b502900 [^]
2012-02-29 12:57networkbNote Added: 0045591
2012-02-29 12:57networkbStatusresolved => closed
2012-02-29 12:57networkbFixed in Version => pi
2012-03-02 15:39hudsonbotCheckin
2012-03-02 15:39hudsonbotNote Added: 0045972

Notes
(0045534)
hgbot   
2012-02-28 13:35   
Repository: erp/devel/pi
Changeset: 93367ec81ec7ac2931c31da8678c7f461b502900
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Tue Feb 28 13:33:47 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/93367ec81ec7ac2931c31da8678c7f461b502900 [^]

Fixes issue 19620: A Commit is done in
ma_workeffort_validate() with an Extension Point configures

---
M src-db/database/model/functions/MA_WORKEFFORT_VALIDATE.xml
M src-db/database/model/functions/MA_WRPHASE_CLOSE.xml
---
(0045591)
networkb   
2012-02-29 12:57   
Well done :)
(0045972)
hudsonbot   
2012-03-02 15:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test