Openbravo Issue Tracking System - Openbravo ERP |
View Issue Details |
|
ID | Project | Category | View Status | Date Submitted | Last Update |
0019545 | Openbravo ERP | A. Platform | public | 2012-01-23 22:04 | 2012-04-02 12:51 |
|
Reporter | dbaz | |
Assigned To | dbaz | |
Priority | high | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | |
Platform | | OS | 5 | OS Version | |
Product Version | | |
Target Version | 3.0MP9 | Fixed in Version | | |
Merge Request Status | |
Review Assigned To | |
OBNetwork customer | |
Web browser | |
Modules | Core |
Support ticket | |
Regression level | |
Regression date | |
Regression introduced in release | |
Regression introduced by commit | |
Triggers an Emergency Pack | No |
|
Summary | 0019545: Email server configuration is in different places |
Description | Right now there are two places to configure the email:
* "Client" window: this configuration is used in Alerts email notification
* "Email Configuration" window (child of "Client): this configuration is used in reports sent by email ("Email" toolbar icon button)
This is wrong and both features should use an unique email server configuration: the one in "Email Configuration" |
Steps To Reproduce | See "Test plan" comment in order to know how to test it. |
Proposed Solution | |
Additional Information | |
Tags | No tags attached. |
Relationships | has duplicate | feature request | 0006808 | | closed | jonalegriaesarte | Two places to configure mail-servers: 1.) Client (Request Management) and 2.) Client || Poc Configuration | related to | defect | 0020413 | 3.0MP11 | closed | marvintm | It does not work alerts emails | related to | defect | 0037498 | | closed | platform | org.openbravo.businessUtility.Email class is deprecated since 3.0MP9 and should be removed. |
|
Attached Files | |
|
Issue History |
Date Modified | Username | Field | Change |
2012-01-23 22:04 | dbaz | New Issue | |
2012-01-23 22:04 | dbaz | Assigned To | => dbaz |
2012-01-23 22:04 | dbaz | Modules | => Core |
2012-01-23 22:16 | dbaz | Note Added: 0044494 | |
2012-01-23 22:44 | dbaz | Note Added: 0044495 | |
2012-01-23 22:48 | dbaz | Note Edited: 0044495 | bug_revision_view_page.php?bugnote_id=0044495#r3081 |
2012-01-25 16:15 | dbaz | Note Edited: 0044495 | bug_revision_view_page.php?bugnote_id=0044495#r3097 |
2012-02-02 16:41 | hgbot | Checkin | |
2012-02-02 16:41 | hgbot | Note Added: 0044821 | |
2012-02-02 16:41 | hgbot | Status | new => resolved |
2012-02-02 16:41 | hgbot | Resolution | open => fixed |
2012-02-02 16:41 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/145375d4a13660cb80ac82264f640077906d0d52 [^] |
2012-02-02 16:44 | dbaz | Note Added: 0044823 | |
2012-02-08 19:11 | marvintm | Status | resolved => closed |
2012-02-15 13:33 | hgbot | Checkin | |
2012-02-15 13:33 | hgbot | Note Added: 0045148 | |
2012-02-16 12:40 | hgbot | Checkin | |
2012-02-16 12:40 | hgbot | Note Added: 0045189 | |
2012-02-16 13:16 | hgbot | Checkin | |
2012-02-16 13:16 | hgbot | Note Added: 0045191 | |
2012-03-02 15:34 | hudsonbot | Checkin | |
2012-03-02 15:34 | hudsonbot | Note Added: 0045737 | |
2012-03-02 15:37 | hudsonbot | Checkin | |
2012-03-02 15:37 | hudsonbot | Note Added: 0045857 | |
2012-03-02 15:37 | hudsonbot | Checkin | |
2012-03-02 15:37 | hudsonbot | Note Added: 0045870 | |
2012-03-02 15:37 | hudsonbot | Checkin | |
2012-03-02 15:37 | hudsonbot | Note Added: 0045872 | |
2012-03-15 12:29 | hgbot | Checkin | |
2012-03-15 12:29 | hgbot | Note Added: 0046450 | |
2012-04-01 20:33 | hgbot | Checkin | |
2012-04-01 20:33 | hgbot | Note Added: 0047013 | |
2012-04-02 06:10 | hudsonbot | Checkin | |
2012-04-02 06:10 | hudsonbot | Note Added: 0047147 | |
2012-04-02 12:51 | marvintm | Note Added: 0047305 | |
2012-05-04 11:16 | marvintm | Relationship added | related to 0020413 |
2013-04-22 21:42 | shuehner | Relationship added | has duplicate 0006808 |
2021-06-21 11:17 | shuehner | Relationship added | related to 0037498 |
Notes |
|
(0044494)
|
dbaz
|
2012-01-23 22:16
|
|
To fix the "design deffect" there are four steps:
* Create a module script that copies the data from "Client" window configuration (ONLY if "Mail Host" field is set) to "Email Configuration" window.
The new "Email Configuration" created configuration will have AD_ORG_ID = '0' in order to avoid possible conflicts. The AD_CLIENT_ID will be the same than the original "Client" configuration.
NOTES:
- If there is already a configuration introduced in the new implementation, don't create a new one in the new implementation. (Preserve also the old implementation configuration)
- If there is not configuration in the new implementation, move the data, and delete the configuration of the old implementation.
- If the existing configuration of the new implementation is the same than the old implementation one and is active, delete the configuration of the old implementation and set the new implementation configuration AD_ORG_ID = '0'
* Add a display logic, so if "Mail Host" field is empty, no one of the "Request Management" section items will be shown (to avoid from now on people introducing any configuration in these items).
* Modify the Alerts email sending logic in order to use the new implementation configuration ONLY in the case there is no old implementation configuration. |
|
|
(0044495)
|
dbaz
|
2012-01-23 22:44
(edited on: 2012-01-25 16:15) |
|
Test plan:
Part 1:
Create an instance with 5 clients:
Client A: only valid email configuration in the old implementation
Client B: only valid email configuration in the new implementation
Client C: DIFFERENT valid email configurations (different "Mail Host" vs "Smtp Server") in both old implementation and new implementation.
Client D: SAME valid email configurations (different "Mail Host" vs "Smtp Server") in both old implementation and new implementation. New implementation as "Active"
Update with the design deffect fix code and upgrade your instance. Now the only configuration that should remain the old implementation is "Client C". In the other cases "Request Management" is not shown.
This module script part of the test is MANDATORY to be tested in both Oracle and Postgres.
Part 2:
Ensure that emails sent within a form (email toolbar icon button) continue working as expected. For this configure a valid "Email Configuration" and try in any window. A more complete explanation of how to configure it can be found here: http://wiki.openbravo.com/wiki/Projects/Outbound_Email/User_Guide [^]
Also ensure emails logs are generated as previous (C_POC_EMAIL)
Part 3:
Ensure that both "Client A" and "Client C" sent emails for Alerts ("Client A" using the new implementation, ported in the module script, and "Client C" using the old implementation). You can take advantage of this document http://wiki.openbravo.com/wiki/Functional_Documentation/Alerts [^]
in order to configure an alert.
As a "trick" to do it faster, inside AlertProcess.java, change
if (insertions > 0)
by
if (insertions != -1)
to ensure always emails are sent (to the configured alert recipients, of course), and not just the first time the alert is raised.
The only change the tester could notice, is that using the old configuration, could be a situation where THE SAME email be sent to the same address many times for the same alert. In the new implementation there is an improvement to avoid this to happen.
|
|
|
(0044821)
|
hgbot
|
2012-02-02 16:41
|
|
Repository: erp/devel/pi
Changeset: 145375d4a13660cb80ac82264f640077906d0d52
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Jan 25 20:32:54 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/145375d4a13660cb80ac82264f640077906d0d52 [^]
Fixed issue 19545: 'Alerts' email system now uses POC 'Email Configuration' too
---
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/erpCommon/ad_process/AlertProcess.java
M src/org/openbravo/erpCommon/businessUtility/EMail.java
M src/org/openbravo/erpCommon/utility/poc/EmailManager.java
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
A src-util/modulescript/build/classes/org/openbravo/modulescript/UpgradeToPocEmail.class
A src-util/modulescript/build/classes/org/openbravo/modulescript/UpgradeToPocEmailData.class
A src-util/modulescript/src/org/openbravo/modulescript/UpgradeToPocEmail.java
A src-util/modulescript/src/org/openbravo/modulescript/UpgradeToPocEmail_Data.xsql
---
|
|
|
(0044823)
|
dbaz
|
2012-02-02 16:44
|
|
|
|
(0045148)
|
hgbot
|
2012-02-15 13:33
|
|
|
|
(0045189)
|
hgbot
|
2012-02-16 12:40
|
|
Repository: erp/devel/pi
Changeset: 60dc2b18fc074fa12254b7bba76894871c3a1823
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Feb 16 12:40:02 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/60dc2b18fc074fa12254b7bba76894871c3a1823 [^]
Related to issue 19545. Readded deprecation, but without the warnings
---
M src/org/openbravo/erpCommon/ad_process/AlertProcess.java
M src/org/openbravo/erpCommon/businessUtility/EMail.java
---
|
|
|
(0045191)
|
hgbot
|
2012-02-16 13:16
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
(0046450)
|
hgbot
|
2012-03-15 12:29
|
|
|
|
(0047013)
|
hgbot
|
2012-04-01 20:33
|
|
|
|
|
|
|
|
All the commits done after the issue was closed were subsequently reviewed and tested. |
|