Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019539Openbravo ERPA. Platformpublic2012-01-23 11:092012-03-02 15:40
Reporterjecharri 
Assigned ToAugustoMauch 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP10Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019539: Display logic doesn't work properly with checkboxes and parentheses
DescriptionDisplay logic doesn't work properly with checkboxes and parentheses
Steps To ReproduceAs "System Administrator" go to window "Windows,tabs and fields"
-select window "Sales Invoice"/ tab "Lines" / column "Net List Price"
-add in this column the "Display Logic" --> "(@Financial_Invoice_Line@='N')"

Now as "Group Admin" go to window "Sales Invoice":
-select one invoice and go to tab "Lines".
-You will see that you can't see the field "Net List Price". It doesn't matter the value of checkbox "Financial Invoice Line"

If you put the display logic as "@Financial_Invoice_Line@='N'" works properly. The problem are the parentheses
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-01-23 11:09jecharriNew Issue
2012-01-23 11:09jecharriAssigned To => alostale
2012-01-23 11:09jecharriWeb browser => Google Chrome
2012-01-23 11:09jecharriModules => Core
2012-01-23 11:09jecharriResolution time => 1334354400
2012-01-25 09:45alostaleAssigned Toalostale => AugustoMauch
2012-02-06 12:54hgbotCheckin
2012-02-06 12:54hgbotNote Added: 0044887
2012-02-06 12:54hgbotStatusnew => resolved
2012-02-06 12:54hgbotResolutionopen => fixed
2012-02-06 12:54hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/3afb28a2435ab781b3e5715146261b1d56116f20 [^]
2012-02-06 12:59AugustoMauchNote Added: 0044889
2012-02-07 14:08hgbotCheckin
2012-02-07 14:08hgbotNote Added: 0044906
2012-02-08 10:23hgbotCheckin
2012-02-08 10:23hgbotNote Added: 0044924
2012-02-08 16:23hgbotCheckin
2012-02-08 16:23hgbotNote Added: 0044932
2012-02-28 17:59hgbotCheckin
2012-02-28 17:59hgbotNote Added: 0045559
2012-02-29 10:11hgbotCheckin
2012-02-29 10:11hgbotNote Added: 0045567
2012-02-29 12:01hgbotCheckin
2012-02-29 12:01hgbotNote Added: 0045581
2012-02-29 19:00marvintmStatusresolved => closed
2012-03-02 15:34hudsonbotCheckin
2012-03-02 15:34hudsonbotNote Added: 0045762
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045768
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045773
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045776
2012-03-02 15:39hudsonbotCheckin
2012-03-02 15:39hudsonbotNote Added: 0045976
2012-03-02 15:40hudsonbotCheckin
2012-03-02 15:40hudsonbotNote Added: 0045978
2012-03-02 15:40hudsonbotCheckin
2012-03-02 15:40hudsonbotNote Added: 0045980

Notes
(0044887)
hgbot   
2012-02-06 12:54   
Repository: erp/devel/pi
Changeset: 3afb28a2435ab781b3e5715146261b1d56116f20
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Feb 06 12:52:31 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3afb28a2435ab781b3e5715146261b1d56116f20 [^]

Fixes issue 19539. Boolean values are now translated correctly

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
---
(0044889)
AugustoMauch   
2012-02-06 12:59   
This fix was considered risky because it was modified a function that was used by a lot of display logic strings.

Test plan:
- Analog to the steps to reproduce
- Try other display logic bracket combinations, for example:
   * ((@Financial_Invoice_Line@='N'))
   * [@Financial_Invoice_Line@='N']
   * @Financial_Invoice_Line@='N'
(0044906)
hgbot   
2012-02-07 14:08   
Repository: erp/devel/pi
Changeset: 8a33db400cad53bb7fb36893bf3bb4f4d78a202d
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 07 14:06:42 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8a33db400cad53bb7fb36893bf3bb4f4d78a202d [^]

Related to issue 19539: Adds unit test

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
A modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/DynamicExpressionParserTest.java
---
(0044924)
hgbot   
2012-02-08 10:23   
Repository: erp/devel/pi
Changeset: fb929aa798822e7f780c09df45b2c1c002083c1d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Feb 08 10:22:47 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fb929aa798822e7f780c09df45b2c1c002083c1d [^]

Related to issue 19539. Removed wrong import

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
---
(0044932)
hgbot   
2012-02-08 16:23   
Repository: erp/devel/pi
Changeset: 343f8acaaedbcb5b7033de777c38971c4484208b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Feb 08 16:22:14 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/343f8acaaedbcb5b7033de777c38971c4484208b [^]

Related to issue 19539. Adds the license text header to the test file

---
M modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/DynamicExpressionParserTest.java
---
(0045559)
hgbot   
2012-02-28 17:59   
Repository: erp/devel/pi
Changeset: 1ac5c5ca6841c9acaf786aa934ee9df1ab8517ae
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 28 17:46:59 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1ac5c5ca6841c9acaf786aa934ee9df1ab8517ae [^]

Related to issue 19539: Improve DynamicExpressionParser test

The DynamicExpressionParserTest has been improved, so it can extend BaseTest instead of TestCase. This way, there is no need to duplicate the code modified in the transformValue function.
The class DynamicExpressionParser has been adapted to be able to be used in a BaseTest. Now, if weld can not be used the get the list of fields and auxiliary inputs, that info will be taken directly from the tab.

---
M modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/DynamicExpressionParserTest.java
M modules/org.openbravo.client.application/src/org/openbravo/client/application/DynamicExpressionParser.java
---
(0045567)
hgbot   
2012-02-29 10:11   
Repository: erp/devel/pi
Changeset: 10e3111439cce42e2a35409aeda6919eaca8991c
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Feb 29 09:55:09 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/10e3111439cce42e2a35409aeda6919eaca8991c [^]

Related to issue 19539: Revert function name change to prevent an API change

The name of the JUnit test used to check the correct behaviour of the DynamicExpressionParser was changed in the changeset 15641. This name change was breaking the API, so that name change is being reverted.

---
M modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/DynamicExpressionParserTest.java
---
(0045581)
hgbot   
2012-02-29 12:01   
Repository: erp/devel/pi
Changeset: 7f69d5ac8a7ebd504e00412fe7b956bbedd85374
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Feb 29 11:46:53 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7f69d5ac8a7ebd504e00412fe7b956bbedd85374 [^]

Related to issue 19539: Modify function signature to prevent API change

When the signature of the function used to test the DynamicExpressionParser was modified, it was added a throws Exception clause, which broke the API. This change has been reverted to prevent the API change.

---
M modules/org.openbravo.client.application/src-test/org/openbravo/client/application/test/DynamicExpressionParserTest.java
---
(0045762)
hudsonbot   
2012-03-02 15:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045768)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045773)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045776)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045976)
hudsonbot   
2012-03-02 15:39   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045978)
hudsonbot   
2012-03-02 15:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045980)
hudsonbot   
2012-03-02 15:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test