Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019469Openbravo ERP03. Procurement managementpublic2012-01-11 18:122012-04-01 20:37
ReporterVictorVillar 
Assigned Tojecharri 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP6.1 
Target Version3.0MP10Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019469: Duplicity in purchase invoice lines
DescriptionWhen the user creates a purchase invoice, and creates the lines from an order, he can creates the lines again and again, and then process the invoice without an error.
Steps To ReproduceAs Group Admin role,
Go to Purchase Order,
  - Create a new register
        Business partner: Be Soft
  Go to Lines tab:
        -Creates a new line
        - Product: Cherry Cola
save it and Book it.

Go to Purchase invoice window:
   - Create a new register
        Business partner: Be soft
  Click in "Create Lines From" button
     - Choose the order before
     - select Cherry cola line
     - Accept it
     - Again repeat the process:
             Click in "Create Lines From" button
               - Choose the order before
               - select Cherry cola line
               - Accept it
Save the invoice and process it.
We realise that an error does not appear, and we have duplicated the lines.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00198642.50MP40 closed jecharri Duplicity in purchase invoice lines 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-01-11 18:12VictorVillarNew Issue
2012-01-11 18:12VictorVillarAssigned To => jonalegriaesarte
2012-01-11 18:12VictorVillarModules => Core
2012-01-11 18:12VictorVillarResolution time => 1332885600
2012-01-11 18:12VictorVillarIssue Monitored: networkb
2012-02-02 11:29jonalegriaesarteAssigned Tojonalegriaesarte => jecharri
2012-02-20 19:04hgbotCheckin
2012-02-20 19:04hgbotNote Added: 0045285
2012-02-20 19:04hgbotStatusnew => resolved
2012-02-20 19:04hgbotResolutionopen => fixed
2012-02-20 19:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4a020fd924d0aded59488f1264a6707f56d0eaba [^]
2012-02-24 09:17jecharriStatusresolved => new
2012-02-24 09:17jecharriResolutionfixed => open
2012-02-24 09:17jecharriStatusnew => scheduled
2012-02-24 09:17jecharrifix_in_branch => pi
2012-02-24 09:17jecharriStatusscheduled => resolved
2012-02-24 09:17jecharriResolutionopen => fixed
2012-02-29 18:36hgbotCheckin
2012-02-29 18:36hgbotNote Added: 0045636
2012-02-29 18:36jecharriStatusresolved => new
2012-02-29 18:36jecharriResolutionfixed => open
2012-02-29 18:36jecharriTarget Version3.0MP9 => 3.0MP10
2012-02-29 18:36jecharrifix_in_branchpi =>
2012-03-02 15:38hudsonbotCheckin
2012-03-02 15:38hudsonbotNote Added: 0045902
2012-03-02 15:40hudsonbotCheckin
2012-03-02 15:40hudsonbotNote Added: 0046004
2012-03-05 11:34hgbotCheckin
2012-03-05 11:34hgbotNote Added: 0046031
2012-03-05 11:34hgbotStatusnew => resolved
2012-03-05 11:34hgbotResolutionopen => fixed
2012-03-05 11:34hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/4a020fd924d0aded59488f1264a6707f56d0eaba [^] => http://code.openbravo.com/erp/devel/pi/rev/98b414b9d164c2a11e8663f47fe5132e2f62cdc4 [^]
2012-03-05 11:49jecharriNote Added: 0046033
2012-03-05 18:47hgbotCheckin
2012-03-05 18:47hgbotNote Added: 0046057
2012-03-15 16:55VictorVillarNote Added: 0046468
2012-03-15 16:55VictorVillarStatusresolved => closed
2012-04-01 20:37hudsonbotCheckin
2012-04-01 20:37hudsonbotNote Added: 0047030
2012-04-01 20:37hudsonbotCheckin
2012-04-01 20:37hudsonbotNote Added: 0047036

Notes
(0045285)
hgbot   
2012-02-20 19:04   
Repository: erp/devel/pi
Changeset: 4a020fd924d0aded59488f1264a6707f56d0eaba
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Sat Feb 18 18:22:51 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4a020fd924d0aded59488f1264a6707f56d0eaba [^]

Fixes issue 19469: Duplicity in purchase invoice lines.
With this patch, now the clients will be able to select one line from the orders if they have not got all the quantity invoiced yet in the same invoice

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0045636)
hgbot   
2012-02-29 18:36   
Repository: erp/devel/pi
Changeset: 6de349321d774c80c00aaa9f6de979d930ee1b83
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Wed Feb 29 18:34:57 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/6de349321d774c80c00aaa9f6de979d930ee1b83 [^]

Backout of issue 19469

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0045902)
hudsonbot   
2012-03-02 15:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0046004)
hudsonbot   
2012-03-02 15:40   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0046031)
hgbot   
2012-03-05 11:34   
Repository: erp/devel/pi
Changeset: 98b414b9d164c2a11e8663f47fe5132e2f62cdc4
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Mon Mar 05 11:34:17 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/98b414b9d164c2a11e8663f47fe5132e2f62cdc4 [^]

Fixes issue 19469: Duplicity in purchase invoice lines.
With this patch, now the clients will be able to select one line from the orders if they have not got all the quantity invoiced yet in the same invoice

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0046033)
jecharri   
2012-03-05 11:49   
Test cases:
-create one purchase order to one BP and with 2 lines. Book it
-go to window purchase invoice and create a header for the same BP:
  +now push in create lines, and see that the lines appear with the same qty like in the order
  +add lines and change the qty to less qty.
  +push again in create lines and see that now the qty change to = order qty -inserted qty
  +complete the invoice, with the same qty like in the order and complete it.
  +create a new invoice and see that the order is not proposal.

-create a new order with the same values.
-go to invoice and create a header.
-push in create lines and select the created order:
  +select only one line and add.
  +push again in create lines and see that only one line is proposal.
  +select the line and add
  +push again in create lines and select the order see that if you have the same qty as in the order the lines are not proposal.

-create a new order with the same values.
-go to invoice and create a header.
-push in create lines and select the created order:
  +select 2 lines and put less qty and colmplete.
  +create a new invoice and push in create lines:
       -see that the proposal lines qty is: ordered qty - invoiced qty
(0046057)
hgbot   
2012-03-05 18:47   
Repository: erp/devel/pi
Changeset: 78ee857dbe74f954c248a2db0c47435ff3c2682e
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Mon Mar 05 18:46:08 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/78ee857dbe74f954c248a2db0c47435ff3c2682e [^]

issue 19469: Duplicity in purchase invoice lines.
Now it does not prupouse lines with negative quantity and apart from that, are considered invoiced lines when the application is going to prupouse lines from selected order

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0046468)
VictorVillar   
2012-03-15 16:55   
Verified
(0047030)
hudsonbot   
2012-04-01 20:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/640de9acc2d5 [^]

Maturity status: Test
(0047036)
hudsonbot   
2012-04-01 20:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/640de9acc2d5 [^]

Maturity status: Test