Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0019463Openbravo ERPA. Platformpublic2012-01-11 16:222012-02-01 08:58
jecharri 
jecharri 
highmajoralways
closedfixed 
20Community Appliance
pi 
3.0MP83.0MP8 
Google Chrome
Core
No
0019463: Read Only Logic for columns is applied incorrectly
Currently, there are several ways to make some tabs/fields read only:
- A role may have access but not write permission to a window.
- A window can be of type "query"
- A tab can have a UI Pattern of Read Only
- A single field within a Tab can be Read Only
- A column can be non updatable (meaning that it can only be edited when creating a record)
- A column can have a Read Only Logic that will make the field read only dynamically, similar to Display Logics, but at a column level.


Read Only Logic should only be validated / applied if the previous conditions are not met, e.g. the column should be already editable.

Currently, Read Only Logic can make editable some fields which are not designed to be.
1. Give an editable column a read only logic of 'false'. This means it should always be editable.
2. Make read only a field for this column
3. The field is editable even if it has been set to read only in this tab, since it is following the Read Only Logic rule instead of its field AD information.
Revise the whole read only functionality
No tags attached.
related to defect 0017395 closed jecharri Read Only Logic for columns is applied incorrectly 
Issue History
2012-01-11 16:22jecharriNew Issue
2012-01-11 16:22jecharriAssigned To => jecharri
2012-01-11 16:22jecharriWeb browser => Google Chrome
2012-01-11 16:22jecharriModules => Core
2012-01-11 16:22jecharriIssue generated from0017395
2012-01-11 16:22jecharriRelationship addedrelated to 0017395
2012-01-11 16:33maria_perezIssue Monitored: maria_perez
2012-01-16 13:20hgbotCheckin
2012-01-16 13:20hgbotNote Added: 0044397
2012-01-16 13:20hgbotStatusnew => resolved
2012-01-16 13:20hgbotResolutionopen => fixed
2012-01-16 13:20hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/1c7cc06530d5faf57bf0aaafa43332d6c8293063 [^]
2012-01-18 14:22hudsonbotCheckin
2012-01-18 14:22hudsonbotNote Added: 0044432
2012-01-30 18:14hgbotCheckin
2012-01-30 18:14hgbotNote Added: 0044716
2012-01-31 09:16AugustoMauchNote Added: 0044721
2012-01-31 09:16AugustoMauchStatusresolved => closed
2012-01-31 09:16AugustoMauchFixed in Version => 3.0MP8
2012-02-01 08:58hudsonbotCheckin
2012-02-01 08:58hudsonbotNote Added: 0044752

Notes
(0044397)
hgbot   
2012-01-16 13:20   
Repository: erp/devel/pi
Changeset: 1c7cc06530d5faf57bf0aaafa43332d6c8293063
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Mon Jan 16 13:10:38 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/1c7cc06530d5faf57bf0aaafa43332d6c8293063 [^]

Fixes issue 17395, Fixes issue 19463: Read Only Logic for columns is applied incorrectly.
Now the readonlylogic expression is not going to be applied until the application check if the field is defined as read only

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
---
(0044432)
hudsonbot   
2012-01-18 14:22   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0035a0985219 [^]

Maturity status: Test
(0044716)
hgbot   
2012-01-30 18:14   
Repository: erp/devel/pi
Changeset: a052b9bb86e5a76902755ba6c08da5fc02550923
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Mon Jan 30 18:13:28 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a052b9bb86e5a76902755ba6c08da5fc02550923 [^]

issue 17395, issue 19463: Read Only Logic for columns is applied incorrectly.
Now the read only logic is applied correctly for fields without column related (OBClientClassField)

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/OBViewFieldHandler.java
---
(0044721)
AugustoMauch   
2012-01-31 09:16   
Code reviewed and fix verified
(0044752)
hudsonbot   
2012-02-01 08:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/933a9b7b9d89 [^]

Maturity status: Test