Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019462Openbravo ERPA. Platformpublic2012-01-11 16:172012-03-02 15:34
Reporterdbaz 
Assigned Todbaz 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019462: "Pick & Execute" "Pin" icon should be inside skin folder and path not hardcoded in sources
Description"Pick & Execute" "Pin" icon should be inside skin folder and path not hardcoded in sources, in order to be able to be skinned in the same way other components do: http://wiki.openbravo.com/wiki/Skins [^]

Currently iconPin.png is inside

modules/org.openbravo.client.application/web/org.openbravo.client.application/images/

(this "images" folder should be removed too)

and it should be inside

modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/process/


Also the path currently is inside

modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js

and it should be inside

modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-process.js

in a way similar like: OB.Styles.skinsPath + 'Default/org.openbravo.client.application/images/process/iconPin.png'
Steps To ReproduceLook at paths mentioned in "Description"
Proposed SolutionMove to the paths mentioned in "Description"
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-01-11 16:17dbazNew Issue
2012-01-11 16:17dbazAssigned To => iperdomo
2012-01-11 16:17dbazModules => Core
2012-01-24 13:49iperdomoAssigned Toiperdomo => dbaz
2012-02-02 15:49hgbotCheckin
2012-02-02 15:49hgbotNote Added: 0044816
2012-02-02 15:49hgbotStatusnew => resolved
2012-02-02 15:49hgbotResolutionopen => fixed
2012-02-02 15:49hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/87a191c834a29a6a1b85687094fd52d78f1c6aca [^]
2012-02-09 17:00iperdomoNote Added: 0044976
2012-02-09 17:00iperdomoStatusresolved => closed
2012-03-02 15:34hudsonbotCheckin
2012-03-02 15:34hudsonbotNote Added: 0045734

Notes
(0044816)
hgbot   
2012-02-02 15:49   
Repository: erp/devel/pi
Changeset: 87a191c834a29a6a1b85687094fd52d78f1c6aca
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Feb 01 23:08:53 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/87a191c834a29a6a1b85687094fd52d78f1c6aca [^]

Fixed issue 19462: moved hardcoded 'pick and execute' values to the skin

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/process/iconPin.png
A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-process-styles.js
R modules/org.openbravo.client.application/web/org.openbravo.client.application/images/iconPin.png
---
(0044976)
iperdomo   
2012-02-09 17:00   
Tested on pi @ rev 2d73d1ed6bf1
(0045734)
hudsonbot   
2012-03-02 15:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test