Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0019429Openbravo ERPB. User interfacepublic2012-01-09 12:122012-04-26 18:48
plujan 
vmromanos 
highminoralways
closedduplicate 
5
pi 
 
Mozilla Firefox
Core
No
0019429: An horizontal scrollbar is shown after completing an Invoice in 1024x768
The new buttons for Editable Payment project had made the toolbar too wide for a 1024x768 screen and an horizontal bar is shown. See attach
With Editable Payment Plan activated, complete a sales invoice
No tags attached.
duplicate of feature request 0017328 new Triage Platform Base [Processes & Pickers] Combination Process Buttons + Lose Process Windows 
png Toolbar.png (105,677) 2012-01-09 12:12
https://issues.openbravo.com/file_download.php?file_id=4886&type=bug
png

png ButtonsShortLabels.png (8,500) 2012-04-26 12:54
https://issues.openbravo.com/file_download.php?file_id=5172&type=bug
png
Issue History
2012-01-09 12:12plujanNew Issue
2012-01-09 12:12plujanAssigned To => dalsasua
2012-01-09 12:12plujanFile Added: Toolbar.png
2012-01-09 12:12plujanWeb browser => Mozilla Firefox
2012-01-09 12:12plujanModules => Core
2012-04-18 10:51alostaleAssigned Todalsasua => alostale
2012-04-19 08:43alostaleAssigned Toalostale => vmromanos
2012-04-26 09:30SandrahuguetAssigned Tovmromanos => Sandrahuguet
2012-04-26 09:31SandrahuguetStatusnew => scheduled
2012-04-26 09:31Sandrahuguetfix_in_branch => pi
2012-04-26 10:01SandrahuguetWeb browserMozilla Firefox => Mozilla Firefox
2012-04-26 10:01SandrahuguetNote Added: 0047990
2012-04-26 10:01SandrahuguetAssigned ToSandrahuguet => alostale
2012-04-26 10:01SandrahuguetTypedefect => feature request
2012-04-26 10:01Sandrahuguetfix_in_branchpi =>
2012-04-26 12:54rgorisWeb browserMozilla Firefox => Mozilla Firefox
2012-04-26 12:54rgorisNote Added: 0048024
2012-04-26 12:54rgorisFile Added: ButtonsShortLabels.png
2012-04-26 12:54rgorisWeb browserMozilla Firefox => Mozilla Firefox
2012-04-26 12:54rgorisReproducibilityhave not tried => always
2012-04-26 12:54rgorisIssue Monitored: rgoris
2012-04-26 13:07rgorisRelationship addedrelated to 0017328
2012-04-26 13:08plujanAssigned Toalostale => vmromanos
2012-04-26 13:56vmromanosRelationship replacedduplicate of 0017328
2012-04-26 13:56vmromanosNote Added: 0048030
2012-04-26 13:56vmromanosStatusscheduled => closed
2012-04-26 13:56vmromanosResolutionopen => duplicate
2012-04-26 18:48rgorisNote Added: 0048066

Notes
(0047990)
Sandrahuguet   
2012-04-26 10:01   
It is proposed a button to display the hidden buttons, as the same behavior of the tabs.
(0048024)
rgoris   
2012-04-26 12:54   
This is indeed very nasty looking. The long term solution is to stack buttons so you would have a drop-down style button (comparable to a MORE [V] button) - an other feature request is already created a while ago for this.

The short term solution, which is a quick-win and which I recommend to implement now (as in: next MP) is to shorten some labels. This does not only avoid the scroll bar to appear, it´s also easier to read. See attached proposal, it is really just taking some (obvious) words out.
(0048030)
vmromanos   
2012-04-26 13:56   
Closed because of the following reasons:
- Initially these buttons had the proposed labels (without including IN/OUT), however these labels created a problem when translating them to languages where there is a distinction between payment in and payment out, like in Spanish where payment in is translated as "cobro" and payment out is translated as "pago".
That's why we decided to include the IN/OUT words in all the places in the ERP where this kind of distinction made sense.
If we revert this change we will create again real problems for the Spanish (or other country) users, that are much more important than cosmetic issues.

- Shorten the labels in English a few chars probably won't fix this issue in case we decide to include more buttons inside this window, or in case a module includes more buttons.

- Finally with this solution we don't ensure the new translated labels for this buttons are short enough to make the scrollbar disappear.


To proper fix this issue, 0017328 must be fixed. So I'm closing this issue as duplicated
(0048066)
rgoris   
2012-04-26 18:48   
Discussed with Eduardo. The issue is that the "Add Payment xxx" buttons in Sales Invoice and Purchase invoice are the same (use the same label source). This is not good as we can´t have different labels in this case.

Eduardo now is trying to make a split between the buttons for Sales Invoices and Purchase Invoices so we can properly label the buttons as follows:

- "Add Payment In" for Sales Invoices
- "Add Payment Out" for Purchase Invoices

If this is - for whatever reason - not going to be possible, then this issue needs to be reopened.