Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019426Openbravo ERPA. Platformpublic2012-01-09 10:082012-01-14 21:21
Reporterrgoris 
Assigned Todbaz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019426: Change message text - attachments deletion
DescriptionWhen trying to delete an attachment, the system prompts the user with a confirmation message. The text is not 100% accurate as it says "Delete" in stead of "Remove". Same for the button label.

Remove is the preferred term here to avoid confusion with deletion of the file itself (from the file system). Removing here means taking it out from the ERP but it (probably) still exists elsewhere.

Also I propose to use titles that refer to the action to be taken: "Remove Attachment".
Steps To Reproducedelete an attachment
Proposed SolutionMessage title: "Remove Attachment"
Message: "Are you sure you want to permanently remove this attachment?"

and same for plural:

"Are you sure you want to permanently remove all the attachments of this record?"

and the button must be [ Remove ] and [ Remove All ]

Additional Information
TagsNo tags attached.
Relationships
related to feature request 0019423 closed dbaz Change message text - record deletion 
Attached Filespng Remove-Question-attachment.png (10,490) 2012-01-09 10:08
https://issues.openbravo.com/file_download.php?file_id=4883&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-01-09 10:08rgorisNew Issue
2012-01-09 10:08rgorisAssigned To => dbaz
2012-01-09 10:08rgorisFile Added: Remove-Question-attachment.png
2012-01-09 10:08rgorisModules => Core
2012-01-09 10:08rgorisIssue generated from0019423
2012-01-09 10:08rgorisRelationship addedrelated to 0019423
2012-01-10 11:48rgorisDescription Updatedbug_revision_view_page.php?rev_id=3033#r3033
2012-01-10 11:48rgorisProposed Solution updated
2012-01-10 14:20dbazNote Added: 0044181
2012-01-10 15:14hgbotCheckin
2012-01-10 15:14hgbotNote Added: 0044188
2012-01-10 15:14hgbotStatusnew => resolved
2012-01-10 15:14hgbotResolutionopen => fixed
2012-01-10 15:14hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ea78618e25e9c510f83d6b6941cc1ed7d0d3ddc7 [^]
2012-01-10 15:28mtaalNote Added: 0044190
2012-01-11 11:34rgorisNote Added: 0044245
2012-01-11 11:42rgorisNote Added: 0044247
2012-01-11 11:42rgorisStatusresolved => new
2012-01-11 11:42rgorisResolutionfixed => open
2012-01-11 13:49hgbotCheckin
2012-01-11 13:49hgbotNote Added: 0044258
2012-01-11 13:50dbazStatusnew => scheduled
2012-01-11 13:50dbazfix_in_branch => pi
2012-01-11 13:50dbazStatusscheduled => resolved
2012-01-11 13:50dbazResolutionopen => fixed
2012-01-11 14:18mtaalNote Added: 0044262
2012-01-12 11:30rgorisNote Added: 0044297
2012-01-12 11:30rgorisStatusresolved => closed
2012-01-14 21:21hudsonbotCheckin
2012-01-14 21:21hudsonbotNote Added: 0044350
2012-01-14 21:21hudsonbotCheckin
2012-01-14 21:21hudsonbotNote Added: 0044371

Notes
(0044181)
dbaz   
2012-01-10 14:20   
To test it:
As "Openbravo Admin"
* Go to any window: Example "Sales Order"
* Go to form view
* Add one attachment
* Click in the "Remove" button
Notice that the dialog message and dialog title is the expected one

* Add more than one attachment
* Click in the "Remove All" button
Notice that the dialog message and dialog title is the expected one
(0044188)
hgbot   
2012-01-10 15:14   
Repository: erp/devel/pi
Changeset: ea78618e25e9c510f83d6b6941cc1ed7d0d3ddc7
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Jan 10 15:14:15 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ea78618e25e9c510f83d6b6941cc1ed7d0d3ddc7 [^]

Fixed issue 19426: 'Remove attachment' message changed

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
---
(0044190)
mtaal   
2012-01-10 15:28   
Reviewed
(0044245)
rgoris   
2012-01-11 11:34   
I noticed one detail that would be good to fix still:

When removing multiple attachments at once, the message title should be:

"Remove Attachments" (with an additional s)
(0044247)
rgoris   
2012-01-11 11:42   
as per last note
(0044258)
hgbot   
2012-01-11 13:49   
Repository: erp/devel/pi
Changeset: ba03356ff1fa8f8038c1b4a281cc347e48b1d026
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Jan 11 13:48:51 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ba03356ff1fa8f8038c1b4a281cc347e48b1d026 [^]

Related to issue 19426: Added plural dialog title case

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
---
(0044262)
mtaal   
2012-01-11 14:18   
Reviewed
(0044297)
rgoris   
2012-01-12 11:30   
tested and considered solved
(0044350)
hudsonbot   
2012-01-14 21:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test
(0044371)
hudsonbot   
2012-01-14 21:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test