Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019423Openbravo ERPA. Platformpublic2012-01-08 13:512012-01-14 21:21
Reporterrgoris 
Assigned Todbaz 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019423: Change message text - record deletion
DescriptionWhen trying to delete a row, the system prompts the user with a confirmation message. The text is not 100% accurate as it says "Remove" in stead of delete, whereas the tooltip on the delete button in the toolbar says "Delete".

Also the "Question" label in the title bar is a bit silly, I propose to use titles that refer to the action to be taken: "Delete Record".
Steps To Reproducedelete a row in a grid
Proposed SolutionMessage title: "Delete Record"
Message: "Are you sure that you want to delete the selected record?"

Additional Information
TagsNo tags attached.
Relationships
related to feature request 0019426 closed dbaz Change message text - attachments deletion 
Attached Filespng Remove-Question.png (8,822) 2012-01-08 13:51
https://issues.openbravo.com/file_download.php?file_id=4881&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2012-01-08 13:51rgorisNew Issue
2012-01-08 13:51rgorisAssigned To => dbaz
2012-01-08 13:51rgorisFile Added: Remove-Question.png
2012-01-08 13:51rgorisModules => Core
2012-01-09 10:08rgorisIssue cloned0019426
2012-01-09 10:08rgorisRelationship addedrelated to 0019426
2012-01-09 10:09rgorisSummaryChange message text => Change message text - record deletion
2012-01-10 12:46hgbotCheckin
2012-01-10 12:46hgbotNote Added: 0044173
2012-01-10 12:46hgbotStatusnew => resolved
2012-01-10 12:46hgbotResolutionopen => fixed
2012-01-10 12:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/33855ed49422d96afc2ec9a9df7ccad92d232bd5 [^]
2012-01-10 13:59mtaalNote Added: 0044178
2012-01-10 14:26dbazNote Added: 0044184
2012-01-11 11:33rgorisNote Added: 0044242
2012-01-11 11:42rgorisNote Added: 0044248
2012-01-11 11:42rgorisStatusresolved => new
2012-01-11 11:42rgorisResolutionfixed => open
2012-01-11 14:15hgbotCheckin
2012-01-11 14:15hgbotNote Added: 0044261
2012-01-11 14:16dbazStatusnew => scheduled
2012-01-11 14:16dbazfix_in_branch => pi
2012-01-11 14:16dbazStatusscheduled => resolved
2012-01-11 14:16dbazResolutionopen => fixed
2012-01-11 14:23mtaalNote Added: 0044264
2012-01-12 11:30rgorisNote Added: 0044296
2012-01-12 11:30rgorisStatusresolved => closed
2012-01-14 21:20hudsonbotCheckin
2012-01-14 21:20hudsonbotNote Added: 0044344
2012-01-14 21:21hudsonbotCheckin
2012-01-14 21:21hudsonbotNote Added: 0044372

Notes
(0044173)
hgbot   
2012-01-10 12:46   
Repository: erp/devel/pi
Changeset: 33855ed49422d96afc2ec9a9df7ccad92d232bd5
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Mon Jan 09 21:26:24 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/33855ed49422d96afc2ec9a9df7ccad92d232bd5 [^]

Fixed issue 19423: 'Delete selected record' message changed

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0044178)
mtaal   
2012-01-10 13:59   
Reviewed
(0044184)
dbaz   
2012-01-10 14:26   
To test it:
As "Openbravo Admin"
* Go to any window: Example "Sales Order"
* Select one record in grid
* Click in the "Delete" toolbar icon.
Notice that the dialog message and dialog title is the expected one

* Select more than one record in grid
* Click in the "Delete" toolbar icon.
Notice that the dialog message and dialog title is the expected one
(0044242)
rgoris   
2012-01-11 11:33   
I noticed one detail that would be good to fix still:

When deleting multiple records at once, the message title should be:

"Delete Records" (with an additional s)
(0044248)
rgoris   
2012-01-11 11:42   
as per last note
(0044261)
hgbot   
2012-01-11 14:15   
Repository: erp/devel/pi
Changeset: ea807479cfa86bf1af9c05a49f5a75919b0aed93
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Jan 11 14:15:20 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ea807479cfa86bf1af9c05a49f5a75919b0aed93 [^]

Related to issue 19423: Added plural dialog title case

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0044264)
mtaal   
2012-01-11 14:23   
Reviewed
(0044296)
rgoris   
2012-01-12 11:30   
tested and considered solved
(0044344)
hudsonbot   
2012-01-14 21:20   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test
(0044372)
hudsonbot   
2012-01-14 21:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test