Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019422Openbravo ERPB. User interfacepublic2012-01-07 09:552012-01-14 21:21
Reporterjpcalvente 
Assigned Tomtaal 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP6 
Target Version3.0MP8Fixed in Version3.0MP8 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019422: Grid personalization not stored
DescriptionOpen a window (Sales order) in grid mode.
Hide and move any field.
Close the tab. Open again. The changes done, are not stored.
It happens also if you log out the app.
Steps To ReproduceOpen a window (Sales order) in grid mode.
Hide and move any field.
Close the tab. Open again. The changes done, are not stored.
It happens also if you log out the app.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 00195643.0MP8 closed mtaal Selected record is persisted in grid state, resulting in selected record when grid is re-opened with empty child tab 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2012-01-07 09:55jpcalventeNew Issue
2012-01-07 09:55jpcalventeAssigned To => dbaz
2012-01-07 09:55jpcalventeModules => Core
2012-01-07 09:55jpcalventeIssue Monitored: jpcalvente
2012-01-07 14:49dbazAssigned Todbaz => mtaal
2012-01-07 18:14jonalegriaesarteNote Added: 0044135
2012-01-07 18:14jonalegriaesartePriorityhigh => immediate
2012-01-07 18:14jonalegriaesarteTarget Version => 3.0MP8
2012-01-07 18:14jonalegriaesartePriorityimmediate => high
2012-01-09 08:49mtaalNote Added: 0044137
2012-01-09 08:49mtaalStatusnew => closed
2012-01-09 08:49mtaalResolutionopen => no change required
2012-01-09 13:14jpcalventeNote Added: 0044152
2012-01-09 13:16jonalegriaesarteStatusclosed => new
2012-01-09 13:16jonalegriaesarteResolutionno change required => open
2012-01-09 13:35mtaalNote Added: 0044153
2012-01-09 13:35mtaalStatusnew => feedback
2012-01-09 13:44mtaalNote Added: 0044157
2012-01-09 13:44mtaalTypedefect => feature request
2012-01-09 15:17mtaalNote Added: 0044160
2012-01-09 15:17mtaalTypefeature request => defect
2012-01-11 11:08hgbotCheckin
2012-01-11 11:08hgbotNote Added: 0044236
2012-01-11 11:08hgbotStatusfeedback => resolved
2012-01-11 11:08hgbotResolutionopen => fixed
2012-01-11 11:08hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fe6c4992e9bca91a500e1a0e5fb917d89a860c06 [^]
2012-01-11 11:14mtaalNote Added: 0044238
2012-01-11 11:17hgbotCheckin
2012-01-11 11:17hgbotNote Added: 0044239
2012-01-11 11:34mtaalNote Added: 0044244
2012-01-12 16:49hgbotCheckin
2012-01-12 16:49hgbotNote Added: 0044302
2012-01-12 17:49hgbotCheckin
2012-01-12 17:49hgbotNote Added: 0044312
2012-01-14 15:37dbazNote Added: 0044335
2012-01-14 15:37dbazStatusresolved => new
2012-01-14 15:37dbazResolutionfixed => open
2012-01-14 16:20mtaalStatusnew => scheduled
2012-01-14 16:20mtaalNote Added: 0044336
2012-01-14 16:20mtaalfix_in_branch => pi
2012-01-14 16:21mtaalNote Added: 0044337
2012-01-14 16:21mtaalStatusscheduled => resolved
2012-01-14 16:21mtaalResolutionopen => fixed
2012-01-14 17:08dbazNote Added: 0044338
2012-01-14 18:06dbazNote Added: 0044339
2012-01-14 18:06dbazStatusresolved => closed
2012-01-14 18:06dbazFixed in Version => 3.0MP8
2012-01-14 21:21hudsonbotCheckin
2012-01-14 21:21hudsonbotNote Added: 0044367
2012-01-14 21:21hudsonbotCheckin
2012-01-14 21:21hudsonbotNote Added: 0044368
2012-01-14 21:21hudsonbotCheckin
2012-01-14 21:21hudsonbotNote Added: 0044382
2012-01-14 21:21hudsonbotCheckin
2012-01-14 21:21hudsonbotNote Added: 0044384
2012-01-25 21:44mtaalRelationship addedrelated to 0019564

Notes
(0044135)
jonalegriaesarte   
2012-01-07 18:14   
In MP4, works fine
(0044137)
mtaal   
2012-01-09 08:49   
Persisting of grid settings is part of window personalization:
http://wiki.openbravo.com/wiki/User_Manual/Window_Personalization [^]

So you need to explicitly save a view to store grid layout changes.

gr. Martin
(0044152)
jpcalvente   
2012-01-09 13:14   
Try in Openbravo 3 MP4.2 to do this:

1. Open a window (Sales order) in grid mode.
2. Hide and move any field (e.g hide Organization field)
3. Close tab
4. Open again the same window (Sales Order). Here you can log out the app also.
5. Change is maintened

Note: without using saved views. This is something that worked fine.

i have review all MP from 4.2 and there has not bee any publihed change regarding this.
(0044153)
mtaal   
2012-01-09 13:35   
The first implementation of personalized grids was ment to be part of saved views. The change that you need to work with saved views is intended and by design and afaics this is not a bug.

Can you elaborate why you think this is a bug? (I don't see any reason at all...)

gr. Martin
(0044157)
mtaal   
2012-01-09 13:44   
Afaics the feature request is to make grid personalization available as an independent function as it worked before, possibly offering it as the community feature.
(0044160)
mtaal   
2012-01-09 15:17   
Form layout is persisted without saving views
The same should be done for grid layouts.
(0044236)
hgbot   
2012-01-11 11:08   
Repository: erp/devel/pi
Changeset: fe6c4992e9bca91a500e1a0e5fb917d89a860c06
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jan 11 11:07:29 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fe6c4992e9bca91a500e1a0e5fb917d89a860c06 [^]

Fixes issue 19422: Grid personalization not stored
Form and grid changes are persisted even if no view is saved. These form/grid settings act as defaults in case there is no default view.
This is only done in case of professional edition.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/utilities/ob-utilities.js
M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js
---
(0044238)
mtaal   
2012-01-11 11:14   
To test this, try 2 modes: with an activation key and without. Without an activation key the grid/form settings should not be persisted.

To test:
0) Enter an activation key
1) open sales invoice window, change the grid layout, change the form layout
2) do not save as a view
3) close the window, refresh the application
4) open sales invoice window, and check that the grid/form layout changes are applied even without a view
5) do some more layout changes and save as a view
6) re-open the window, see that the latest form/grid layout changes are not applied as there is not a view
7) select the view, the saved view changes should be applied
(0044239)
hgbot   
2012-01-11 11:17   
Repository: erp/devel/pi
Changeset: 3995e2e042037e9577076831d47c714cc8e264d2
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Wed Jan 11 11:16:29 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3995e2e042037e9577076831d47c714cc8e264d2 [^]

Related to issue 19422: Grid personalization not stored
Only use form/grid settings if there is no saved view

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0044244)
mtaal   
2012-01-11 11:34   
Updated the docs:
http://wiki.openbravo.com/wiki/User_Manual/Window_Personalization#Default_Form.2FGrid_Personalization_.28without_saved_views.29 [^]
(0044302)
hgbot   
2012-01-12 16:49   
Repository: erp/devel/pi
Changeset: 4056165061410466150d67df1e6a6f8349013eaa
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jan 12 16:49:09 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/4056165061410466150d67df1e6a6f8349013eaa [^]

Related to issue 19422: Grid personalization not stored
Enable form/grid personalization if no views are defined

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
---
(0044312)
hgbot   
2012-01-12 17:49   
Repository: erp/devel/pi
Changeset: cd4d937d352b393402716ffda1a6a127ba7b2efe
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jan 12 17:45:24 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cd4d937d352b393402716ffda1a6a127ba7b2efe [^]

Related to issue 19422: Grid personalization not stored
Apply grid/form preference in case there is no default

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/personalization/ob-personalize-form.js
---
(0044335)
dbaz   
2012-01-14 15:37   
If you hide, show or resize any column in the grid field the change is persisted if you just go away and come back (that's ok)

If you drag and drop the child level, making the top or the bottom level smaller, this change is not persisted if you go away and come back, but it is persisted in the saved view (if you save it, of course).

To be coherent, the levels height should be persisted too if you just go away and come back.
(0044336)
mtaal   
2012-01-14 16:20   
.
(0044337)
mtaal   
2012-01-14 16:21   
Storing location of child views is and was never part of individual grid/form personalization. This was and is only part of saved views. The only reason to support the current behavior, outside of saved views, is for light weight changes and not parent-child structures.

If you see a real need then please discuss with Rob Goris to open a feature request for this. Although afaics the value is very small... as it is already supported by saved views.

gr. Martin
(0044338)
dbaz   
2012-01-14 17:08   
For me is "strange" that with saved views we save:
* Grid: showed columns
* Grid: columns order
* Grid: columns size
* Grid: parent-child heights
* Form: inputs showed
* Form: inputs position
* Form: parent-child heights

And if you just go away and come back we "only" save:
* Grid: showed columns
* Grid: columns order
* Grid: columns size
* Form: inputs showed
* Form: inputs position

I have a feeling that the parent-child height are missing in the equation. Also it provides an strange effect, that when you come back, have everything as you have left, except these heights.
(0044339)
dbaz   
2012-01-14 18:06   
Reviewed @ changeset 15146 - ffeeaa93deac
(0044367)
hudsonbot   
2012-01-14 21:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test
(0044368)
hudsonbot   
2012-01-14 21:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test
(0044382)
hudsonbot   
2012-01-14 21:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test
(0044384)
hudsonbot   
2012-01-14 21:21   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test