Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019327Openbravo ERPB. User interfacepublic2011-12-18 20:552011-12-23 18:25
Reporterdbaz 
Assigned Todbaz 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0MP7 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019327: "Attachment" toolbar icon focus issues
DescriptionWhen clicking in "attachment" toolbar icon, the section is expanded, but the viewport doesn't move to the section
Steps To ReproduceAs "Openbravo Admin"
* Go to any record (example: "Sales Order")
* Go to form view of any record
* Click "attachment" toolbar icon

Notice that the section is opened, but the viewport doesn't move to the section.
Also, the submit popup is not opened if no attachment exists
Proposed Solution
Additional Information
TagsRegression
Relationships
related to design defect 0017508 closed dbaz Section headers jump up and down when expanding and collapsing 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-12-18 20:55dbazNew Issue
2011-12-18 20:55dbazAssigned To => dbaz
2011-12-18 20:55dbazModules => Core
2011-12-18 20:56dbazRelationship addedrelated to 0017508
2011-12-18 20:58hgbotCheckin
2011-12-18 20:58hgbotNote Added: 0043927
2011-12-18 20:58hgbotStatusnew => resolved
2011-12-18 20:58hgbotResolutionopen => fixed
2011-12-18 20:58hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/135bc8ba3ad0e67284ed539d23ac9671565ff7c6 [^]
2011-12-19 10:09mtaalNote Added: 0043933
2011-12-19 10:09mtaalStatusresolved => new
2011-12-19 10:09mtaalResolutionfixed => open
2011-12-19 13:56hgbotCheckin
2011-12-19 13:56hgbotNote Added: 0043941
2011-12-19 14:03dbazStatusnew => scheduled
2011-12-19 14:03dbazfix_in_branch => pi
2011-12-19 14:03dbazStatusscheduled => resolved
2011-12-19 14:03dbazResolutionopen => fixed
2011-12-19 14:25mtaalNote Added: 0043942
2011-12-19 14:25mtaalStatusresolved => closed
2011-12-19 14:25mtaalFixed in Version => 3.0MP7
2011-12-19 19:15hudsonbotCheckin
2011-12-19 19:15hudsonbotNote Added: 0043964
2011-12-22 03:53hudsonbotCheckin
2011-12-22 03:53hudsonbotNote Added: 0043991
2011-12-23 18:25dmitry_mezentsevTag Attached: Regression

Notes
(0043927)
hgbot   
2011-12-18 20:58   
Repository: erp/devel/pi
Changeset: 135bc8ba3ad0e67284ed539d23ac9671565ff7c6
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Sun Dec 18 20:58:28 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/135bc8ba3ad0e67284ed539d23ac9671565ff7c6 [^]

Fixed issue 19327: 'attachment' viewport now is placed ok when toolbar icon is pressed

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0043933)
mtaal   
2011-12-19 10:09   
A small thing, in the code I see this call:
this.view.viewForm.getItem('_attachments_')

many times, it is better/nicer to put it in a local var and then use that var.
(0043941)
hgbot   
2011-12-19 13:56   
Repository: erp/devel/pi
Changeset: f7b0ccdf01d30a6a4f47393b1c9c81cef6f1f95f
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Mon Dec 19 13:56:18 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/f7b0ccdf01d30a6a4f47393b1c9c81cef6f1f95f [^]

Related to issue 19327: code improvement

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js
---
(0043942)
mtaal   
2011-12-19 14:25   
Reviewed
(0043964)
hudsonbot   
2011-12-19 19:15   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/e646177b021f [^]

Maturity status: Test
(0043991)
hudsonbot   
2011-12-22 03:53   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9ac5e6f282ca [^]

Maturity status: Test