Openbravo Issue Tracking System - Openbravo ERP |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0019323 | Openbravo ERP | A. Platform | public | 2011-12-16 17:22 | 2011-12-22 03:53 |
|
| Reporter | alostale | |
| Assigned To | mtaal | |
| Priority | normal | Severity | minor | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | 3.0MP6 | |
| Target Version | 3.0MP7 | Fixed in Version | 3.0MP7 | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Web browser | |
| Modules | Core |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0019323: Shown in grid, not displayed fields are not editable |
| Description | When a field is marked as not displayed and shown in grid, it is not possible to edit it in grid view even if it should be. |
| Steps To Reproduce | -Create an updatable field in any window
-Set this field as not displayed and shown in grid
-Open that window and edit a record in grid mode -> note this field cannot be edited. |
| Proposed Solution | |
| Additional Information | |
| Tags | Regression |
| Relationships | | related to | feature request | 0019122 | 3.0MP6 | closed | mtaal | Support calculated fields | | related to | defect | 0019311 | 3.0MP7 | closed | mtaal | Some fields are shown centered while editing in grid |
|
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2011-12-16 17:22 | alostale | New Issue | |
| 2011-12-16 17:22 | alostale | Assigned To | => alostale |
| 2011-12-16 17:22 | alostale | Modules | => Core |
| 2011-12-16 17:22 | alostale | Tag Attached: Regression | |
| 2011-12-16 17:35 | alostale | Note Added: 0043908 | |
| 2011-12-16 17:36 | alostale | Relationship added | related to 0019122 |
| 2011-12-16 17:36 | alostale | Assigned To | alostale => mtaal |
| 2011-12-16 17:48 | alostale | Note Added: 0043909 | |
| 2011-12-19 10:54 | hgbot | Checkin | |
| 2011-12-19 10:54 | hgbot | Note Added: 0043934 | |
| 2011-12-19 10:54 | hgbot | Status | new => resolved |
| 2011-12-19 10:54 | hgbot | Resolution | open => fixed |
| 2011-12-19 10:54 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/e643cc4264701e62f2e024529878453cd095c7d1 [^] |
| 2011-12-19 10:55 | mtaal | Relationship added | related to 0019311 |
| 2011-12-19 13:04 | alostale | Note Added: 0043940 | |
| 2011-12-19 13:04 | alostale | Status | resolved => closed |
| 2011-12-19 13:04 | alostale | Fixed in Version | => 3.0MP7 |
| 2011-12-22 03:53 | hudsonbot | Checkin | |
| 2011-12-22 03:53 | hudsonbot | Note Added: 0043989 | |
|
Notes |
|
|
|
It might be introduced in MP6 by 0019122 changeset dfee4d514c2b
In OBStandardView.prepareGridFields
@@ -1954,7 +1960,8 @@
}
// correct some stuff coming from the form fields
- if (!fld.displayed) {
+ if (fld.displayed === false) {
+ fld.canEdit = false;
fld.visible = true;
fld.alwaysTakeSpace = true;
}
Assigning it to Martin has he did this change. |
|
|
|
|
|
Removing the line fld.canEdit = false; seems to solve this problem, but I don't know the purpose of this line. |
|
|
|
(0043934)
|
|
hgbot
|
|
2011-12-19 10:54
|
|
Repository: erp/devel/pi
Changeset: e643cc4264701e62f2e024529878453cd095c7d1
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Dec 19 10:53:17 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/e643cc4264701e62f2e024529878453cd095c7d1 [^]
Fixes issue 19323: Shown in grid, not displayed fields are not editable
---
M .hgignore
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
|
|
|
|
|
Checked on pi@26982b3129be
*Code review:
-.hgignore shouldn't be changed
*Issue:
-With this change, the issue is not reproducible anymore
*Regression possibility:
-The issue reverts part of dfee4d514c2b changeset. Checked calculated fields still work.
-From a discussion with Martin regarding the purpose of the original change: "It was added as part of the calculated fields development. To me it seems to have been a mistake that I did that change as part of that development..." |
|
|
|
|
|