Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019322Openbravo ERPA. Platformpublic2011-12-16 14:302012-01-24 17:16
ReporterioritzCia 
Assigned Toalostale 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS20OS VersionUbuntu 10.04
Product Version 
Target Version3.0MP8Fixed in Version3.0MP8 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome, Mozilla Firefox
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019322: Email forwarding does not refresh information from templates.
DescriptionIn the email forwarding feature, the template gets loaded when building the popup but it does not get refreshed when another one is selected.
Steps To Reproduce- Configure e-mail forwarding following this guide: http://wiki.openbravo.com/wiki/Projects/Outbound_Email/User_Guide [^]
- Configure two templates for the same document type.
- Go to a document and click to send the email.
- One of the templates is loaded, but if the user goes to the combo and selects another one the values of that template are not loaded.
- Also, there is the posibility of changing the from field, but it will not matter, it will send the email from the account configured in the Client window.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0019472 acknowledged Triage Platform Base POC design defects 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-12-16 14:30ioritzCiaNew Issue
2011-12-16 14:30ioritzCiaAssigned To => alostale
2011-12-16 14:30ioritzCiaWeb browser => Google Chrome, Mozilla Firefox
2011-12-16 14:30ioritzCiaModules => Core
2011-12-16 14:37ioritzCiaWeb browserGoogle Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2011-12-16 14:37ioritzCiaTarget Version => 3.0MP8
2011-12-16 14:37ioritzCiaIssue Monitored: networkb
2011-12-16 14:38ioritzCiaWeb browserGoogle Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2011-12-16 14:38ioritzCiaResolution time => 1326927600
2012-01-02 12:42ioritzCiaWeb browserGoogle Chrome, Mozilla Firefox => Google Chrome, Mozilla Firefox
2012-01-02 12:42ioritzCiaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=3013#r3013
2012-01-11 09:04alostaleNote Added: 0044227
2012-01-11 10:34azabaletaNote Added: 0044234
2012-01-12 11:07alostaleRelationship addedrelated to 0019472
2012-01-12 11:11alostaleNote Added: 0044294
2012-01-12 11:12alostaleAssigned Toalostale => dbaz
2012-01-14 20:04dbazNote Added: 0044340
2012-01-15 22:26dbazAssigned Todbaz => alostale
2012-01-23 09:30hgbotCheckin
2012-01-23 09:30hgbotNote Added: 0044473
2012-01-23 09:30hgbotStatusnew => resolved
2012-01-23 09:30hgbotResolutionopen => fixed
2012-01-23 09:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/82d33010411343c836bff19076bbd08e9693023e [^]
2012-01-23 09:34alostaleNote Added: 0044474
2012-01-23 20:12hgbotCheckin
2012-01-23 20:12hgbotNote Added: 0044493
2012-01-24 13:34hudsonbotCheckin
2012-01-24 13:34hudsonbotNote Added: 0044506
2012-01-24 13:34hudsonbotCheckin
2012-01-24 13:34hudsonbotNote Added: 0044512
2012-01-24 17:16dbazNote Added: 0044517
2012-01-24 17:16dbazStatusresolved => closed
2012-01-24 17:16dbazFixed in Version => 3.0MP8

Notes
(0044227)
alostale   
2012-01-11 09:04   
There are several design problems:
-Template is taken regarding template organization. In case there is a template exactly in the same organization as the document, it is selected, if not it looks in *. But in case the template is in a parent organization of the current one, it is not selected.
-When selecting just one document to email, the UI shows a combo where the template to use should be selected if many are defined (this is not working). But in case many documents are selected UI hides this template selection. How should it behave in this case?
-There is no UI at all to select template when printing.
(0044234)
azabaleta   
2012-01-11 10:34   
Hi Asier, Im gonna answer your points:

There are several design problems:
-Template is taken regarding template organization. In case there is a template exactly in the same organization as the document, it is selected, if not it looks in *. But in case the template is in a parent organization of the current one, it is not selected.

AZA: Known. Would be nice to design better, but is not a must now.

-When selecting just one document to email, the UI shows a combo where the template to use should be selected if many are defined (this is not working). But in case many documents are selected UI hides this template selection. How should it behave in this case?

AZA: User selects 10 mails and click on send email There should also have the possibility to select template. The goal is to allow the user to sent mail from ultiple documents at the same time (working) and being able to select between the email templates (not working).

-There is no UI at all to select template when printing.

AZA: Known. We dont support this feature, so there is no bug here.
(0044294)
alostale   
2012-01-12 11:11   
As discussed with AZA:

-For now design defects are not going to be fixed (they are reported in 0019472).
-To fix this concrete issue: in case several templates are available for the same document type, when selecting one in the combo, fields coming from email configuration should be refreshed in the UI.
(0044340)
dbaz   
2012-01-14 20:04   
- Also, there is the posibility of changing the from field, but it will not matter, it will send the email from the account configured in the Client window.

<-- In fact this "From" field really is a "Reply to" field. It will be renamed too to avoid confusions.
(0044473)
hgbot   
2012-01-23 09:30   
Repository: erp/devel/pi
Changeset: 82d33010411343c836bff19076bbd08e9693023e
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Mon Jan 23 09:29:23 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/82d33010411343c836bff19076bbd08e9693023e [^]

fixed bug 19322: Refresh subject and body when changing poc template

---
M src/org/openbravo/erpCommon/utility/reporting/printing/EmailOptions.html
M src/org/openbravo/erpCommon/utility/reporting/printing/PrintController.java
---
(0044474)
alostale   
2012-01-23 09:34   
The fix adds logic to refresh subject and body in case a different template is selected in the UI. It is very localized in this part and just adds the new logic, so no other flows are affected.

Test plan:

-Define 2 different templates and email definitions for a doc type (i.e. AR Invoice).
-In sales invoice select an AR invoice
-Click in the email button: notice the combo is populated with the 2 templates
-Select the default one and send email: note the template and email definition are used
-Select the other template: note the in the UI the other email definition replaces the original one, the file name changes according to the new template file name.
-Send the email: the selected email definition and template are used in the email.
-
(0044493)
hgbot   
2012-01-23 20:12   
Repository: erp/devel/pi
Changeset: 67671c4afeb674f4e4ecf07e7bfed2b9174cb845
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Mon Jan 23 20:16:27 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/67671c4afeb674f4e4ecf07e7bfed2b9174cb845 [^]

Related to issue 19322: Renamed 'From' to 'Reply-to' since it is its real behavior

---
M src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M src/org/openbravo/erpCommon/utility/reporting/printing/EmailOptions.html
---
(0044506)
hudsonbot   
2012-01-24 13:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9a942bd15053 [^]

Maturity status: Test
(0044512)
hudsonbot   
2012-01-24 13:34   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9a942bd15053 [^]

Maturity status: Test
(0044517)
dbaz   
2012-01-24 17:16   
Reviewed @ changeset 15187 - 91a0972e4ee7