Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019321Openbravo ERPA. Platformpublic2011-12-16 13:512012-03-02 15:36
Reporteriperdomo 
Assigned Tomarvintm 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS Version3.1.5-1-ARCH
Product Version 
Target VersionFixed in Version3.0MP9 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserGoogle Chrome
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019321: Values of columns marked as stored in session, are not properly calculated when navigating directly to a child record
DescriptionSome display logic may depend on values of parent tabs. For this, the approach is to mark "Stored in Session" in the parent table and then use the value.

When making a direct link to a child tab, it seems that this values are not properly handled, and the display logic fails.
Steps To Reproduce* As System Administrator role
* Open: Window Tabs and Fields
* Open any record of window type: Maintain
* Navigate to the first tab, and scroll down and look for the following fields: New Function, Remove Function. Note: this fields shouldn't be present.

* Now, search for a window of type: Pick and Execute
* Open the first tab, and search for the same fields. Since the Window Type is marked as stored in session, the display logic works properly.

* Close the Window
* From the "Recent Documents" links in the Workspace, navigate directly to the latest visited tab. (Note: It should be from a Pick and Execute window)
* The record opens correctly
* Scroll down and try to look for the same fields. BOOM! The fields are not present
* Open the parent tab, and visit the record in form view (stored in session values are recalculated)
* Visit again the tab definition and look for the fields. Now they are present.
Proposed Solution* Fix the calculation of stored in session column values when visiting a record directly
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-12-16 13:51iperdomoNew Issue
2011-12-16 13:51iperdomoAssigned To => alostale
2011-12-16 13:51iperdomoWeb browser => Google Chrome
2011-12-16 13:51iperdomoModules => Core
2012-02-03 11:44alostaleAssigned Toalostale => marvintm
2012-02-13 11:30hgbotCheckin
2012-02-13 11:30hgbotNote Added: 0045058
2012-02-13 11:30hgbotStatusnew => resolved
2012-02-13 11:30hgbotResolutionopen => fixed
2012-02-13 11:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/86ac4bc5c360e27673ef283f372728cfcc66e025 [^]
2012-02-13 11:33marvintmNote Added: 0045059
2012-02-14 21:41dbazNote Added: 0045132
2012-02-14 21:41dbazStatusresolved => closed
2012-02-14 21:41dbazFixed in Version => 3.0MP9
2012-03-02 15:36hudsonbotCheckin
2012-03-02 15:36hudsonbotNote Added: 0045833

Notes
(0045058)
hgbot   
2012-02-13 11:30   
Repository: erp/devel/pi
Changeset: 86ac4bc5c360e27673ef283f372728cfcc66e025
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Mon Feb 13 11:30:11 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/86ac4bc5c360e27673ef283f372728cfcc66e025 [^]

Fixed issue 19321. Session variables will be computed correctly in case the Parent Id is 'null' (as a string)

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0045059)
marvintm   
2012-02-13 11:33   
The problem in this case was that the FIC was receiving a string whose value was "null", and it didn't set the parentId to a real null. Therefore, a parent record with id "null" was searched, even after having found a real parent record.

Test plan:
- Apart from testing the example described in the issue, test that all four FIC modes (NEW, EDIT, CHANGE, and SETSESSION) still work in a couple of windows.
(0045132)
dbaz   
2012-02-14 21:41   
Reviewed @ changeset 15475 - 215fbb471eaa
(0045833)
hudsonbot   
2012-03-02 15:36   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test