Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019315Openbravo ERPA. Platformpublic2011-12-15 20:072012-02-28 08:36
Reportershuehner 
Assigned ToAugustoMauch 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version3.0MP6 
Target Version3.0MP9Fixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browserMozilla Firefox
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019315: The 'Take a look around' & 'Show me how' links in the 'Getting started widget' are broken on FF8
DescriptionBoth in demo.openbravo.com and live.builds.openbravo.com after login the 'Getting started' widget is shown by default in the top-right part of the Workspace.

In there are two links:
'Take a look around'
'Show me how'

Both are working fine when used with chromium but do not work when being used with Firefox 8.0.

When used in FF8 they do open a new view tab as normal but this just shows loading forever.
Additionally after opening the new application tab some kind of extra 5* 1px something is shown to the right of that new tab (see 1px 'artefact' in the right part of attached screenshot).
Those 5 artefacts are still present after closing that non-functioning view tab.

Clicking them seems to not to anything.
However when reloading the complete browser tab the system tries to restore that state and open 5 view-tabs named 'OBGettingStartedView' and displays the following stacktrace to the user (also 5 times). See second screenshot for detail.

contentsURL parameter is required
Stack trace:


    OBGettingStartedView.initWidget(args=>Obj, undef, undef, undef, undef, undef, undef, undef, undef, undef, undef, undef, undef)
    Canvas.init(_1=>Obj, _2=>undef, _3=>undef, _4=>undef, _5=>undef, _6=>undef, _7=>undef, _8=>undef, _9=>undef, _10=>undef, _11=>undef, _12=>undef, _13=>undef)
    Class.completeCreation(_1=>Obj, _2=>undef, _3=>undef, _4=>undef, _5=>undef, _6=>undef, _7=>undef, _8=>undef, _9=>undef, _10=>undef, _11=>undef, _12=>undef, _13=>undef)
    [c]Class.create(_1=>Obj, _2=>undef, _3=>undef, _4=>undef, _5=>undef, _6=>undef, _7=>undef, _8=>undef, _9=>undef, _10=>undef, _11=>undef, _12=>undef, _13=>undef)
    showTab(viewName=>"OBGettingStartedView", params=>Obj, state=>undef)
    getView(viewName=>"OBGettingStartedView", params=>Obj, state=>undef)
    getView(viewName=>"OBGettingStartedView", params=>Obj, state=>undef)
    [a]Canvas.openView()
    [c]Class.fireCallback(_1=>[a]Canvas.openView(), _2=>undef, _3=>Array[0], _4=>[Canvas ID:isc_Canvas_1], _5=>undef) on [Class EventHandler]
    [c]Class.$cm()
    ** recursed on [c]Class.fireCallback


Steps To ReproduceSee description for all details.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng 19315_1.png (5,015) 2011-12-15 20:07
https://issues.openbravo.com/file_download.php?file_id=4834&type=bug
png

png 19315_2.png (144,646) 2011-12-15 20:07
https://issues.openbravo.com/file_download.php?file_id=4835&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2011-12-15 20:07shuehnerNew Issue
2011-12-15 20:07shuehnerAssigned To => alostale
2011-12-15 20:07shuehnerWeb browser => Mozilla Firefox
2011-12-15 20:07shuehnerModules => Core
2011-12-15 20:07shuehnerFile Added: 19315_1.png
2011-12-15 20:07shuehnerFile Added: 19315_2.png
2012-01-11 16:14dmitry_mezentsevWeb browserMozilla Firefox => Mozilla Firefox
2012-01-11 16:14dmitry_mezentsevNote Added: 0044267
2012-02-15 14:20jonalegriaesarteWeb browserMozilla Firefox => Mozilla Firefox
2012-02-15 14:20jonalegriaesarteTarget Version => 3.0MP9
2012-02-16 10:14alostaleAssigned Toalostale => AugustoMauch
2012-02-22 11:31AugustoMauchNote Added: 0045347
2012-02-22 11:34AugustoMauchNote Added: 0045348
2012-02-22 11:38AugustoMauchStatusnew => scheduled
2012-02-22 11:38AugustoMauchfix_in_branch => pi
2012-02-22 11:39AugustoMauchStatusscheduled => resolved
2012-02-22 11:39AugustoMauchFixed in Version => 3.0MP9
2012-02-22 11:39AugustoMauchFixed in SCM revision => --
2012-02-22 11:39AugustoMauchResolutionopen => fixed
2012-02-28 08:36alostaleNote Added: 0045493
2012-02-28 08:36alostaleStatusresolved => closed
2012-02-28 08:36alostaleFixed in Version3.0MP9 =>

Notes
(0044267)
dmitry_mezentsev   
2012-01-11 16:14   
Visible in the Demo which is Professional Instance so set it as OBPS=Y.

With FF9.0.1 happens the same.
(0045347)
AugustoMauch   
2012-02-22 11:31   
The problem was due to the creation of the params parameter of ob-view-manager.js. It expected and object, but the widget was creating an array with properties.

In the showTab function a shallow clone of params was done. In Chrome it worked fine, but in firefox if a shallow clone of an array with properties is done, the array returned loses its properties.

The action-proxy.js file has been modified in butler. Instead of creating an array and then adding properties to it using put, an object is created and the properties are added using the params[keyName] = value notation.
(0045348)
AugustoMauch   
2012-02-22 11:34   
The change only affects the Getting Started widget. It has been tested successfully both in Chrome and in Firefox.

This fix is not risky.
(0045493)
alostale   
2012-02-28 08:36   
Fixed in butler server, tested and code reviewed.