Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019236Openbravo ERPB. User interfacepublic2011-12-02 16:522012-03-02 15:38
Reporterdbaz 
Assigned Tomtaal 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0MP9Fixed in Version3.0MP9 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019236: Automatic text selection doesn't work sometimes
DescriptionAutomatic text selection, when you navigate using tab key, doesn't work sometimes
Steps To ReproduceIn Form View (in Chrome and Firefox):
-------------------------------------
As "Openbravo admin":
* Go to "Document Type" window
* Click new
* Move through the form using tab key
* Go back to the beginning using shift+tab key
You notice that some combo boxes get the text selected just few milliseconds.



In Grid View (even more strange) ONLY IN FIREFOX!!!:
----------------------------------------------------
As "Openbravo admin":
* Go to "Sales Order" window
* Select any record and go to lines
* Open product dropdown using alt-arrow-down (remember we are in editing the GRID)
* Arrow-down to select a product
* Hit TAB key
You notice that the next input text is not selected, but if you write, you overwrite the content (as it if be selected)
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0019248 closed mtaal Focus does not move to next field when selecting a value in a combo box 
related to defect 00191863.0MP6 closed mtaal Dropdown remains open when tabbing out from selection 
Attached Filesdiff 19236.diff (1,492) 2011-12-05 16:50
https://issues.openbravo.com/file_download.php?file_id=4819&type=bug
Issue History
Date ModifiedUsernameFieldChange
2011-12-02 16:52dbazNew Issue
2011-12-02 16:52dbazAssigned To => mtaal
2011-12-02 16:52dbazModules => Core
2011-12-02 16:52dbazOBNetwork customer => No
2011-12-05 16:50mtaalFile Added: 19236.diff
2011-12-05 18:02psarobeRelationship addedrelated to 0019186
2012-01-05 17:10mtaalTarget Version => 3.0MP9
2012-02-09 12:18mtaalRelationship addeddepends on 0019248
2012-02-09 12:18mtaalStatusnew => scheduled
2012-02-09 12:18mtaalNote Added: 0044956
2012-02-09 12:18mtaalfix_in_branch => pi
2012-02-09 12:19mtaalNote Added: 0044957
2012-02-09 12:19mtaalStatusscheduled => resolved
2012-02-09 12:19mtaalFixed in Version => 3.0MP9
2012-02-09 12:19mtaalFixed in SCM revision => cc8d0c0aab83626e23ff59e3909d04bc50c3ba2c
2012-02-09 12:19mtaalResolutionopen => fixed
2012-02-14 18:11dbazNote Added: 0045127
2012-02-14 18:11dbazStatusresolved => new
2012-02-14 18:11dbazResolutionfixed => open
2012-02-14 18:11dbazFixed in Version3.0MP9 =>
2012-02-18 22:19dbazNote Edited: 0045127bug_revision_view_page.php?bugnote_id=0045127#r3184
2012-02-19 15:28hgbotCheckin
2012-02-19 15:28hgbotNote Added: 0045255
2012-02-19 15:28hgbotStatusnew => resolved
2012-02-19 15:28hgbotResolutionopen => fixed
2012-02-19 15:28hgbotFixed in SCM revisioncc8d0c0aab83626e23ff59e3909d04bc50c3ba2c => http://code.openbravo.com/erp/devel/pi/rev/5e8637a2a10b65ccaa75b357399c0463d025703e [^]
2012-02-21 15:20dbazNote Added: 0045309
2012-02-21 15:20dbazStatusresolved => closed
2012-02-21 15:20dbazFixed in Version => 3.0MP9
2012-03-02 15:38hudsonbotCheckin
2012-03-02 15:38hudsonbotNote Added: 0045889

Notes
(0044956)
mtaal   
2012-02-09 12:18   
resolved by 19248
(0044957)
mtaal   
2012-02-09 12:19   
resolved by 19248

Repository: erp/devel/pi
Changeset: cc8d0c0aab83626e23ff59e3909d04bc50c3ba2c
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Feb 09 11:52:20 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/cc8d0c0aab83626e23ff59e3909d04bc50c3ba2c [^] [^]

Fixes issue 19248: Focus does not move to next field when selecting a value in a combo box
Use correct blur method to prevent current item from getting refocused instead of next item

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
---
(0045127)
dbaz   
2012-02-14 18:11   
(edited on: 2012-02-18 22:19)
This case still fails in the same way it has been reported (notice that the keyboard usage):

In Grid View (even more strange) ONLY IN WINDOWS (at least Win7) FIREFOX!!!:
---------------------------------------------------------------------------
As "Openbravo admin":
* Go to "Sales Order" window
* Select any record and go to lines
* Open product dropdown using alt-arrow-down (remember we are in editing the GRID)
* Arrow-down to select a product
* Hit TAB key
You notice that the next input text is not selected, but if you write, you overwrite the content (as it if be selected)
(0045255)
hgbot   
2012-02-19 15:28   
Repository: erp/devel/pi
Changeset: 5e8637a2a10b65ccaa75b357399c0463d025703e
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Feb 19 15:27:40 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/5e8637a2a10b65ccaa75b357399c0463d025703e [^]

Fixes issue 19236: Automatic text selection doesn't work sometimes
Changed the way the next focus item is computed, on change is done before moving the focus, focus is moved when the fic call returns, redraw is done explicitly

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-date.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0045309)
dbaz   
2012-02-21 15:20   
Reviewed @ changeset 15553 - 74e03242ccdc
(0045889)
hudsonbot   
2012-03-02 15:38   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test