Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019191Openbravo ERP09. Financial managementpublic2011-11-25 17:142011-11-30 12:57
Reportereduardo_Argal 
Assigned Toeduardo_Argal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionpiFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customerNo
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019191: Bank Statement Import does not find Business partner information from previous bank statement files
DescriptionBank Statement Import does not find Business partner information from previous bank statement files. It should use already imported bank statements information to better find out which is the business partner behind each bank statement line
Steps To Reproduce1) import a bank statement in a newly created financial account
2) manually associate a business partner to any of the lines which were not automatically assigned
3) import same bank statement file for new dates
Result: system should now automatically assign the same business partner we chose before for the same line, but it doesn't do it
Proposed SolutionReview code: setting of parameters for an hql is wrong and that drives into the system not finding the proper business partner
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0019192pi closed eduardo_Argal Bank Statement Import does not find Business partner information from previous bank statement files 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-11-25 17:14eduardo_ArgalNew Issue
2011-11-25 17:14eduardo_ArgalAssigned To => eduardo_Argal
2011-11-25 17:14eduardo_ArgalModules => Advanced Payables and Receivables Mngmt
2011-11-25 17:14eduardo_ArgalOBNetwork customer => No
2011-11-25 17:15eduardo_ArgalStatusnew => scheduled
2011-11-25 17:15eduardo_Argalfix_in_branch => pi
2011-11-25 17:19hgbotCheckin
2011-11-25 17:19hgbotNote Added: 0043344
2011-11-25 17:19hgbotStatusscheduled => resolved
2011-11-25 17:19hgbotResolutionopen => fixed
2011-11-25 17:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a8ab56fc2f1ca676ba995959da2397a679601c21 [^]
2011-11-25 17:23eduardo_ArgalNote Added: 0043349
2011-11-25 17:32eduardo_ArgalNote Added: 0043361
2011-11-25 17:32eduardo_ArgalStatusresolved => new
2011-11-25 17:32eduardo_ArgalResolutionfixed => open
2011-11-25 17:32eduardo_ArgalStatusnew => scheduled
2011-11-25 17:32hgbotCheckin
2011-11-25 17:32hgbotNote Added: 0043362
2011-11-25 17:32hgbotStatusscheduled => resolved
2011-11-25 17:32hgbotResolutionopen => fixed
2011-11-25 17:32hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/devel/pi/rev/a8ab56fc2f1ca676ba995959da2397a679601c21 [^] => http://code.openbravo.com/erp/devel/pi/rev/64f6bc8931fdcf8a08c394ebced9d941a854e085 [^]
2011-11-30 12:37hudsonbotCheckin
2011-11-30 12:37hudsonbotNote Added: 0043562
2011-11-30 12:37hudsonbotCheckin
2011-11-30 12:37hudsonbotNote Added: 0043563
2011-11-30 12:56vmromanosNote Added: 0043573
2011-11-30 12:57vmromanosStatusresolved => closed

Notes
(0043344)
hgbot   
2011-11-25 17:19   
Repository: erp/devel/pi
Changeset: a8ab56fc2f1ca676ba995959da2397a679601c21
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Fri Nov 25 17:18:54 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/a8ab56fc2f1ca676ba995959da2397a679601c21 [^]

Fixes bug 19191: Bank Statement Import does not find Business partner information from previous bank statement files

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
M src-db/database/model/tables/C_TAX.xml
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/Cbpvendoracct.class
M src/org/openbravo/erpCommon/ad_callouts/SE_CalculateExchangeRate.java
M src/org/openbravo/erpCommon/ad_forms/DocFINFinAccTransaction.java
M src/org/openbravo/erpCommon/ad_forms/DocFINPayment.java
M src/org/openbravo/erpCommon/ad_forms/DocFINReconciliation.java
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/CTaxTaxbase.class
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/CTaxTaxbaseData.class
A src-util/buildvalidation/src/org/openbravo/buildvalidation/CTaxTaxbase.java
A src-util/buildvalidation/src/org/openbravo/buildvalidation/CTaxTaxbase_data.xsql
---
(0043349)
eduardo_Argal   
2011-11-25 17:23   
TESTING PLAN:
1) import a bank statement in a newly created financial account
2) manually associate a business partner to any of the lines which were not automatically assigned
3) import same bank statement file for new dates
Result: system should now automatically assign the same business partner we chose before for the same line

REGRESSIONS
Regression risk is really low as we just modify order of inserting a parameter
(0043361)
eduardo_Argal   
2011-11-25 17:32   
reopened due to wrong push
(0043362)
hgbot   
2011-11-25 17:32   
Repository: erp/devel/pi
Changeset: 64f6bc8931fdcf8a08c394ebced9d941a854e085
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Fri Nov 25 17:32:31 2011 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/64f6bc8931fdcf8a08c394ebced9d941a854e085 [^]

Fixes bug 19191: Bank Statement Import does not find Business partner information from previous bank statement files

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_BankStatementImport.java
---
(0043562)
hudsonbot   
2011-11-30 12:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/01809c7b3135 [^]

Maturity status: Test
(0043563)
hudsonbot   
2011-11-30 12:37   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/01809c7b3135 [^]

Maturity status: Test
(0043573)
vmromanos   
2011-11-30 12:56   
Code review OK (without taking into account backout a8ab56fc2f1c)
Testing OK. The system adds Business Partner taking into account previous processed bank statement lines