Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0019165Openbravo ERP07. Sales managementpublic2011-11-24 10:182012-03-02 15:35
Reporterjecharri 
Assigned Tomarvintm 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version3.0MP9Fixed in Version3.0MP9 
Merge Request Status
Review Assigned To
OBNetwork customerOBPS
Web browserGoogle Chrome
ModulesCore
Support ticket13365
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0019165: The account selector is not working properly in grid view.
DescriptionWhen you try to create one "Invoce Line" with check "Financial Line" checked, if you click on the account selector, it doesn't show anything
Steps To ReproduceAs "Group Admin" go to "Sales Invoice" Window (notice that you have to have some "G/L Item" defined with check "Enable in Financial Invoices" checked).
-Create a "Header".
-After that create a "Line" in grid view.
-Put visible the columns "Financial Invoice Line" and "Account".
-Check the checkbox "Financial Invoice Line" and try to expand the account selector.
-It doesn't work.

It happens only the firs time.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0019166 closed jonalegriaesarte The account selector is not working properly in grid view (ll) 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2011-11-24 10:18jecharriNew Issue
2011-11-24 10:18jecharriAssigned To => jonalegriaesarte
2011-11-24 10:18jecharriWeb browser => Google Chrome
2011-11-24 10:18jecharriModules => Core
2011-11-24 10:18jecharriOBNetwork customer => Yes
2011-11-24 10:18jecharriSupport ticket => 13365
2011-11-24 10:18jecharriResolution time => 1329260400
2011-11-24 10:51jecharriRelationship addedrelated to 0019166
2012-01-03 12:48jonalegriaesarteAssigned Tojonalegriaesarte => alostale
2012-01-20 13:43alostaleAssigned Toalostale => marvintm
2012-01-20 13:43alostaleNote Added: 0044470
2012-01-23 10:18marvintmWeb browserGoogle Chrome => Google Chrome
2012-01-23 10:18marvintmTarget Version3.0MP8 => 3.0MP9
2012-02-09 10:19hgbotCheckin
2012-02-09 10:19hgbotNote Added: 0044947
2012-02-09 10:19hgbotStatusnew => resolved
2012-02-09 10:19hgbotResolutionopen => fixed
2012-02-09 10:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/634e843d6f22049c10eb8a7fc62661668e3c7669 [^]
2012-02-09 10:30hgbotCheckin
2012-02-09 10:30hgbotNote Added: 0044948
2012-02-16 14:26AugustoMauchNote Added: 0045196
2012-02-16 14:26AugustoMauchStatusresolved => closed
2012-02-16 14:26AugustoMauchFixed in Version => 3.0MP9
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045780
2012-03-02 15:35hudsonbotCheckin
2012-03-02 15:35hudsonbotNote Added: 0045781

Notes
(0044470)
alostale   
2012-01-20 13:43   
The problem is reproducible in this case:
-Edit a record in grid
-While editing shown in grid a column that has a combo

FIC is in charge of returning possible values of combos. Because of optimizations, values only for displayed columns are retrieved. When a new column is displayed, possible values for it are not requested.

Proposed solution: keep this optimization, but when displaying a new combo column in grid retrieve its possible values.

This proposed solution is risky because modifies a very central piece of OB3. It shouldn't be included in mp8.
(0044947)
hgbot   
2012-02-09 10:19   
Repository: erp/devel/pi
Changeset: 634e843d6f22049c10eb8a7fc62661668e3c7669
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Feb 09 09:47:31 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/634e843d6f22049c10eb8a7fc62661668e3c7669 [^]

Fixed issue 19165. Two changes have been made:
- The existing optimization (not to compute the combos in case they are not needed) has been preserved, but slightly changed. Now, the combos for all the 'visibleProperties' will be computed, regardless of the isDisplayed status.
- A call to the FIC has been added in case the grid is in editing mode, and the user changes the visible fields. This call to the FIC will recompute the column values, and set the grid in editing mode when it ends, because the change to the visible fields removes the editing setting in the grid.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/EnumUIDefinition.java
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/FKComboUIDefinition.java
---
(0044948)
hgbot   
2012-02-09 10:30   
Repository: erp/devel/pi
Changeset: 8a7c198a7345dd59d0bc98ebe3d1bc15ec3dd73d
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Feb 09 10:29:31 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/8a7c198a7345dd59d0bc98ebe3d1bc15ec3dd73d [^]

Related to issue 19165. Fixed optimization for NEW mode in FIC.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/window/FormInitializationComponent.java
---
(0045196)
AugustoMauch   
2012-02-16 14:26   
Code reviewed and verified
(0045780)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test
(0045781)
hudsonbot   
2012-03-02 15:35   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test